Skip to contentSkip to conversation

reset: zynq: remove unneeded call to platfrom_set_drvdata()

PATCH Applied Andrei Coardos 3 participants 3 messages Aug 7, 2023 – Aug 8, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 reset: zynq: remove unneeded call to platfrom_set_drvdata()

This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.

---
 drivers/reset/reset-zynq.c | 1 -
 1 file changed, 1 deletion(-)
drivers/reset/reset-zynq.c +0 -1
index 706bbbbb4ec7..688b512882ec 100644
@@ -94,7 +94,6 @@ static int zynq_reset_probe(struct platform_device *pdev)
 	priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
 	if (!priv)
 		return -ENOMEM;
-	platform_set_drvdata(pdev, priv);
 
 	priv->slcr = syscon_regmap_lookup_by_phandle(pdev->dev.of_node,
 						     "syscon");
Signature · 7 lines
2.34.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Andrei Coardos

This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.

Quoted 18 lines
---
 drivers/reset/reset-zynq.c | 1 -
 1 file changed, 1 deletion(-)
drivers/reset/reset-zynq.c +0 -2
index 706bbbbb4ec7..688b512882ec 100644
@@ -94,7 +94,6 @@ static int zynq_reset_probe(struct platform_device *pdev)
        priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
        if (!priv)
                return -ENOMEM;
-       platform_set_drvdata(pdev, priv);
 
        priv->slcr = syscon_regmap_lookup_by_phandle(pdev->dev.of_node,
                                                     "syscon");
--
Quoted 2 lines

2.34.1

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

maintainer Applied
#2 lore raw
In reply to Andrei Coardos
Quoted 6 lines · Andrei Coardos

This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.

Thank you, applied to reset/next.

regards
Philipp

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel