tpm/tpm_tis: Disable interrupts for Lenovo Thinkpad E14 Gen 2 and 13s-IML
Subsystems (2)
PATCH 1/1 tpm/tpm_tis: Disable interrupts for Lenovo Thinkpad E14 Gen 2 and 13s-IML
Like other Lenovo laptops, Thinkpad E14 Gen 2 and Thinkpad 13s-IML also require to disable the tpm_tis interrupts for avoiding a boot hang.
--- drivers/char/tpm/tpm_tis.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)
drivers/char/tpm/tpm_tis.c +16 -0
@@ -130,6 +130,22 @@ static const struct dmi_system_id tpm_tis_dmi_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "Laptop (13th Gen Intel Core)"), }, }, + { + .callback = tpm_tis_disable_irq, + .ident = "ThinkPad E14 Gen 2", + .matches = { +DMI_MATCH (DMI_SYS_VENDOR ,"LENOVO" ), + DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad E14 Gen 2"), + }, + }, + { + .callback = tpm_tis_disable_irq, + .ident = "ThinkBook 13s-IML", + .matches = { +DMI_MATCH (DMI_SYS_VENDOR ,"LENOVO" ), + DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo ThinkBook 13s-IML"), + }, + }, { .callback = tpm_tis_disable_irq, .ident = "ThinkPad T490s",
Signature · 1 line
2.35.3
Jarkko Sakkinen
maintainerQuoted 42 lines · Takashi Iwai
Like other Lenovo laptops, Thinkpad E14 Gen 2 and Thinkpad 13s-IML also require to disable the
tpm_tisinterrupts for avoiding a boot hang.Fixes e644b2f498d2 ("tpm, tpm_tis: Enable interrupt test")Cc <[email protected]> # v6.4+Signed-off-by Takashi Iwai <[email protected]>--- drivers/char/tpm/tpm_tis.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)drivers/char/tpm/tpm_tis.c +16
-0@@ -130,6 +130,22 @@ static const struct dmi_system_id tpm_tis_dmi_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "Laptop (13th Gen Intel Core)"), }, }, + { + .callback = tpm_tis_disable_irq, + .ident = "ThinkPad E14 Gen 2", + .matches = { +DMI_MATCH (DMI_SYS_VENDOR ,"LENOVO" ), + DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad E14 Gen 2"), + }, + }, + { + .callback = tpm_tis_disable_irq, + .ident = "ThinkBook 13s-IML", + .matches = { +DMI_MATCH (DMI_SYS_VENDOR ,"LENOVO" ), + DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo ThinkBook 13s-IML"), + }, + }, { .callback = tpm_tis_disable_irq, .ident = "ThinkPad T490s",Signature · 1 line
2.35.3
As almost all issues are with Lenovo, I would instead just put:
{
.callback = tpm_tis_disable_irq,
.matches = {
DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
},
},And delete the existing entries with vendor as "LENOVO".
BR, Jarkko
Quoted 47 lines · Jarkko Sakkinen
Quoted 42 lines · Takashi Iwai
Like other Lenovo laptops, Thinkpad E14 Gen 2 and Thinkpad 13s-IML also require to disable the
tpm_tisinterrupts for avoiding a boot hang.Fixes e644b2f498d2 ("tpm, tpm_tis: Enable interrupt test")Cc <[email protected]> # v6.4+Signed-off-by Takashi Iwai <[email protected]>--- drivers/char/tpm/tpm_tis.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)drivers/char/tpm/tpm_tis.c +16
-0@@ -130,6 +130,22 @@ static const struct dmi_system_id tpm_tis_dmi_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "Laptop (13th Gen Intel Core)"), }, }, + { + .callback = tpm_tis_disable_irq, + .ident = "ThinkPad E14 Gen 2", + .matches = { +DMI_MATCH (DMI_SYS_VENDOR ,"LENOVO" ), + DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad E14 Gen 2"), + }, + }, + { + .callback = tpm_tis_disable_irq, + .ident = "ThinkBook 13s-IML", + .matches = { +DMI_MATCH (DMI_SYS_VENDOR ,"LENOVO" ), + DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo ThinkBook 13s-IML"), + }, + }, { .callback = tpm_tis_disable_irq, .ident = "ThinkPad T490s",Signature · 1 line
2.35.3As almost all issues are with Lenovo, I would instead just put:
Quoted 8 lines
{ .callback = tpm_tis_disable_irq, .matches = { DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), }, },And delete the existing entries with vendor as "LENOVO".
Yeah, that will relieve pains better, too.
thanks,
Takashi
Jarkko Sakkinen
maintainerQuoted 56 lines · Takashi Iwai
Quoted 54 lines · Jarkko Sakkinen
Quoted 42 lines · Takashi Iwai
Like other Lenovo laptops, Thinkpad E14 Gen 2 and Thinkpad 13s-IML also require to disable the
tpm_tisinterrupts for avoiding a boot hang.Fixes e644b2f498d2 ("tpm, tpm_tis: Enable interrupt test")Cc <[email protected]> # v6.4+Signed-off-by Takashi Iwai <[email protected]>--- drivers/char/tpm/tpm_tis.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)drivers/char/tpm/tpm_tis.c +16
-0@@ -130,6 +130,22 @@ static const struct dmi_system_id tpm_tis_dmi_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "Laptop (13th Gen Intel Core)"), }, }, + { + .callback = tpm_tis_disable_irq, + .ident = "ThinkPad E14 Gen 2", + .matches = { +DMI_MATCH (DMI_SYS_VENDOR ,"LENOVO" ), + DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad E14 Gen 2"), + }, + }, + { + .callback = tpm_tis_disable_irq, + .ident = "ThinkBook 13s-IML", + .matches = { +DMI_MATCH (DMI_SYS_VENDOR ,"LENOVO" ), + DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo ThinkBook 13s-IML"), + }, + }, { .callback = tpm_tis_disable_irq, .ident = "ThinkPad T490s",Signature · 1 line
2.35.3As almost all issues are with Lenovo, I would instead just put:
{ .callback = tpm_tis_disable_irq, .matches = { DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), }, },
Quoted 3 lines
Quoted 1 line
And delete the existing entries with vendor as "LENOVO".
Yeah, that will relieve pains better, too.
Please do it if possible then :-)
BR, Jarkko
Quoted 58 lines · Jarkko Sakkinen
Quoted 56 lines · Takashi Iwai
Quoted 54 lines · Jarkko Sakkinen
Quoted 42 lines · Takashi Iwai
Like other Lenovo laptops, Thinkpad E14 Gen 2 and Thinkpad 13s-IML also require to disable the
tpm_tisinterrupts for avoiding a boot hang.Fixes e644b2f498d2 ("tpm, tpm_tis: Enable interrupt test")Cc <[email protected]> # v6.4+Signed-off-by Takashi Iwai <[email protected]>--- drivers/char/tpm/tpm_tis.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)drivers/char/tpm/tpm_tis.c +16
-0@@ -130,6 +130,22 @@ static const struct dmi_system_id tpm_tis_dmi_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "Laptop (13th Gen Intel Core)"), }, }, + { + .callback = tpm_tis_disable_irq, + .ident = "ThinkPad E14 Gen 2", + .matches = { +DMI_MATCH (DMI_SYS_VENDOR ,"LENOVO" ), + DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad E14 Gen 2"), + }, + }, + { + .callback = tpm_tis_disable_irq, + .ident = "ThinkBook 13s-IML", + .matches = { +DMI_MATCH (DMI_SYS_VENDOR ,"LENOVO" ), + DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo ThinkBook 13s-IML"), + }, + }, { .callback = tpm_tis_disable_irq, .ident = "ThinkPad T490s",Signature · 1 line
2.35.3As almost all issues are with Lenovo, I would instead just put:
{ .callback = tpm_tis_disable_irq, .matches = { DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), }, },
Quoted 5 lines
Quoted 3 lines
Quoted 1 line
And delete the existing entries with vendor as "LENOVO".
Yeah, that will relieve pains better, too.
Please do it if possible then :-)
Do you mean that I should resubmit a new patch? Honestly speaking, it'd be easier if you can do it directly. I'm merely a sort of messenger, I don't own / test the device by myself...
But if inevitably required, I can resubmit a patch, of course.
thanks,
Takashi
Jarkko Sakkinen
maintainerQuoted 64 lines · Takashi Iwai
Quoted 62 lines · Jarkko Sakkinen
Quoted 59 lines · Takashi Iwai
Quoted 47 lines · Jarkko Sakkinen
Quoted 42 lines · Takashi Iwai
Like other Lenovo laptops, Thinkpad E14 Gen 2 and Thinkpad 13s-IML also require to disable the
tpm_tisinterrupts for avoiding a boot hang.Fixes e644b2f498d2 ("tpm, tpm_tis: Enable interrupt test")Cc <[email protected]> # v6.4+Signed-off-by Takashi Iwai <[email protected]>--- drivers/char/tpm/tpm_tis.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)drivers/char/tpm/tpm_tis.c +16
-0@@ -130,6 +130,22 @@ static const struct dmi_system_id tpm_tis_dmi_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "Laptop (13th Gen Intel Core)"), }, }, + { + .callback = tpm_tis_disable_irq, + .ident = "ThinkPad E14 Gen 2", + .matches = { +DMI_MATCH (DMI_SYS_VENDOR ,"LENOVO" ), + DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad E14 Gen 2"), + }, + }, + { + .callback = tpm_tis_disable_irq, + .ident = "ThinkBook 13s-IML", + .matches = { +DMI_MATCH (DMI_SYS_VENDOR ,"LENOVO" ), + DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo ThinkBook 13s-IML"), + }, + }, { .callback = tpm_tis_disable_irq, .ident = "ThinkPad T490s",Signature · 1 line
2.35.3As almost all issues are with Lenovo, I would instead just put:
Quoted 8 lines
{ .callback = tpm_tis_disable_irq, .matches = { DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), }, },And delete the existing entries with vendor as "LENOVO".
Yeah, that will relieve pains better, too.
Quoted 8 lines
Quoted 1 line
Please do it if possible then :-)
Do you mean that I should resubmit a new patch? Honestly speaking, it'd be easier if you can do it directly. I'm merely a sort of messenger, I don't own / test the device by myself...
But if inevitably required, I can resubmit a patch, of course.
I'll submit a patch asap, and cc you. I put the conclusions to the description.
BR, Jarkko
Quoted 73 lines · Jarkko Sakkinen
Quoted 71 lines · Takashi Iwai
Quoted 58 lines · Jarkko Sakkinen
Quoted 56 lines · Takashi Iwai
Quoted 54 lines · Jarkko Sakkinen
Quoted 42 lines · Takashi Iwai
Like other Lenovo laptops, Thinkpad E14 Gen 2 and Thinkpad 13s-IML also require to disable the
tpm_tisinterrupts for avoiding a boot hang.Fixes e644b2f498d2 ("tpm, tpm_tis: Enable interrupt test")Cc <[email protected]> # v6.4+Signed-off-by Takashi Iwai <[email protected]>--- drivers/char/tpm/tpm_tis.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)drivers/char/tpm/tpm_tis.c +16
-0@@ -130,6 +130,22 @@ static const struct dmi_system_id tpm_tis_dmi_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "Laptop (13th Gen Intel Core)"), }, }, + { + .callback = tpm_tis_disable_irq, + .ident = "ThinkPad E14 Gen 2", + .matches = { +DMI_MATCH (DMI_SYS_VENDOR ,"LENOVO" ), + DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad E14 Gen 2"), + }, + }, + { + .callback = tpm_tis_disable_irq, + .ident = "ThinkBook 13s-IML", + .matches = { +DMI_MATCH (DMI_SYS_VENDOR ,"LENOVO" ), + DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo ThinkBook 13s-IML"), + }, + }, { .callback = tpm_tis_disable_irq, .ident = "ThinkPad T490s",Signature · 1 line
2.35.3As almost all issues are with Lenovo, I would instead just put:
{ .callback = tpm_tis_disable_irq, .matches = { DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), }, },Quoted 5 lines
Quoted 3 lines
Quoted 1 line
And delete the existing entries with vendor as "LENOVO".
Yeah, that will relieve pains better, too.
Please do it if possible then :-)
Do you mean that I should resubmit a new patch? Honestly speaking, it'd be easier if you can do it directly. I'm merely a sort of messenger, I don't own / test the device by myself...
Quoted 4 lines
Quoted 1 line
But if inevitably required, I can resubmit a patch, of course.
I'll submit a patch asap, and cc you. I put the conclusions to the description.
Great, thanks!
Takashi
Jarkko Sakkinen
maintainerQuoted 4 lines · Takashi Iwai
Quoted 2 lines
I'll submit a patch asap, and cc you. I put the conclusions to the description.
Great, thanks!
It is out now:
https://lore.kernel.org/linux-integrity/[email protected]/T/#u
BR, Jarkko
Jarkko Sakkinen
maintainerQuoted 9 lines · Jarkko Sakkinen
Quoted 4 lines · Takashi Iwai
Quoted 2 lines
I'll submit a patch asap, and cc you. I put the conclusions to the description.
Great, thanks!
It is out now:
https://lore.kernel.org/linux-integrity/[email protected]/T/#u
I put this also hanging to my -next branch (mirrored to linux-next).
BR, Jarkko