platform/x86: ISST: Reduce noise for missing numa information in logs
Subsystems (2)
Srinivas Pandruvada
maintainerPATCH 1/1 platform/x86: ISST: Reduce noise for missing numa information in logs
On platforms with no numa support and with several CPUs, logs have lots of noise for message "Fail to get numa node for CPU:.."
Change pr_info() to pr_info_once() as one print is enough to show the issue.
--- drivers/platform/x86/intel/speed_select_if/isst_if_common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/platform/x86/intel/speed_select_if/isst_if_common.c +2 -2
@@ -335,8 +335,8 @@ static struct pci_dev *_isst_if_get_pci_dev(int cpu, int bus_no, int dev, int fn node =dev_to_node (&_pci_dev->dev);if (node ==NUMA_NO_NODE ) { -pr_info ("Fail to get numa node for CPU:%d bus:%d dev:%d fn:%d\n" , - cpu, bus_no, dev, fn); +pr_info_once ("Fail to get numa node for CPU:%d bus:%d dev:%d fn:%d\n" , + cpu, bus_no, dev, fn);continue ; }
Signature · 1 line
2.41.0
Hi,
Quoted 7 lines · Srinivas Pandruvada
On platforms with no numa support and with several CPUs, logs have lots of noise for message "Fail to get numa node for CPU:.."
Change
pr_info()topr_info_once()as one print is enough to show the issue.Signed-off-by Srinivas Pandruvada <[email protected]>
Thank you for your patch, I've applied this patch to my fixes branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=fixes
Note it will show up in my fixes branch once I've pushed my local branch there, which might take a while.
I will include this patch in my next fixes pull-req to Linus for the current kernel development cycle.
Regards,
Hans
Quoted 19 lines
--- drivers/platform/x86/intel/speed_select_if/isst_if_common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/platform/x86/intel/speed_select_if/isst_if_common.c +2
-2@@ -335,8 +335,8 @@ static struct pci_dev *_isst_if_get_pci_dev(int cpu, int bus_no, int dev, int fn node =dev_to_node (&_pci_dev->dev);if (node ==NUMA_NO_NODE ) { -pr_info ("Fail to get numa node for CPU:%d bus:%d dev:%d fn:%d\n" , - cpu, bus_no, dev, fn); +pr_info_once ("Fail to get numa node for CPU:%d bus:%d dev:%d fn:%d\n" , + cpu, bus_no, dev, fn);continue ; }