Skip to contentSkip to conversation

board/raspberrypi/config_4_64bit.txt: remove testing dtoverlay entries (vc4-kms-v3d-pi4, imx219)

PATCH Applied Peter Seiderer 4 participants 6 messages Aug 8, 2023 – Nov 30, 2023 Broadcom BCM2711/BCM2835 Arm architecture

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 board/raspberrypi/config_4_64bit.txt: remove testing dtoverlay entries (vc4-kms-v3d-pi4, imx219)

Remove private/testing dtoverlay entries (vc4-kms-v3d-pi4, imx219 and commented out ov5647) wrongly introduced by commit 689b9ac439 ("package/rpi-firmware: rework boot/config file handling") [1].

[1] https://git.buildroot.net/buildroot/commit/?id=689b9ac439ab7b507c8982b6102bddf59d03efbf

---
 board/raspberrypi/config_4_64bit.txt | 4 ----
 1 file changed, 4 deletions(-)
board/raspberrypi/config_4_64bit.txt +0 -4
index 41c7e97e99..4a77fb3f1b 100644
@@ -28,9 +28,5 @@ dtoverlay=miniuart-bt
 # enable autoprobing of Bluetooth driver without need of hciattach/btattach
 dtoverlay=krnbt=on
 
-dtoverlay=vc4-kms-v3d-pi4
-dtoverlay=imx219
-#dtoverlay=ov5647
-
 # enable 64bits support
 arm_64bit=1
Signature · 6 lines
2.41.0

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

PATCH 1/1 board/raspberrypi/config*.txt: remove failing 'dtoverlay=krnbt=on'

Remove failing 'dtoverlay=krnbt=on' from config.txt introduced with commit 689b9ac439 ("package/rpi-firmware: rework boot/config file handling") [1] by changing an dtoverlay option wrongly to an extra line (instead of changing to an proper dtparam line), but as no one complained since 2021 just drop it (and upcoming raspberry pi kernel/device tree will enable it by default [2]).

Fixes (on the board):

	$ cat /proc/device-tree/chosen/user-warnings
	Failed to load overlay 'krnbt=on'

[1] https://git.buildroot.net/buildroot/commit/?id=689b9ac439ab7b507c8982b6102bddf59d03efbf
[2] https://github.com/raspberrypi/linux/commit/ec08e93837efa2e75e5cab4d80427fdf7ea23da1

---
 board/raspberrypi/config_0w.txt      | 3 ---
 board/raspberrypi/config_3.txt       | 3 ---
 board/raspberrypi/config_3_64bit.txt | 3 ---
 board/raspberrypi/config_4.txt       | 3 ---
 board/raspberrypi/config_4_64bit.txt | 3 ---
 board/raspberrypi/config_zero2w.txt  | 3 ---
 6 files changed, 18 deletions(-)
board/raspberrypi/config_0w.txt +0 -3
index 195bad449e..771b975046 100644
@@ -24,6 +24,3 @@ gpu_mem_1024=100
 
 # fixes rpi (3B, 3B+, 3A+, 4B and Zero W) ttyAMA0 serial console
 dtoverlay=miniuart-bt
-
-# enable autoprobing of Bluetooth driver without need of hciattach/btattach
-dtoverlay=krnbt=on
board/raspberrypi/config_3.txt +0 -3
index 195bad449e..771b975046 100644
@@ -24,6 +24,3 @@ gpu_mem_1024=100
 
 # fixes rpi (3B, 3B+, 3A+, 4B and Zero W) ttyAMA0 serial console
 dtoverlay=miniuart-bt
-
-# enable autoprobing of Bluetooth driver without need of hciattach/btattach
-dtoverlay=krnbt=on
board/raspberrypi/config_3_64bit.txt +0 -3
index 34412fa9e8..ac5a09c486 100644
@@ -25,8 +25,5 @@ gpu_mem_1024=100
 # fixes rpi (3B, 3B+, 3A+, 4B and Zero W) ttyAMA0 serial console
 dtoverlay=miniuart-bt
 
-# enable autoprobing of Bluetooth driver without need of hciattach/btattach
-dtoverlay=krnbt=on
-
 # enable 64bits support
 arm_64bit=1
board/raspberrypi/config_4.txt +0 -3
index ea02d3f071..01f60395b3 100644
@@ -24,6 +24,3 @@ gpu_mem_1024=100
 
 # fixes rpi (3B, 3B+, 3A+, 4B and Zero W) ttyAMA0 serial console
 dtoverlay=miniuart-bt
-
-# enable autoprobing of Bluetooth driver without need of hciattach/btattach
-dtoverlay=krnbt=on
board/raspberrypi/config_4_64bit.txt +0 -3
index 4a77fb3f1b..139f6a8788 100644
@@ -25,8 +25,5 @@ gpu_mem_1024=100
 # fixes rpi (3B, 3B+, 3A+, 4B and Zero W) ttyAMA0 serial console
 dtoverlay=miniuart-bt
 
-# enable autoprobing of Bluetooth driver without need of hciattach/btattach
-dtoverlay=krnbt=on
-
 # enable 64bits support
 arm_64bit=1
board/raspberrypi/config_zero2w.txt +0 -3
index 9e6b7f5ccf..151e446b5d 100644
@@ -24,6 +24,3 @@ gpu_mem_1024=100
 
 # fixes rpi (3B, 3B+, 3A+, 4B ,zero W and zero 2) ttyAMA0 serial console
 dtoverlay=miniuart-bt
-
-# enable autoprobing of Bluetooth driver without need of hciattach/btattach
-dtoverlay=krnbt=on
Signature · 6 lines
2.41.0

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#2 lore raw

Re: [Buildroot] [PATCH v1] board/raspberrypi/config*.txt: remove failing 'dtoverlay=krnbt=on'

Quoted 4 lines · On Tue, 8 Aug 2023 20:09:59 +0200 Peter Seiderer <[email protected]> wrote:

Remove failing 'dtoverlay=krnbt=on' from config.txt introduced with commit 689b9ac439 ("package/rpi-firmware: rework boot/config file handling") [1] by changing an dtoverlay option wrongly to an extra line (instead of changing to an proper dtparam line), but as no one complained since 2021 just

I'm failing to pase the "changing an dtoverlay option wrongly to an extra line (instead of changing to an proper dtparam line)". I'm confused by the "to an extra line".

Do you mean that:

dtoverlay=krnbt=on

should have been:

dtparam=krnbt=on

?

Thomas

Signature · 7 lines
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#3 lore raw

Re: [Buildroot] [PATCH v1] board/raspberrypi/config*.txt: remove failing 'dtoverlay=krnbt=on'

Hello Thomas,

Quoted 8 lines · Thomas Petazzoni
Quoted 4 lines · On Tue, 8 Aug 2023 20:09:59 +0200 Peter Seiderer <[email protected]> wrote:

Remove failing 'dtoverlay=krnbt=on' from config.txt introduced with commit 689b9ac439 ("package/rpi-firmware: rework boot/config file handling") [1] by changing an dtoverlay option wrongly to an extra line (instead of changing to an proper dtparam line), but as no one complained since 2021 just

Quoted 7 lines

I'm failing to pase the "changing an dtoverlay option wrongly to an extra line (instead of changing to an proper dtparam line)". I'm confused by the "to an extra line".

Do you mean that:

dtoverlay=krnbt=on

To be precise the original was (and as documented here [1])

dtoverlay=miniuart-bt,krnbt=on

Quoted 4 lines

should have been:

dtparam=krnbt=on

Yes (as documented here [2])...

Regards,
Peter

[1] https://github.com/raspberrypi/linux/blob/rpi-5.10.y/arch/arm/boot/dts/overlays/README#L2371
[2] https://github.com/raspberrypi/linux/blob/rpi-5.10.y/arch/arm/boot/dts/overlays/README#L213

Quoted 4 lines

?

Thomas

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#4 lore raw
In reply to Peter Seiderer

Peter, All,

On 2023-08-08 20:09 +0200, Peter Seiderer spake thusly:

Quoted 7 lines

Remove private/testing dtoverlay entries (vc4-kms-v3d-pi4, imx219 and commented out ov5647) wrongly introduced by commit 689b9ac439 ("package/rpi-firmware: rework boot/config file handling") [1].

[1] https://git.buildroot.net/buildroot/commit/?id=689b9ac439ab7b507c8982b6102bddf59d03efbf

Applied to master, thanks.

Regards,
Yann E. MORIN.

Quoted 25 lines
---
 board/raspberrypi/config_4_64bit.txt | 4 ----
 1 file changed, 4 deletions(-)
board/raspberrypi/config_4_64bit.txt +0 -4
index 41c7e97e99..4a77fb3f1b 100644
@@ -28,9 +28,5 @@ dtoverlay=miniuart-bt
 # enable autoprobing of Bluetooth driver without need of hciattach/btattach
 dtoverlay=krnbt=on
 
-dtoverlay=vc4-kms-v3d-pi4
-dtoverlay=imx219
-#dtoverlay=ov5647
-
 # enable 64bits support
 arm_64bit=1
Signature · 6 lines
2.41.0

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Signature · 10 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#5 lore raw
Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

Peter, All,
On 2023-08-08 20:09 +0200, Peter Seiderer spake thusly:

Quoted 4 lines

Remove private/testing dtoverlay entries (vc4-kms-v3d-pi4, imx219 and commented out ov5647) wrongly introduced by commit 689b9ac439 ("package/rpi-firmware: rework boot/config file handling") [1].

Quoted 5 lines
Quoted 3 lines

[1] https://git.buildroot.net/buildroot/commit/?id=689b9ac439ab7b507c8982b6102bddf59d03efbf

Applied to master, thanks.

Committed to 2023.02.x and 2023.08.x, thanks.

Signature · 5 lines
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot