Skip to contentSkip to conversation

TIOCSTI: Document CAP_SYS_ADMIN behaviour in Kconfig

PATCH In review Günther Noack 2 participants 2 messages Aug 8, 2023 TTY layer and serial drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 TIOCSTI: Document CAP_SYS_ADMIN behaviour in Kconfig

Clarifies that the LEGACY_TIOCSTI setting is safe to turn off even when running BRLTTY, as it was introduced in commit 690c8b804ad2 ("TIOCSTI: always enable for CAP_SYS_ADMIN").

---
 drivers/tty/Kconfig | 3 +++
 1 file changed, 3 insertions(+)
drivers/tty/Kconfig +3 -0
index 341abaed4ce..069de553127 100644
@@ -164,6 +164,9 @@ config LEGACY_TIOCSTI
 	  userspace depends on this functionality to continue operating
 	  normally.
 
+	  Processes which run with CAP_SYS_ADMIN, such as BRLTTY, can
+	  use TIOCSTI even when this is set to N.
+
 	  This functionality can be changed at runtime with the
 	  dev.tty.legacy_tiocsti sysctl. This configuration option sets
 	  the default value of the sysctl.
Signature · 1 line
2.41.0
Reviewed-by on v1 1/1
#1 lore raw

Günther Noack, le mar. 08 août 2023 22:11:12 +0200, a ecrit:

Quoted 5 lines

Clarifies that the LEGACY_TIOCSTI setting is safe to turn off even when running BRLTTY, as it was introduced in commit 690c8b804ad2 ("TIOCSTI: always enable for CAP_SYS_ADMIN").

Quoted 21 lines
---
 drivers/tty/Kconfig | 3 +++
 1 file changed, 3 insertions(+)
drivers/tty/Kconfig +3 -0
index 341abaed4ce..069de553127 100644
@@ -164,6 +164,9 @@ config LEGACY_TIOCSTI
 	  userspace depends on this functionality to continue operating
 	  normally.
 
+	  Processes which run with CAP_SYS_ADMIN, such as BRLTTY, can
+	  use TIOCSTI even when this is set to N.
+
 	  This functionality can be changed at runtime with the
 	  dev.tty.legacy_tiocsti sysctl. This configuration option sets
 	  the default value of the sysctl.
Signature · 1 line
2.41.0