staging: wlan-ng: cfg80211.c: removed unnecessary parenthesis to match coding style
PATCH 1/1 staging: wlan-ng: cfg80211.c: removed unnecessary parenthesis to match coding style
--- drivers/staging/wlan-ng/cfg80211.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/staging/wlan-ng/cfg80211.c +7 -7
@@ -247,7 +247,7 @@ static int prism2_get_station(struct wiphy *wiphy, struct net_device *dev,memset (sinfo,0 ,sizeof (*sinfo)); -if (!wlandev || (wlandev->msdstate !=WLAN_MSD_RUNNING )) +if (!wlandev || wlandev->msdstate !=WLAN_MSD_RUNNING )return -EOPNOTSUPP ;/* build request message */
@@ -351,8 +351,8 @@ static int prism2_scan(struct wiphy *wiphy, msg2->bssindex.data = i; result =p80211req_dorequest (wlandev, (u8 *)&msg2); -if ((result !=0 ) || - (msg2->resultcode.data != P80211ENUM_resultcode_success)) { +if (result !=0 || + msg2->resultcode.data != P80211ENUM_resultcode_success) {break ; }
@@ -459,11 +459,11 @@ static int prism2_connect(struct wiphy *wiphy, struct net_device *dev, }/* Set the authorization */ -if ((sme->auth_type ==NL80211_AUTHTYPE_OPEN_SYSTEM ) || - ((sme->auth_type ==NL80211_AUTHTYPE_AUTOMATIC ) && !is_wep)) +if (sme->auth_type ==NL80211_AUTHTYPE_OPEN_SYSTEM || + (sme->auth_type ==NL80211_AUTHTYPE_AUTOMATIC && !is_wep)) msg_join.authtype.data = P80211ENUM_authalg_opensystem; -else if ((sme->auth_type ==NL80211_AUTHTYPE_SHARED_KEY ) || - ((sme->auth_type ==NL80211_AUTHTYPE_AUTOMATIC ) && is_wep)) +else if (sme->auth_type ==NL80211_AUTHTYPE_SHARED_KEY || + (sme->auth_type ==NL80211_AUTHTYPE_AUTOMATIC && is_wep)) msg_join.authtype.data = P80211ENUM_authalg_sharedkey;else netdev_warn(dev,
Signature · 1 line
2.41.0
Greg Kroah-Hartman
maintainerQuoted 4 lines · Diogo Silva
Signed-off-by Diogo Silva <[email protected]>--- drivers/staging/wlan-ng/cfg80211.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree.
You are receiving this message because of the following common error(s) as indicated below:
- You did not specify a description of why the patch is needed, or possibly, any description at all, in the email body. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what is needed in order to properly describe the change.
- You sent a patch that has been sent multiple times in the past, and is identical to ones that have been rejected. Please always look at the mailing list traffic to determine if you are duplicating other people's work.
If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers.
thanks,
greg k-h's patch email bot
PATCH 1/1 staging: wlan-ng: cfg80211.c: removed unnecessary parenthesis to match coding style
Removed unnecessary parenthesis around some conditions to comply with the checkpatch coding style.
--- drivers/staging/wlan-ng/cfg80211.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/staging/wlan-ng/cfg80211.c +7 -7
@@ -247,7 +247,7 @@ static int prism2_get_station(struct wiphy *wiphy, struct net_device *dev,memset (sinfo,0 ,sizeof (*sinfo)); -if (!wlandev || (wlandev->msdstate !=WLAN_MSD_RUNNING )) +if (!wlandev || wlandev->msdstate !=WLAN_MSD_RUNNING )return -EOPNOTSUPP ;/* build request message */
@@ -351,8 +351,8 @@ static int prism2_scan(struct wiphy *wiphy, msg2->bssindex.data = i; result =p80211req_dorequest (wlandev, (u8 *)&msg2); -if ((result !=0 ) || - (msg2->resultcode.data != P80211ENUM_resultcode_success)) { +if (result !=0 || + msg2->resultcode.data != P80211ENUM_resultcode_success) {break ; }
@@ -459,11 +459,11 @@ static int prism2_connect(struct wiphy *wiphy, struct net_device *dev, }/* Set the authorization */ -if ((sme->auth_type ==NL80211_AUTHTYPE_OPEN_SYSTEM ) || - ((sme->auth_type ==NL80211_AUTHTYPE_AUTOMATIC ) && !is_wep)) +if (sme->auth_type ==NL80211_AUTHTYPE_OPEN_SYSTEM || + (sme->auth_type ==NL80211_AUTHTYPE_AUTOMATIC && !is_wep)) msg_join.authtype.data = P80211ENUM_authalg_opensystem; -else if ((sme->auth_type ==NL80211_AUTHTYPE_SHARED_KEY ) || - ((sme->auth_type ==NL80211_AUTHTYPE_AUTOMATIC ) && is_wep)) +else if (sme->auth_type ==NL80211_AUTHTYPE_SHARED_KEY || + (sme->auth_type ==NL80211_AUTHTYPE_AUTOMATIC && is_wep)) msg_join.authtype.data = P80211ENUM_authalg_sharedkey;else netdev_warn(dev,
Signature · 1 line
2.41.0
Please, don't resend this patch. Greg likes the parentheses for readability.
https://lore.kernel.org/all/?q=prism2_get_station
But also you re-sent it in the wrong format.
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
regards,
dan carpenter