Skip to contentSkip to conversation

configs: asus_tinker-s_rk3288: new config for the "S" variant of the Tinker Board

PATCH Applied Flávio Tapajós 3 participants 6 messages Jul 10, 2023 – Feb 6, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 configs: asus_tinker-s_rk3288: new config for the "S" variant of the Tinker Board

This commit duplicates the asus_tinker_rk3288_defconfig changing:

- BR2_LINUX_KERNEL_INTREE_DTS_NAME to rk3288-tinker-s
- BR2_TARGET_UBOOT_BOARD_DEFCONFIG to tinker-s-rk3288
- extlinux.conf devicetree to /boot/rk3288-tinker-s.dtb
- root device format to <major>:<minor> in order to prevent the kernel to mount rootfs from the wrong device
- Add Flávio Tapajós for configs/asus_tinker-s_rk3288_defconfig and for configs/asus_tinker-s_rk3288_defconfig and for board/asus/tinker-s

---
 DEVELOPERS                             |  4 +++
 board/asus/tinker-s/extlinux.conf      |  4 +++
 board/asus/tinker-s/post-build.sh      |  9 +++++
 board/asus/tinker-s/readme.txt         | 43 ++++++++++++++++++++++++
 configs/asus_tinker-s_rk3288_defconfig | 46 ++++++++++++++++++++++++++
 5 files changed, 106 insertions(+)
 create mode 100644 board/asus/tinker-s/extlinux.conf
 create mode 100755 board/asus/tinker-s/post-build.sh
 create mode 100644 board/asus/tinker-s/readme.txt
 create mode 100644 configs/asus_tinker-s_rk3288_defconfig
DEVELOPERS +4 -0
index 188c579010..e7273e64cd 100644
@@ -1022,6 +1022,10 @@ F:	configs/freescale_imx6ullevk_defconfig
 N:	Falco Hyfing <[email protected]>
 F:	package/python-pymodbus/
 
+N:	Flávio Tapajós <[email protected]>
+F:	configs/asus_tinker-s_rk3288_defconfig
+F:	board/asus/tinker-s
+
 N:	Florian Fainelli <[email protected]>
 F:	package/cpulimit/
 
board/asus/tinker-s/extlinux.conf new file +4 -0
new file mode 100644
index 0000000000..5a2d05b811
@@ -0,0 +1,4 @@
+label Tinker linux
+  kernel /boot/uImage
+  devicetree /boot/rk3288-tinker-s.dtb
+  append console=ttyS2,115200n8 root=179:1 rootwait
board/asus/tinker-s/post-build.sh new file +9 -0
new file mode 100755
index 0000000000..ffbbcdeb58
@@ -0,0 +1,9 @@
+#!/bin/sh
+
+MKIMAGE=$HOST_DIR/bin/mkimage
+BOARD_DIR="$(dirname $0)"
+
+$MKIMAGE -n rk3288 -T rksd -d $BINARIES_DIR/u-boot-tpl.bin $BINARIES_DIR/u-boot-tpl.img
+cat $BINARIES_DIR/u-boot-tpl.img $BINARIES_DIR/u-boot-spl-dtb.bin > $BINARIES_DIR/u-boot-tpl-spl-dtb.img
+
+install -m 0644 -D $BOARD_DIR/extlinux.conf $TARGET_DIR/boot/extlinux/extlinux.conf
board/asus/tinker-s/readme.txt new file +43 -0

43 lines not on this page · raw message

configs/asus_tinker-s_rk3288_defconfig new file +46 -0

46 lines not on this page · raw message

Signature · 6 lines
2.41.0

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

Hello Flávio,

Thanks for your contribution!

Quoted 11 lines · On Mon, 10 Jul 2023 13:29:15 -0300 Flávio Tapajós…

This commit duplicates the asus_tinker_rk3288_defconfig changing:

- BR2_LINUX_KERNEL_INTREE_DTS_NAME to rk3288-tinker-s
- BR2_TARGET_UBOOT_BOARD_DEFCONFIG to tinker-s-rk3288
- extlinux.conf devicetree to /boot/rk3288-tinker-s.dtb
- root device format to <major>:<minor> in order to prevent the kernel to mount rootfs from the wrong device
- Add Flávio Tapajós for configs/asus_tinker-s_rk3288_defconfig and for configs/asus_tinker-s_rk3288_defconfig and for board/asus/tinker-s

Quoted 11 lines
---
 DEVELOPERS                             |  4 +++
 board/asus/tinker-s/extlinux.conf      |  4 +++
 board/asus/tinker-s/post-build.sh      |  9 +++++
 board/asus/tinker-s/readme.txt         | 43 ++++++++++++++++++++++++
 configs/asus_tinker-s_rk3288_defconfig | 46 ++++++++++++++++++++++++++
 5 files changed, 106 insertions(+)
 create mode 100644 board/asus/tinker-s/extlinux.conf
 create mode 100755 board/asus/tinker-s/post-build.sh
 create mode 100644 board/asus/tinker-s/readme.txt
 create mode 100644 configs/asus_tinker-s_rk3288_defconfig

Applied to next, thanks.

I think it would be nice if you (for tinker-s) and Giulio (in Cc, for tinker) would change the defconfig to generate and use a kernel zImage instead of uImage. uImage is kind of deprecated, and it doesn't make much sense to use that anymore.

Thanks!

Thomas

Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#2 lore raw

PATCH 1/1 configs/asus_tinker_rk3288_defconfig: switch to zImage and bump Linux to 6.1.44, U-Boot to 2023.07

uImage is almost deprecated so let's switch to zImage. Let's also bump Linux version to 6.1.44, U-Boot to 2023.07 and remove BR2_TARGET_UBOOT_NEEDS_PYTHON3 since it's selected by BR2_TARGET_UBOOT_NEEDS_PYLIBFDT.

---
 configs/asus_tinker_rk3288_defconfig | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
configs/asus_tinker_rk3288_defconfig +2 -5
index 40f4125880..b3e4502a45 100644
@@ -10,10 +10,9 @@ BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_6_1=y
 BR2_TARGET_UBOOT=y
 BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
 BR2_TARGET_UBOOT_CUSTOM_VERSION=y
-BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2022.10"
+BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2023.07"
 BR2_TARGET_UBOOT_BOARD_DEFCONFIG="tinker-rk3288"
 BR2_TARGET_UBOOT_NEEDS_DTC=y
-BR2_TARGET_UBOOT_NEEDS_PYTHON3=y
 BR2_TARGET_UBOOT_NEEDS_PYLIBFDT=y
 BR2_TARGET_UBOOT_NEEDS_OPENSSL=y
 BR2_TARGET_UBOOT_FORMAT_DTB_IMG=y
@@ -23,10 +22,8 @@ BR2_TARGET_UBOOT_SPL_NAME="spl/u-boot-spl-dtb.bin tpl/u-boot-tpl.bin"
 # Kernel
 BR2_LINUX_KERNEL=y
 BR2_LINUX_KERNEL_CUSTOM_VERSION=y
-BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="6.1.2"
+BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="6.1.44"
 BR2_LINUX_KERNEL_DEFCONFIG="multi_v7"
-BR2_LINUX_KERNEL_UIMAGE=y
-BR2_LINUX_KERNEL_UIMAGE_LOADADDR="0x02000000"
 BR2_LINUX_KERNEL_DTS_SUPPORT=y
 BR2_LINUX_KERNEL_INTREE_DTS_NAME="rk3288-tinker"
 BR2_LINUX_KERNEL_INSTALL_TARGET=y
Signature · 6 lines
2.34.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#3 lore raw

Re: [Buildroot] [PATCH] configs/asus_tinker_rk3288_defconfig: switch to zImage and bump Linux to 6.1.44, U-Boot to 2023.07

Pardon,

extlinux.conf wasn't staged. Need to send V2

Signature · 2 lines
Giulio Benetti
CEO&CTO@Benetti Engineering sas
Quoted 28 lines · Giulio Benetti

uImage is almost deprecated so let's switch to zImage. Let's also bump Linux version to 6.1.44, U-Boot to 2023.07 and remove BR2_TARGET_UBOOT_NEEDS_PYTHON3 since it's selected by BR2_TARGET_UBOOT_NEEDS_PYLIBFDT.

---
  configs/asus_tinker_rk3288_defconfig | 7 ++-----
  1 file changed, 2 insertions(+), 5 deletions(-)
configs/asus_tinker_rk3288_defconfig +1 -2
index 40f4125880..b3e4502a45 100644
@@ -10,10 +10,9 @@ BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_6_1=y
  BR2_TARGET_UBOOT=y
  BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
  BR2_TARGET_UBOOT_CUSTOM_VERSION=y
-BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2022.10"
+BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2023.07"
  BR2_TARGET_UBOOT_BOARD_DEFCONFIG="tinker-rk3288"
  BR2_TARGET_UBOOT_NEEDS_DTC=y
-BR2_TARGET_UBOOT_NEEDS_PYTHON3=y
  BR2_TARGET_UBOOT_NEEDS_PYLIBFDT=y
  BR2_TARGET_UBOOT_NEEDS_OPENSSL=y
  BR2_TARGET_UBOOT_FORMAT_DTB_IMG=y
@@ -23,10 +22,8 @@ BR2_TARGET_UBOOT_SPL_NAME="spl/u-boot-spl-dtb.bin tpl/u-boot-tpl.bin"
  # Kernel

configs/asus_tinker_rk3288_defconfig BR2_TARGET_UBOOT_SPL_NAME="spl/u-boot-spl-dtb.bin tpl/u-boot-tpl.bin" · line 29

Quoted 10 lines
configs/asus_tinker_rk3288_defconfig +1 -3
  BR2_LINUX_KERNEL=y
  BR2_LINUX_KERNEL_CUSTOM_VERSION=y
-BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="6.1.2"
+BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="6.1.44"
  BR2_LINUX_KERNEL_DEFCONFIG="multi_v7"
-BR2_LINUX_KERNEL_UIMAGE=y
-BR2_LINUX_KERNEL_UIMAGE_LOADADDR="0x02000000"
  BR2_LINUX_KERNEL_DTS_SUPPORT=y
  BR2_LINUX_KERNEL_INTREE_DTS_NAME="rk3288-tinker"
  BR2_LINUX_KERNEL_INSTALL_TARGET=y

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#4 lore raw

PATCH v2 1/1 configs/asus_tinker_rk3288_defconfig: switch to zImage and bump Linux to 6.1.44, U-Boot to 2023.07

uImage is almost deprecated so let's switch to zImage. Let's also bump Linux version to 6.1.44, U-Boot to 2023.07 and remove BR2_TARGET_UBOOT_NEEDS_PYTHON3 since it's selected by BR2_TARGET_UBOOT_NEEDS_PYLIBFDT.

---
V1->V2:
* changed uImage to zImage in extlinux.conf

---
 board/asus/tinker/extlinux.conf      | 2 +-
 configs/asus_tinker_rk3288_defconfig | 7 ++-----
 2 files changed, 3 insertions(+), 6 deletions(-)
board/asus/tinker/extlinux.conf +1 -1
index bb96ddb893..be21e246ec 100644
@@ -1,4 +1,4 @@
 label Tinker linux
-  kernel /boot/uImage
+  kernel /boot/zImage
   devicetree /boot/rk3288-tinker.dtb
   append console=ttyS2,115200n8 root=/dev/mmcblk0p1 rootwait
configs/asus_tinker_rk3288_defconfig +2 -5
index 40f4125880..b3e4502a45 100644
@@ -10,10 +10,9 @@ BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_6_1=y
 BR2_TARGET_UBOOT=y
 BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
 BR2_TARGET_UBOOT_CUSTOM_VERSION=y
-BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2022.10"
+BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2023.07"
 BR2_TARGET_UBOOT_BOARD_DEFCONFIG="tinker-rk3288"
 BR2_TARGET_UBOOT_NEEDS_DTC=y
-BR2_TARGET_UBOOT_NEEDS_PYTHON3=y
 BR2_TARGET_UBOOT_NEEDS_PYLIBFDT=y
 BR2_TARGET_UBOOT_NEEDS_OPENSSL=y
 BR2_TARGET_UBOOT_FORMAT_DTB_IMG=y
@@ -23,10 +22,8 @@ BR2_TARGET_UBOOT_SPL_NAME="spl/u-boot-spl-dtb.bin tpl/u-boot-tpl.bin"
 # Kernel
 BR2_LINUX_KERNEL=y
 BR2_LINUX_KERNEL_CUSTOM_VERSION=y
-BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="6.1.2"
+BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="6.1.44"
 BR2_LINUX_KERNEL_DEFCONFIG="multi_v7"
-BR2_LINUX_KERNEL_UIMAGE=y
-BR2_LINUX_KERNEL_UIMAGE_LOADADDR="0x02000000"
 BR2_LINUX_KERNEL_DTS_SUPPORT=y
 BR2_LINUX_KERNEL_INTREE_DTS_NAME="rk3288-tinker"
 BR2_LINUX_KERNEL_INSTALL_TARGET=y
Signature · 6 lines
2.34.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#5 lore raw

Re: [Buildroot] [PATCH v2] configs/asus_tinker_rk3288_defconfig: switch to zImage and bump Linux to 6.1.44, U-Boot to 2023.07

Quoted 5 lines · On Fri, 11 Aug 2023 00:10:20 +0200 Giulio Benetti…

uImage is almost deprecated so let's switch to zImage. Let's also bump Linux version to 6.1.44, U-Boot to 2023.07 and remove BR2_TARGET_UBOOT_NEEDS_PYTHON3 since it's selected by BR2_TARGET_UBOOT_NEEDS_PYLIBFDT.

Quoted 8 lines

---
V1->V2:
* changed uImage to zImage in extlinux.conf

---
 board/asus/tinker/extlinux.conf      | 2 +-
 configs/asus_tinker_rk3288_defconfig | 7 ++-----
 2 files changed, 3 insertions(+), 6 deletions(-)

Applied to master, thanks.

Thomas

Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot