Skip to contentSkip to conversation

page_pool: Set page pool size.

PATCH In review Ratheesh Kannoth 2 participants 3 messages Aug 9, 2023 – Aug 14, 2023

Subsystems (3)
lore
Share & tools
lore

Ratheesh Kannoth

author maintainer
#0 lore raw

PATCH 1/1 page_pool: Set page pool size.

https://lore.kernel.org/netdev/

	[email protected]/T/
---
 drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c +2 -1
index 8336cea16aff..2986e238104e 100644
@@ -1434,7 +1434,8 @@ int otx2_pool_init(struct otx2_nic *pfvf, u16 pool_id,
 	}
 
 	pp_params.flags = PP_FLAG_PAGE_FRAG | PP_FLAG_DMA_MAP;
-	pp_params.pool_size = numptrs;
+#define OTX2_PAGE_POOL_SIZE 2048
+	pp_params.pool_size = OTX2_PAGE_POOL_SIZE;
 	pp_params.nid = NUMA_NO_NODE;
 	pp_params.dev = pfvf->dev;
 	pp_params.dma_dir = DMA_FROM_DEVICE;
Signature · 1 line
2.25.1
author maintainer
#1 lore raw
Quoted 3 lines

From: Ratheesh Kannoth <[email protected]>
Sent: Wednesday, August 9, 2023 7:49 AM
Subject: [PATCH net-next] page_pool: Set page pool size.

Please ignore/abandon the patch. Will push a new patch to "net" as it is a fix in the driver.

-Ratheesh

#2 lore raw
In reply to Ratheesh Kannoth
Quoted 3 lines · Ratheesh Kannoth

https://lore.kernel.org/netdev/

	[email protected]/T/

For the record I like this code change better than changing page_pool core code. I like and agree with Olek's (Alexander Lobakin) suggestion.

But the commit message need to be improved as it is too thin. (And link is getting split in two lines for some reason)

Quoted 20 lines
---
  drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c +2 -1
index 8336cea16aff..2986e238104e 100644
@@ -1434,7 +1434,8 @@ int otx2_pool_init(struct otx2_nic *pfvf, u16 pool_id,
  	}
 
  	pp_params.flags = PP_FLAG_PAGE_FRAG | PP_FLAG_DMA_MAP;
-	pp_params.pool_size = numptrs;
+#define OTX2_PAGE_POOL_SIZE 2048
+	pp_params.pool_size = OTX2_PAGE_POOL_SIZE;
  	pp_params.nid = NUMA_NO_NODE;
  	pp_params.dev = pfvf->dev;
  	pp_params.dma_dir = DMA_FROM_DEVICE;