Skip to contentSkip to conversation

dockerfiles: bump tricore cross compiler container to Debian 11

PATCH In review Paolo Bonzini 4 participants 6 messages Aug 9, 2023 – Aug 10, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dockerfiles: bump tricore cross compiler container to Debian 11

With the release of version 12 on June 10, 2023, Debian 10 is not supported anymore. Modify the cross compiler container to build on a newer version.

---
 tests/docker/dockerfiles/debian-tricore-cross.docker | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/docker/dockerfiles/debian-tricore-cross.docker +1 -1
index 269bfa8d423..5bd1963fb55 100644
@@ -9,7 +9,7 @@
 #
 # SPDX-License-Identifier: GPL-2.0-or-later
 #
-FROM docker.io/library/debian:buster-slim
+FROM docker.io/library/debian:11-slim
 
 MAINTAINER Philippe Mathieu-Daudé <[email protected]>
 
Signature · 1 line
2.41.0
Acked-by on v1 1/1
#1 lore raw
Quoted 15 lines · Paolo Bonzini

With the release of version 12 on June 10, 2023, Debian 10 is not supported anymore. Modify the cross compiler container to build on a newer version.

---
 tests/docker/dockerfiles/debian-tricore-cross.docker | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/docker/dockerfiles/debian-tricore-cross.docker +0 -0
index 269bfa8d423..5bd1963fb55 100644

tests/docker/dockerfiles/debian-tricore-cross.docker line 14

Quoted 7 lines
tests/docker/dockerfiles/debian-tricore-cross.docker +1 -1
@@ -9,7 +9,7 @@
 #
 # SPDX-License-Identifier: GPL-2.0-or-later
 #
-FROM docker.io/library/debian:buster-slim
+FROM docker.io/library/debian:11-slim
 
 MAINTAINER Philippe Mathieu-Daudé <[email protected]>
Signature · 2 lines
Alex Bennée
Virtualisation Tech Lead @ Linaro
#2 lore raw
In reply to Paolo Bonzini
Quoted 14 lines · Paolo Bonzini

With the release of version 12 on June 10, 2023, Debian 10 is not supported anymore. Modify the cross compiler container to build on a newer version.

---
 tests/docker/dockerfiles/debian-tricore-cross.docker | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/docker/dockerfiles/debian-tricore-cross.docker +0 -0
index 269bfa8d423..5bd1963fb55 100644

tests/docker/dockerfiles/debian-tricore-cross.docker line 12

Quoted 5 lines
tests/docker/dockerfiles/debian-tricore-cross.docker +1 -1
@@ -9,7 +9,7 @@
 #
 # SPDX-License-Identifier: GPL-2.0-or-later
 #
-FROM docker.io/library/debian:buster-slim
+FROM docker.io/library/debian:11-slim

I think it would be better to skip debian-11 and use 12 instead.

Cheers,
Bastian

#3 lore raw
Quoted 4 lines · Bastian Koppelmann
Quoted 4 lines
tests/docker/dockerfiles/debian-tricore-cross.docker +0 -0
index 269bfa8d423..5bd1963fb55 100644
Quoted 8 lines

tests/docker/dockerfiles/debian-tricore-cross.docker line 12

Quoted 6 lines
tests/docker/dockerfiles/debian-tricore-cross.docker +1 -1
@@ -9,7 +9,7 @@
 #
 # SPDX-License-Identifier: GPL-2.0-or-later
 #
-FROM docker.io/library/debian:buster-slim
+FROM docker.io/library/debian:11-slim

I think it would be better to skip debian-11 and use 12 instead.

I picked 11 in order to keep the container in sync with the lcitool-generated dockerfiles. Once we switch lcitool from 11 to 12, it is easier to see what the changes are and replicate them in debian-tricore-cross and friends.

lcitool support for Debian 12 has already landed, but usually we try to keep the containers on the oldest supported release of a distro, and that is currently Debian 11.

Paolo

#4 lore raw
Quoted 15 lines · Paolo Bonzini
Quoted 4 lines · Bastian Koppelmann
Quoted 4 lines
tests/docker/dockerfiles/debian-tricore-cross.docker +0 -0
index 269bfa8d423..5bd1963fb55 100644
Quoted 8 lines

tests/docker/dockerfiles/debian-tricore-cross.docker line 12

Quoted 6 lines
tests/docker/dockerfiles/debian-tricore-cross.docker +1 -1
@@ -9,7 +9,7 @@
 #
 # SPDX-License-Identifier: GPL-2.0-or-later
 #
-FROM docker.io/library/debian:buster-slim
+FROM docker.io/library/debian:11-slim

I think it would be better to skip debian-11 and use 12 instead.

Quoted 8 lines

I picked 11 in order to keep the container in sync with the lcitool-generated dockerfiles. Once we switch lcitool from 11 to 12, it is easier to see what the changes are and replicate them in debian-tricore-cross and friends.

lcitool support for Debian 12 has already landed, but usually we try to keep the containers on the oldest supported release of a distro, and that is currently Debian 11.

Thanks for the explanation.

Cheers,
Bastian