bus: ti-sysc: Fix build warning for 64-bit build
Tony Lindgren
maintainerPATCH v2 1/3 bus: ti-sysc: Fix build warning for 64-bit build
Fix "warning: cast from pointer to integer of different size" on 64-bit builds.
Note that this is a cosmetic fix at this point as the driver is not yet used for 64-bit systems.
--- drivers/bus/ti-sysc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/bus/ti-sysc.c +1 -1
@@ -3104,7 +3104,7 @@ static int sysc_init_static_data(struct sysc *ddata) match =soc_device_match (sysc_soc_match);if (match && match->data) - sysc_soc->soc = (int )match->data; + sysc_soc->soc = (enum sysc_soc )match->data;/* * Check and warn about possible old incomplete dtb. We now want to see
Signature · 1 line
2.41.0
Tony Lindgren
maintainerPATCH v2 2/3 bus: ti-sysc: Build driver for TI K3 SoCs
Allow building ti-sysc also for K3 SoCs. This allows configuring the wkup domain devices for SYSCONFIG register wake-up events in a generic way.
As this is an interconnect level driver, default to built-in on K3 SoCs to probe the devices connected to the wkup domain like gpio, uart and timers.
--- drivers/bus/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/bus/Kconfig +2 -1
@@ -210,7 +210,8 @@ config TI_PWMSS config TI_SYSC bool "TI sysc interconnect target module driver" - depends on ARCH_OMAP2PLUS + depends on ARCH_OMAP2PLUS || ARCH_K3 + default y help Generic driver for Texas Instruments interconnect target module found on many TI SoCs.
Signature · 1 line
2.41.0
Re: [PATCH v2 2/3] bus: ti-sysc: Build driver for TI K3 SoCs
Quoted 28 lines · Tony Lindgren
Allow building ti-sysc also for K3 SoCs. This allows configuring the wkup domain devices for SYSCONFIG register wake-up events in a generic way.
As this is an interconnect level driver, default to built-in on K3 SoCs to probe the devices connected to the wkup domain like gpio, uart and timers.
Reviewed-by Dhruva Gole <[email protected]>Signed-off-by Tony Lindgren <[email protected]>--- drivers/bus/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/bus/Kconfig +2
-1@@ -210,7 +210,8 @@ config TI_PWMSS config TI_SYSC bool "TI sysc interconnect target module driver" - depends on ARCH_OMAP2PLUS + depends on ARCH_OMAP2PLUS || ARCH_K3 + default y help Generic driver for Texas Instruments interconnect target module found on many TI SoCs.Signature · 1 line
2.41.0
Signature · 3 lines
Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
Tony Lindgren
maintainerPATCH v2 3/3 bus: ti-sysc: Configure uart quirks for k3 SoC
In reply to Tony LindgrenEnable the uart quirks similar to the earlier SoCs. Let's assume we are likely going to need a k3 specific quirk mask separate from the earlier SoCs, so let's not start changing the revision register mask at this point.
Note that SYSC_QUIRK_LEGACY_IDLE will be needed until we can remove the need for pm_runtime_irq_safe() from 8250_omap driver.
--- drivers/bus/ti-sysc.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/bus/ti-sysc.c +2 -0
@@ -1525,6 +1525,8 @@ static const struct sysc_revision_quirk sysc_revision_quirks[] = { SYSC_QUIRK_SWSUP_SIDLE | SYSC_QUIRK_LEGACY_IDLE),SYSC_QUIRK ("uart" ,0 ,0x50 ,0x54 ,0x58 ,0x47422e03 ,0xffffffff ,SYSC_QUIRK_SWSUP_SIDLE |SYSC_QUIRK_LEGACY_IDLE ), +SYSC_QUIRK ("uart" ,0 ,0x50 ,0x54 ,0x58 ,0x47424e03 ,0xffffffff , +SYSC_QUIRK_SWSUP_SIDLE |SYSC_QUIRK_LEGACY_IDLE ),/* Quirks that need to be set based on the module address */ SYSC_QUIRK("mcpdm", 0x40132000, 0, 0x10, -ENODEV, 0x50000800, 0xffffffff,
Signature · 1 line
2.41.0
Re: [PATCH v2 3/3] bus: ti-sysc: Configure uart quirks for k3 SoC
Quoted 26 lines · Tony Lindgren
Enable the uart quirks similar to the earlier SoCs. Let's assume we are likely going to need a k3 specific quirk mask separate from the earlier SoCs, so let's not start changing the revision register mask at this point.
Note that
SYSC_QUIRK_LEGACY_IDLEwill be needed until we can remove the need forpm_runtime_irq_safe()from 8250_omap driver.Signed-off-by Tony Lindgren <[email protected]>--- drivers/bus/ti-sysc.c | 2 ++ 1 file changed, 2 insertions(+)drivers/bus/ti-sysc.c +2
-0@@ -1525,6 +1525,8 @@ static const struct sysc_revision_quirk sysc_revision_quirks[] = { SYSC_QUIRK_SWSUP_SIDLE | SYSC_QUIRK_LEGACY_IDLE),SYSC_QUIRK ("uart" ,0 ,0x50 ,0x54 ,0x58 ,0x47422e03 ,0xffffffff ,SYSC_QUIRK_SWSUP_SIDLE |SYSC_QUIRK_LEGACY_IDLE ), +SYSC_QUIRK ("uart" ,0 ,0x50 ,0x54 ,0x58 ,0x47424e03 ,0xffffffff , +SYSC_QUIRK_SWSUP_SIDLE |SYSC_QUIRK_LEGACY_IDLE ),/* Quirks that need to be set based on the module address */ SYSC_QUIRK("mcpdm", 0x40132000, 0, 0x10, -ENODEV, 0x50000800, 0xffffffff,Signature · 1 line
2.41.0
Signature · 3 lines
Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
Quoted 16 lines · Tony Lindgren
Fix "warning: cast from pointer to integer of different size" on 64-bit builds.
Note that this is a cosmetic fix at this point as the driver is not yet used for 64-bit systems.
Fixes feaa8baee82a ("bus: ti-sysc: Implement SoC revision handling")Signed-off-by Tony Lindgren <[email protected]>--- drivers/bus/ti-sysc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/bus/ti-sysc.c static int sysc_init_static_data(struct sysc *ddata) · line 3107
Quoted 5 lines
drivers/bus/ti-sysc.c +1
-1@@ -3104,7 +3104,7 @@ static int sysc_init_static_data(struct sysc *ddata) match =soc_device_match (sysc_soc_match);if (match && match->data) - sysc_soc->soc = (int )match->data; + sysc_soc->soc = (enum sysc_soc )match->data;
Thanks for the suggestion Nishanth,
Maybe something unrelated to this patch, but the driver has some minor warning when built with W=1:
make W=1 ARCH=arm64 CROSS_COMPILE=aarch64-none-linux-gnu- drivers/bus/ti-sysc.o
drivers/bus/ti-sysc.c:156: warning: Function parameter or member 'sysconfig' not described in 'sysc'
Quoted 5 lines
drivers/bus/ti-sysc.c +0
-0/* * Check and warn about possible old incomplete dtb. We now want to see Signature · 1 line
2.41.0
Signature · 2 lines
Best regards, Dhruva Gole <[email protected]>
Tony Lindgren
maintainerQuoted 6 lines · Dhruva Gole
Maybe something unrelated to this patch, but the driver has some minor warning when built with W=1:
make W=1 ARCH=arm64 CROSS_COMPILE=aarch64-none-linux-gnu-
drivers/bus/ti-sysc.o
drivers/bus/ti-sysc.c:156: warning: Function parameter or member 'sysconfig' not described in 'sysc'
Thanks yes it's unrelated, looks like sysconfig is not documented. I'll send a patch for that separately.
Regards,
Tony
Quoted 26 lines · Tony Lindgren
Fix "warning: cast from pointer to integer of different size" on 64-bit builds.
Note that this is a cosmetic fix at this point as the driver is not yet used for 64-bit systems.
Fixes feaa8baee82a ("bus: ti-sysc: Implement SoC revision handling")Signed-off-by Tony Lindgren <[email protected]>--- drivers/bus/ti-sysc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/bus/ti-sysc.c +1
-1@@ -3104,7 +3104,7 @@ static int sysc_init_static_data(struct sysc *ddata) match =soc_device_match (sysc_soc_match);if (match && match->data) - sysc_soc->soc = (int )match->data; + sysc_soc->soc = (enum sysc_soc )match->data;/* * Check and warn about possible old incomplete dtb. We now want to see Signature · 1 line
2.41.0
Signature · 3 lines
Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D