Support Anbernic RG351V Panel
Subsystems (4)
v2 cover Support Anbernic RG351V Panel
From: Chris Morgan <[email protected]>
Add support for the Anbernic RG351V panel. This panel is mostly identical to the one used in the 353 series, except it has a different panel ID when queried (0x4000 for the 351V, 0x3052 for the 353 panel) and will not work without the inclusion of the MIPI_DSI_CLOCK_NON_CONTINUOUS flag.
Updates from V1:
- Revised text in devicetree documentation to remove references to specific hardware.
Chris Morgan (2):
dt-bindings: display: newvision,nv3051d: Add Anbernic 351V Support drm/panel: nv3051d: Add Support for Anbernic 351V
.../display/panel/newvision,nv3051d.yaml | 18 ++++++++++-------- .../gpu/drm/panel/panel-newvision-nv3051d.c | 18 ++++++++++++++++-- 2 files changed, 26 insertions(+), 10 deletions(-)
Signature · 1 line
2.34.1
PATCH v2 1/2 dt-bindings: display: newvision, nv3051d: Add Anbernic 351V Support
From: Chris Morgan <[email protected]>
Document the Anbernic RG351V panel, which appears to be identical to the panel used in their 353 series except for in inclusion of an additional DSI format flag.
--- .../display/panel/newvision,nv3051d.yaml | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-)
Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml +10 -8
@@ -7,9 +7,7 @@ $schema: http://devicetree.org/meta-schemas/core.yaml# title: NewVision NV3051D based LCD panel description: | - The NewVision NV3051D is a driver chip used to drive DSI panels. For now, - this driver only supports the 640x480 panels found in the Anbernic RG353 - based devices. + The NewVision NV3051D is a driver chip used to drive DSI panels. maintainers: - Chris Morgan <[email protected]>
@@ -19,11 +17,15 @@ allOf: properties: compatible: - items: - - enum: - - anbernic,rg353p-panel - - anbernic,rg353v-panel - - const: newvision,nv3051d + oneOf: + - items: + - enum: + - anbernic,rg353p-panel + - anbernic,rg353v-panel + - const: newvision,nv3051d + + - items: + - const: anbernic,rg351v-panel reg: true backlight: true
Signature · 1 line
2.34.1
Re: [PATCH V2 1/2] dt-bindings: display: newvision,nv3051d: Add Anbernic 351V Support
Quoted 5 lines · Chris Morgan
From: Chris Morgan <[email protected]>
Document the Anbernic RG351V panel, which appears to be identical to the panel used in their 353 series except for in inclusion of an additional DSI format flag.
Sure?
Thanks,
Conor.
Quoted 45 lines
Signed-off-by Chris Morgan <[email protected]>--- .../display/panel/newvision,nv3051d.yaml | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-)Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml +10
-8@@ -7,9 +7,7 @@ $schema: http://devicetree.org/meta-schemas/core.yaml# title: NewVision NV3051D based LCD panel description: | - The NewVision NV3051D is a driver chip used to drive DSI panels. For now, - this driver only supports the 640x480 panels found in the Anbernic RG353 - based devices. + The NewVision NV3051D is a driver chip used to drive DSI panels. maintainers: - Chris Morgan <[email protected]>@@ -19,11 +17,15 @@ allOf: properties: compatible: - items: - - enum: - - anbernic,rg353p-panel - - anbernic,rg353v-panel - - const: newvision,nv3051d + oneOf: + - items: + - enum: + - anbernic,rg353p-panel + - anbernic,rg353v-panel + - const: newvision,nv3051d + + - items: + - const: anbernic,rg351v-panel reg: true backlight: trueSignature · 1 line
2.34.1
Rob Herring
maintainerRe: [PATCH V2 1/2] dt-bindings: display: newvision,nv3051d: Add Anbernic 351V Support
In reply to Chris MorganQuoted 34 lines · Chris Morgan
From: Chris Morgan <[email protected]>
Document the Anbernic RG351V panel, which appears to be identical to the panel used in their 353 series except for in inclusion of an additional DSI format flag.
Signed-off-by Chris Morgan <[email protected]>--- .../display/panel/newvision,nv3051d.yaml | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-)Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml +1
-7@@ -7,9 +7,7 @@ $schema: http://devicetree.org/meta-schemas/core.yaml# title: NewVision NV3051D based LCD panel description: | - The NewVision NV3051D is a driver chip used to drive DSI panels. For now, - this driver only supports the 640x480 panels found in the Anbernic RG353 - based devices. + The NewVision NV3051D is a driver chip used to drive DSI panels. maintainers: - Chris Morgan <[email protected]>@@ -19,11 +17,15 @@ allOf: properties: compatible: - items: - - enum: - - anbernic,rg353p-panel - - anbernic,rg353v-panel
Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml allOf: · line 28
Quoted 10 lines
Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml +9
-1- - const: newvision,nv3051d + oneOf: + - items: + - enum: + - anbernic,rg353p-panel + - anbernic,rg353v-panel + - const: newvision,nv3051d + + - items: + - const: anbernic,rg351v-panel
I don't understand. Is this panel not based on newvision,nv3051d? If not, then it probably should be a different binding. Lot's of panel bindings have similar properties.
Rob
Re: [PATCH V2 1/2] dt-bindings: display: newvision,nv3051d: Add Anbernic 351V Support
Quoted 41 lines · Rob Herring
Quoted 40 lines · Chris Morgan
From: Chris Morgan <[email protected]>
Document the Anbernic RG351V panel, which appears to be identical to the panel used in their 353 series except for in inclusion of an additional DSI format flag.
Signed-off-by Chris Morgan <[email protected]>--- .../display/panel/newvision,nv3051d.yaml | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-)Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml +6
-8@@ -7,9 +7,7 @@ $schema: http://devicetree.org/meta-schemas/core.yaml# title: NewVision NV3051D based LCD panel description: | - The NewVision NV3051D is a driver chip used to drive DSI panels. For now, - this driver only supports the 640x480 panels found in the Anbernic RG353 - based devices. + The NewVision NV3051D is a driver chip used to drive DSI panels. maintainers: - Chris Morgan <[email protected]>@@ -19,11 +17,15 @@ allOf: properties: compatible: - items: - - enum: - - anbernic,rg353p-panel - - anbernic,rg353v-panel - - const: newvision,nv3051d + oneOf: + - items: + - enum: + - anbernic,rg353p-panel + - anbernic,rg353v-panel
Quoted 8 lines
Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml allOf: · line 28
Quoted 4 lines
Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml +4
-0+ - const: newvision,nv3051d + + - items: + - const: anbernic,rg351v-panelI don't understand. Is this panel not based on newvision,nv3051d? If not, then it probably should be a different binding. Lot's of panel bindings have similar properties.
It appears to be the same panel (or extremely similar, honestly I don't know because there are no external markings on it). However, this specific implementation seems to require MIPI_DSI_CLOCK_NON_CONTINUOUS, not using it prevents the panel from working. As for the existing panel MIPI_DSI_CLOCK_NON_CONTINUOUS stops it from working. The different binding essentially determines whether or not that flag is present, but otherwise everything else is identical.
Chris
Quoted 2 lines
Rob
Re: [PATCH V2 1/2] dt-bindings: display: newvision,nv3051d: Add Anbernic 351V Support
Quoted 59 lines · Chris Morgan
Quoted 41 lines · Rob Herring
Quoted 40 lines · Chris Morgan
From: Chris Morgan <[email protected]>
Document the Anbernic RG351V panel, which appears to be identical to the panel used in their 353 series except for in inclusion of an additional DSI format flag.
Signed-off-by Chris Morgan <[email protected]>--- .../display/panel/newvision,nv3051d.yaml | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-)Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml +6
-8@@ -7,9 +7,7 @@ $schema: http://devicetree.org/meta-schemas/core.yaml# title: NewVision NV3051D based LCD panel description: | - The NewVision NV3051D is a driver chip used to drive DSI panels. For now, - this driver only supports the 640x480 panels found in the Anbernic RG353 - based devices. + The NewVision NV3051D is a driver chip used to drive DSI panels. maintainers: - Chris Morgan <[email protected]>@@ -19,11 +17,15 @@ allOf: properties: compatible: - items: - - enum: - - anbernic,rg353p-panel - - anbernic,rg353v-panel - - const: newvision,nv3051d + oneOf: + - items: + - enum: + - anbernic,rg353p-panel + - anbernic,rg353v-panelQuoted 8 lines
Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml allOf: · line 28
Quoted 4 lines
Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml +4
-0+ - const: newvision,nv3051d + + - items: + - const: anbernic,rg351v-panelI don't understand. Is this panel not based on newvision,nv3051d? If not, then it probably should be a different binding. Lot's of panel bindings have similar properties.
It appears to be the same panel (or extremely similar, honestly I don't know because there are no external markings on it). However, this specific implementation seems to require
MIPI_DSI_CLOCK_NON_CONTINUOUS, not using it prevents the panel from working. As for the existing panelMIPI_DSI_CLOCK_NON_CONTINUOUSstops it from working. The different binding essentially determines whether or not that flag is present, but otherwise everything else is identical.
Quoted 1 line
Chris
I don't want to lose sight of this, but I am not sure how to proceed. What I can do instead is change the compatible string inside the driver from newvision,nv3051d to either anbernic,rg353p-panel or anbernic,rg351v-panel. Then, I can remove anbernic,rg353v-panel as an enum and replace it with anbernic,rg351v-panel. The gist of this is that we have a Newvision NV3051D panel that will still be supported by this driver in 2 different configurations, the 353P (which is identical to the 353V) and the 351V (which has different mode flags but is otherwise identical).
So long story short would it work if I did this, and modified the driver and all in-use devicetrees accordingly? To my knowledge this panel is only in use on boards that I submitted so I can update all those and test them.
- enum:
- anbernic,rg351v-panel
- anbernic,rg353p-panel
- const: newvision,nv3051d
Thank you,
Chris.
Quoted 3 lines
Quoted 3 lines
Rob
A message that is not in the archive (sent off-list or not yet received): ZNZIrOYaOar4DSkO@neuromancer.
Re: [PATCH V2 1/2] dt-bindings: display: newvision,nv3051d: Add Anbernic 351V Support
Quoted 59 lines · Chris Morgan
Quoted 41 lines · Rob Herring
Quoted 40 lines · Chris Morgan
From: Chris Morgan <[email protected]>
Document the Anbernic RG351V panel, which appears to be identical to the panel used in their 353 series except for in inclusion of an additional DSI format flag.
Signed-off-by Chris Morgan <[email protected]>--- .../display/panel/newvision,nv3051d.yaml | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-)Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml +6
-8@@ -7,9 +7,7 @@ $schema: http://devicetree.org/meta-schemas/core.yaml# title: NewVision NV3051D based LCD panel description: | - The NewVision NV3051D is a driver chip used to drive DSI panels. For now, - this driver only supports the 640x480 panels found in the Anbernic RG353 - based devices. + The NewVision NV3051D is a driver chip used to drive DSI panels. maintainers: - Chris Morgan <[email protected]>@@ -19,11 +17,15 @@ allOf: properties: compatible: - items: - - enum: - - anbernic,rg353p-panel - - anbernic,rg353v-panel - - const: newvision,nv3051d + oneOf: + - items: + - enum: + - anbernic,rg353p-panel + - anbernic,rg353v-panelQuoted 8 lines
Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml allOf: · line 28
Quoted 4 lines
Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml +4
-0+ - const: newvision,nv3051d + + - items: + - const: anbernic,rg351v-panelI don't understand. Is this panel not based on newvision,nv3051d? If not, then it probably should be a different binding. Lot's of panel bindings have similar properties.
It appears to be the same panel (or extremely similar, honestly I don't know because there are no external markings on it). However, this specific implementation seems to require
MIPI_DSI_CLOCK_NON_CONTINUOUS, not using it prevents the panel from working. As for the existing panelMIPI_DSI_CLOCK_NON_CONTINUOUSstops it from working. The different binding essentially determines whether or not that flag is present, but otherwise everything else is identical.
Quoted 1 line
Chris
If this is not correct I could also change it so instead there is a property that toggles the MIPI_DSI_CLOCK_NON_CONTINUOUS flag, something like "newvision,clk_non_continuous". Again aside from this flag the panel itself is identical to the one already supported by this driver.
Thank you,
Chris
Quoted 3 lines
Quoted 3 lines
Rob
PATCH v2 2/2 drm/panel: nv3051d: Add Support for Anbernic 351V
In reply to Chris MorganFrom: Chris Morgan <[email protected]>
Add support for the Anbernic 351V. Just like the 353 series the underlying vendor is unknown/unmarked (at least not visible in a non-destructive manner). The panel had slightly different init sequences and timings in the BSP kernel, but works fine with the same ones used in the existing driver. The panel will not work without the inclusion of the MIPI_DSI_CLOCK_NON_CONTINUOUS flag, and this flag prevents the 353 series from working correctly, so a new compatible string is added.
Tested colors and timings using modetest and all seem to work identical to the 353 otherwise.
--- .../gpu/drm/panel/panel-newvision-nv3051d.c | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-)
drivers/gpu/drm/panel/panel-newvision-nv3051d.c +16 -2
@@ -28,6 +28,7 @@ struct nv3051d_panel_info {unsigned int num_modes;u16 width_mm, height_mm;u32 bus_flags; +unsigned long mode_flags; };struct panel_nv3051d {
@@ -385,8 +386,7 @@ static int panel_nv3051d_probe(struct mipi_dsi_device *dsi) dsi->lanes =4 ; dsi->format =MIPI_DSI_FMT_RGB888 ; - dsi->mode_flags =MIPI_DSI_MODE_VIDEO |MIPI_DSI_MODE_VIDEO_BURST | -MIPI_DSI_MODE_LPM |MIPI_DSI_MODE_NO_EOT_PACKET ; + dsi->mode_flags = ctx->panel_info->mode_flags;drm_panel_init (&ctx->panel, &dsi->dev, &panel_nv3051d_funcs,DRM_MODE_CONNECTOR_DSI );
@@ -480,10 +480,24 @@ static const struct nv3051d_panel_info nv3051d_rgxx3_info = { .width_mm = 70, .height_mm = 57, .bus_flags = DRM_BUS_FLAG_DE_LOW | DRM_BUS_FLAG_PIXDATA_DRIVE_NEGEDGE, + .mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST | + MIPI_DSI_MODE_LPM | MIPI_DSI_MODE_NO_EOT_PACKET, +}; + +static const struct nv3051d_panel_info nv3051d_rg351v_info = { + .display_modes = nv3051d_rgxx3_modes, + .num_modes =ARRAY_SIZE (nv3051d_rgxx3_modes), + .width_mm =70 , + .height_mm =57 , + .bus_flags =DRM_BUS_FLAG_DE_LOW |DRM_BUS_FLAG_PIXDATA_DRIVE_NEGEDGE , + .mode_flags =MIPI_DSI_MODE_VIDEO |MIPI_DSI_MODE_VIDEO_BURST | +MIPI_DSI_MODE_LPM |MIPI_DSI_MODE_NO_EOT_PACKET | +MIPI_DSI_CLOCK_NON_CONTINUOUS , };static const struct of_device_id newvision_nv3051d_of_match[] = { { .compatible ="newvision,nv3051d" , .data = &nv3051d_rgxx3_info }, + { .compatible ="anbernic,rg351v-panel" , .data = &nv3051d_rg351v_info }, {/* sentinel */ } };MODULE_DEVICE_TABLE (of, newvision_nv3051d_of_match);
Signature · 1 line
2.34.1