thermal: broadcom: brcstb_thermal: removed unneeded platform_set_drvdata()
PATCH 1/1 thermal: broadcom: brcstb_thermal: removed unneeded platform_set_drvdata()
This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.
--- drivers/thermal/broadcom/brcmstb_thermal.c | 1 - 1 file changed, 1 deletion(-)
drivers/thermal/broadcom/brcmstb_thermal.c +0 -1
@@ -334,7 +334,6 @@ static int brcmstb_thermal_probe(struct platform_device *pdev)return PTR_ERR (priv->tmon_base); priv->dev = &pdev->dev; -platform_set_drvdata (pdev, priv); of_ops = priv->temp_params->of_ops; thermal = devm_thermal_of_zone_register(&pdev->dev, 0, priv,
Signature · 1 line
2.34.1
Quoted 6 lines · Andrei Coardos
This function call was found to be unnecessary as there is no equivalent
platform_get_drvdata()call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.
Quoted 20 lines
Signed-off-by Andrei Coardos <[email protected]>--- drivers/thermal/broadcom/brcmstb_thermal.c | 1 - 1 file changed, 1 deletion(-)drivers/thermal/broadcom/brcmstb_thermal.c +0
-2@@ -334,7 +334,6 @@ static int brcmstb_thermal_probe(struct platform_device *pdev)return PTR_ERR (priv->tmon_base); priv->dev = &pdev->dev; -platform_set_drvdata (pdev, priv); of_ops = priv->temp_params->of_ops; thermal = devm_thermal_of_zone_register(&pdev->dev, 0, priv, --2.34.1
Quoted 6 lines · Andrei Coardos
This function call was found to be unnecessary as there is no equivalent
platform_get_drvdata()call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.Signed-off-by Andrei Coardos <[email protected]>
Signature · 1 line
Florian
Daniel Lezcano
AppliedQuoted 7 lines · Andrei Coardos
This function call was found to be unnecessary as there is no equivalent
platform_get_drvdata()call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.Signed-off-by Andrei Coardos <[email protected]>---
Applied, thanks
Signature · 11 lines
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel