scsi: ufs: convert probe to use dev_err_probe()
Subsystems (2)
v2 cover scsi: ufs: convert probe to use dev_err_probe()
The following two log messages are shown on bootup due to an -EPROBE_DEFER when booting on a Qualcomm sa8775p development board:
ufshcd-qcom 1d84000.ufs: ufshcd_variant_hba_init: variant qcom init
failed err -517
ufshcd-qcom 1d84000.ufs: Initialization failed
This patch series converts the relevant two probe functions over to use dev_err_probe() so that these messages are not shown on bootup.
Changes since v1
https://lore.kernel.org/lkml/[email protected]/
- Dropped code cleanup
Brian Masney (2):
scsi: ufs: core: convert to dev_err_probe() in hba_init
scsi: ufs: host: convert to dev_err_probe() in pltfrm_init
drivers/ufs/core/ufshcd.c | 5 +++-- drivers/ufs/host/ufshcd-pltfrm.c | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-)
Signature · 1 line
2.41.0
PATCH v2 1/2 scsi: ufs: core: convert to dev_err_probe() in hba_init
Convert ufshcd_variant_hba_init() over to use dev_err_probe() to avoid log messages like the following on bootup:
ufshcd-qcom 1d84000.ufs: ufshcd_variant_hba_init: variant qcom init
failed err -517
---
Changes since v1
- Dropped code cleanup
drivers/ufs/core/ufshcd.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/ufs/core/ufshcd.c +3 -2
@@ -9235,8 +9235,9 @@ static int ufshcd_variant_hba_init(struct ufs_hba *hba) err =ufshcd_vops_init (hba);if (err) -dev_err (hba->dev,"%s: variant %s init failed err %d\n" , - __func__,ufshcd_get_var_name (hba), err); +dev_err_probe (hba->dev, err, +"%s: variant %s init failed err %d\n" , + __func__,ufshcd_get_var_name (hba), err); out:return err; }
Signature · 1 line
2.41.0
PATCH v2 2/2 scsi: ufs: host: convert to dev_err_probe() in pltfrm_init
In reply to Brian MasneyConvert ufshcd_pltfrm_init() over to use dev_err_probe() to avoid the following log message on bootup due to an -EPROBE_DEFER return code:
ufshcd-qcom 1d84000.ufs: Initialization failed
---
No changes since v1
drivers/ufs/host/ufshcd-pltfrm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/ufs/host/ufshcd-pltfrm.c +1 -1
@@ -373,7 +373,7 @@ int ufshcd_pltfrm_init(struct platform_device *pdev, err =ufshcd_init (hba, mmio_base, irq);if (err) { -dev_err (dev,"Initialization failed\n" ); +dev_err_probe (dev, err,"Initialization failed\n" ); goto dealloc_host; }
Signature · 1 line
2.41.0
Re: [PATCH v2 2/2] scsi: ufs: host: convert to dev_err_probe() in pltfrm_init
Quoted 18 lines · Brian Masney
Convert
ufshcd_pltfrm_init()over to usedev_err_probe()to avoid the following log message on bootup due to an -EPROBE_DEFER return code:ufshcd-qcom 1d84000.ufs: Initialization failed
Signed-off-by Brian Masney <[email protected]>---
No changes since v1drivers/ufs/host/ufshcd-pltfrm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/ufs/host/ufshcd-pltfrm.c +0
-0
drivers/ufs/host/ufshcd-pltfrm.c int ufshcd_pltfrm_init(struct platform_device *pdev, · line 376
Quoted 5 lines
drivers/ufs/host/ufshcd-pltfrm.c +1
-1@@ -373,7 +373,7 @@ int ufshcd_pltfrm_init(struct platform_device *pdev, err =ufshcd_init (hba, mmio_base, irq);if (err) { -dev_err (dev,"Initialization failed\n" ); +dev_err_probe (dev, err,"Initialization failed\n" );
Hi Brian,
Can you pls add the error code to the print?
Quoted 3 lines
drivers/ufs/host/ufshcd-pltfrm.c +0
-0goto dealloc_host; }