Skip to contentSkip to conversation

drm/amdkfd: Add missing tba_hi programming on aldebaran

PATCH In review Jay Cornwall 3 participants 3 messages Aug 9, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amdkfd: Add missing tba_hi programming on aldebaran

Previously asymptomatic because high 32 bits were zero.

Fixes 615222cfed20 ("drm/amdkfd: Relocate TBA/TMA to opposite side of VM hole")
---
 drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_v9.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_v9.c +1 -0
index 8fda16e6fee6..8ce6f5200905 100644
@@ -121,6 +121,7 @@ static int pm_map_process_aldebaran(struct packet_manager *pm,
 	packet->sh_mem_bases = qpd->sh_mem_bases;
 	if (qpd->tba_addr) {
 		packet->sq_shader_tba_lo = lower_32_bits(qpd->tba_addr >> 8);
+		packet->sq_shader_tba_hi = upper_32_bits(qpd->tba_addr >> 8);
 		packet->sq_shader_tma_lo = lower_32_bits(qpd->tma_addr >> 8);
 		packet->sq_shader_tma_hi = upper_32_bits(qpd->tma_addr >> 8);
 	}
Signature · 1 line
2.25.1
maintainer Reviewed-by on v1 1/1
#1 lore raw

[AMD Official Use Only - General]

________________________________
From: amd-gfx <[email protected]> on behalf of Jay Cornwall <[email protected]>
Sent: Wednesday, August 9, 2023 5:26 PM
To: [email protected] <[email protected]>
Cc: Cornwall, Jay <[email protected]>; Kasiviswanathan, Harish <[email protected]>
Subject: [PATCH] drm/amdkfd: Add missing tba_hi programming on aldebaran

Previously asymptomatic because high 32 bits were zero.

Fixes 615222cfed20 ("drm/amdkfd: Relocate TBA/TMA to opposite side of VM hole")
---
 drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_v9.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_v9.c +1 -0
index 8fda16e6fee6..8ce6f5200905 100644
@@ -121,6 +121,7 @@ static int pm_map_process_aldebaran(struct packet_manager *pm,
         packet->sh_mem_bases = qpd->sh_mem_bases;
         if (qpd->tba_addr) {
                 packet->sq_shader_tba_lo = lower_32_bits(qpd->tba_addr >> 8);
+               packet->sq_shader_tba_hi = upper_32_bits(qpd->tba_addr >> 8);
                 packet->sq_shader_tma_lo = lower_32_bits(qpd->tma_addr >> 8);
                 packet->sq_shader_tma_hi = upper_32_bits(qpd->tma_addr >> 8);
         }

--
2.25.1

maintainer Reviewed-by on v1 1/1
#2 lore raw
In reply to Jay Cornwall
Quoted 4 lines · Jay Cornwall

Previously asymptomatic because high 32 bits were zero.

Fixes 615222cfed20 ("drm/amdkfd: Relocate TBA/TMA to opposite side of VM hole")
Quoted 16 lines
---
  drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_v9.c | 1 +
  1 file changed, 1 insertion(+)
drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_v9.c +1 -0
index 8fda16e6fee6..8ce6f5200905 100644
@@ -121,6 +121,7 @@ static int pm_map_process_aldebaran(struct packet_manager *pm,
  	packet->sh_mem_bases = qpd->sh_mem_bases;
  	if (qpd->tba_addr) {
  		packet->sq_shader_tba_lo = lower_32_bits(qpd->tba_addr >> 8);
+		packet->sq_shader_tba_hi = upper_32_bits(qpd->tba_addr >> 8);
  		packet->sq_shader_tma_lo = lower_32_bits(qpd->tma_addr >> 8);
  		packet->sq_shader_tma_hi = upper_32_bits(qpd->tma_addr >> 8);
  	}