drm/amdkfd: Add missing tba_hi programming on aldebaran
Subsystems (3)
PATCH 1/1 drm/amdkfd: Add missing tba_hi programming on aldebaran
Previously asymptomatic because high 32 bits were zero.
Fixes 615222cfed20 ("drm/amdkfd: Relocate TBA/TMA to opposite side of VM hole")
Signed-off-by Jay Cornwall <[email protected]>
--- drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_v9.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_v9.c +1 -0
@@ -121,6 +121,7 @@ static int pm_map_process_aldebaran(struct packet_manager *pm, packet->sh_mem_bases = qpd->sh_mem_bases;if (qpd->tba_addr) { packet->sq_shader_tba_lo =lower_32_bits (qpd->tba_addr >>8 ); + packet->sq_shader_tba_hi =upper_32_bits (qpd->tba_addr >>8 ); packet->sq_shader_tma_lo =lower_32_bits (qpd->tma_addr >>8 ); packet->sq_shader_tma_hi =upper_32_bits (qpd->tma_addr >>8 ); }
Signature · 1 line
2.25.1
[AMD Official Use Only - General]
Reviewed-by Alex Deucher <[email protected]>
________________________________
From: amd-gfx <[email protected]> on behalf of Jay Cornwall <[email protected]>
Sent: Wednesday, August 9, 2023 5:26 PM
To: [email protected] <[email protected]>
Cc: Cornwall, Jay <[email protected]>; Kasiviswanathan, Harish <[email protected]>
Subject: [PATCH] drm/amdkfd: Add missing tba_hi programming on aldebaran
Previously asymptomatic because high 32 bits were zero.
Fixes 615222cfed20 ("drm/amdkfd: Relocate TBA/TMA to opposite side of VM hole")
Signed-off-by Jay Cornwall <[email protected]>
--- drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_v9.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_v9.c +1 -0
@@ -121,6 +121,7 @@ static int pm_map_process_aldebaran(struct packet_manager *pm, packet->sh_mem_bases = qpd->sh_mem_bases;if (qpd->tba_addr) { packet->sq_shader_tba_lo =lower_32_bits (qpd->tba_addr >>8 ); + packet->sq_shader_tba_hi =upper_32_bits (qpd->tba_addr >>8 ); packet->sq_shader_tma_lo =lower_32_bits (qpd->tma_addr >>8 ); packet->sq_shader_tma_hi =upper_32_bits (qpd->tma_addr >>8 ); }
--
2.25.1
Quoted 4 lines · Jay Cornwall
Previously asymptomatic because high 32 bits were zero.
Fixes 615222cfed20 ("drm/amdkfd: Relocate TBA/TMA to opposite side of VM hole")Signed-off-by Jay Cornwall <[email protected]>
Reviewed-by Felix Kuehling <[email protected]>
Quoted 16 lines
--- drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_v9.c | 1 + 1 file changed, 1 insertion(+)drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_v9.c +1
-0@@ -121,6 +121,7 @@ static int pm_map_process_aldebaran(struct packet_manager *pm, packet->sh_mem_bases = qpd->sh_mem_bases;if (qpd->tba_addr) { packet->sq_shader_tba_lo =lower_32_bits (qpd->tba_addr >>8 ); + packet->sq_shader_tba_hi =upper_32_bits (qpd->tba_addr >>8 ); packet->sq_shader_tma_lo =lower_32_bits (qpd->tma_addr >>8 ); packet->sq_shader_tma_hi =upper_32_bits (qpd->tma_addr >>8 ); }