build: deprecate enable_kmods option
PATCH 1/1 build: deprecate enable_kmods option
With the removal of the kni kernel driver, there are no longer any Linux kernel modules in our repository, leaving only modules for FreeBSD present. Since:
* BSD has no issues with out-of-tree modules and
* There are no in-tree equivalents for those modules in BSD
there is no point in building for BSD without those modules.
Therefore, we can remove the enable_kmods option, always building the kmods for BSD.
We can also remove the infrastructure for Linux kmods too, since use of out-of-tree modules for Linux is not something the DPDK project wants to pursue in future.
--- doc/guides/rel_notes/deprecation.rst | 7 ++ kernel/linux/meson.build | 103 --------------------------- kernel/meson.build | 4 +- meson.build | 6 +- meson_options.txt | 4 +- 5 files changed, 14 insertions(+), 110 deletions(-) delete mode 100644 kernel/linux/meson.build
doc/guides/rel_notes/deprecation.rst +7 -0
@@ -21,6 +21,13 @@ Deprecation Notices won't be possible anymore through the use of the ``disable_libs`` build option. A new build option for deprecated libraries will be introduced instead. +* build: The ``enable_kmods`` option is deprecated and will be removed in a future release. + Setting/clearing the option has no impact on the build. + Instead, kernel modules will be always built for OS's where out-of-tree kernel modules + are required for DPDK operation. + Currently, this means that modules will only be build for FreeBSD. + No modules are shipped with DPDK for either Linux or Windows. + * kvargs: The function ``rte_kvargs_process`` will get a new parameter for returning key match count. It will ease handling of no-match case.
kernel/linux/meson.build deleted +0 -103
103 lines not on this page · raw message
kernel/meson.build +3 -1
@@ -1,4 +1,6 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2017 Intel Corporation -subdir(exec_env) +if is_freebsd + subdir(exec_env) +endif
meson.build +2 -4
@@ -94,10 +94,8 @@ install_subdir('examples', install_dir: get_option('datadir') + '/dpdk', exclude_files: ex_file_excludes) -# build kernel modules if enabled -if get_option('enable_kmods') - subdir('kernel') -endif +# build kernel modules +subdir('kernel') # check header includes if requested if get_option('check_includes')
meson_options.txt +2 -2
@@ -22,8 +22,8 @@ option('enable_drivers', type: 'string', value: '', description: 'Comma-separated list of drivers to build. If unspecified, build all drivers.') option('enable_driver_sdk', type: 'boolean', value: false, description: 'Install headers to build drivers.') -option('enable_kmods', type: 'boolean', value: false, description: - 'build kernel modules') +option('enable_kmods', type: 'boolean', value: true, description: + '[Deprecated - will be removed in future release] build kernel modules') option('examples', type: 'string', value: '', description: 'Comma-separated list of examples to build by default') option('ibverbs_link', type: 'combo', choices : ['static', 'shared', 'dlopen'], value: 'shared', description:
Signature · 1 line
2.39.2
Quoted 9 lines · On Thu, 10 Aug 2023 14:18:09 +0100 Bruce Richardson…
With the removal of the kni kernel driver, there are no longer any Linux kernel modules in our repository, leaving only modules for FreeBSD present. Since:
* BSD has no issues with out-of-tree modules and
* There are no in-tree equivalents for those modules in BSDthere is no point in building for BSD without those modules.
Quoted 8 lines
Therefore, we can remove the
enable_kmodsoption, always building the kmods for BSD.We can also remove the infrastructure for Linux kmods too, since use of out-of-tree modules for Linux is not something the DPDK project wants to pursue in future.
Signed-off-by Bruce Richardson <[email protected]>
Quoted 15 lines
From: Bruce Richardson [mailto:[email protected]]
Sent: Thursday, 10 August 2023 15.18With the removal of the kni kernel driver, there are no longer any Linux kernel modules in our repository, leaving only modules for FreeBSD present. Since:
* BSD has no issues with out-of-tree modules and
* There are no in-tree equivalents for those modules in BSDthere is no point in building for BSD without those modules.
Therefore, we can remove the
enable_kmodsoption, always building the kmods for BSD.
Quoted 6 lines
We can also remove the infrastructure for Linux kmods too, since use of out-of-tree modules for Linux is not something the DPDK project wants to pursue in future.
Signed-off-by Bruce Richardson <[email protected]>---
jeudi 10 août 2023, Bruce Richardson:
Quoted 9 lines
With the removal of the kni kernel driver, there are no longer any Linux kernel modules in our repository, leaving only modules for FreeBSD present. Since:
* BSD has no issues with out-of-tree modules and
* There are no in-tree equivalents for those modules in BSDthere is no point in building for BSD without those modules.
Quoted 8 lines
Therefore, we can remove the
enable_kmodsoption, always building the kmods for BSD.We can also remove the infrastructure for Linux kmods too, since use of out-of-tree modules for Linux is not something the DPDK project wants to pursue in future.
Signed-off-by Bruce Richardson <[email protected]>
Quoted 13 lines · Bruce Richardson
With the removal of the kni kernel driver, there are no longer any Linux kernel modules in our repository, leaving only modules for FreeBSD present. Since:
* BSD has no issues with out-of-tree modules and
* There are no in-tree equivalents for those modules in BSDthere is no point in building for BSD without those modules.
Therefore, we can remove the
enable_kmodsoption, always building the kmods for BSD.
Quoted 8 lines
We can also remove the infrastructure for Linux kmods too, since use of out-of-tree modules for Linux is not something the DPDK project wants to pursue in future.
Signed-off-by Bruce Richardson <[email protected]>Acked-by Morten Brørup <[email protected]>Acked-by Thomas Monjalon <[email protected]>
Applied, thanks Bruce.
Signature · 1 line
David Marchand