Skip to contentSkip to conversation

thermal: k3_bandgap: remove unneeded call to platform_set_drvdata()

PATCH Applied Andrei Coardos 3 participants 3 messages Aug 10, 2023 – Aug 16, 2023 Thermal

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 thermal: k3_bandgap: remove unneeded call to platform_set_drvdata()

This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.

---
 drivers/thermal/k3_bandgap.c | 1 -
 1 file changed, 1 deletion(-)
drivers/thermal/k3_bandgap.c +0 -1
index 1c3e590157ec..f985f36f2123 100644
@@ -225,7 +225,6 @@ static int k3_bandgap_probe(struct platform_device *pdev)
 		devm_thermal_add_hwmon_sysfs(dev, data[id].tzd);
 	}
 
-	platform_set_drvdata(pdev, bgp);
 
 	return 0;
 
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Andrei Coardos

This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.

Quoted 20 lines
---
 drivers/thermal/k3_bandgap.c | 1 -
 1 file changed, 1 deletion(-)
drivers/thermal/k3_bandgap.c +0 -2
index 1c3e590157ec..f985f36f2123 100644
@@ -225,7 +225,6 @@ static int k3_bandgap_probe(struct platform_device *pdev)
                devm_thermal_add_hwmon_sysfs(dev, data[id].tzd);
        }
 
-       platform_set_drvdata(pdev, bgp);
 
        return 0;
 
--

2.34.1

#2 lore raw
In reply to Andrei Coardos
Quoted 7 lines · Andrei Coardos

This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.

---

Applied, thanks

Signature · 5 lines
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog