Skip to contentSkip to conversation

irqchip: xtensa-pic: include header for xtensa_pic_init_legacy()

PATCH Applied Arnd Bergmann 5 participants 9 messages Aug 10, 2023 – Aug 21, 2023

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/3 irqchip: xtensa-pic: include header for xtensa_pic_init_legacy()

From: Arnd Bergmann <[email protected]>

The declaration for this function is not included, which leads to a harmless warning:

drivers/irqchip/irq-xtensa-pic.c:91:12: error: no previous prototype for 'xtensa_pic_init_legacy' [-Werror=missing-prototypes]

---
 drivers/irqchip/irq-xtensa-pic.c | 1 +
 1 file changed, 1 insertion(+)
drivers/irqchip/irq-xtensa-pic.c +1 -0
index ab12328be5eed..0c18d1f1e264f 100644
@@ -16,6 +16,7 @@
 #include <linux/irqdomain.h>
 #include <linux/irq.h>
 #include <linux/irqchip.h>
+#include <linux/irqchip/xtensa-pic.h>
 #include <linux/of.h>
 
 unsigned int cached_irq_mask;
Signature · 1 line
2.39.2
#1 lore raw

PATCH 2/3 irqchip: mips-gic: mark gic_irq_domain_free() static

From: Arnd Bergmann <[email protected]>

This function is only used locally and should be static to avoid a warning:

drivers/irqchip/irq-mips-gic.c:560:6: error: no previous prototype for 'gic_irq_domain_free' [-Werror=missing-prototypes]

---
 drivers/irqchip/irq-mips-gic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/irqchip/irq-mips-gic.c +1 -1
index 6d5ecc10a8703..76253e864f230 100644
@@ -557,7 +557,7 @@ static int gic_irq_domain_alloc(struct irq_domain *d, unsigned int virq,
 	return gic_irq_domain_map(d, virq, hwirq);
 }
 
-void gic_irq_domain_free(struct irq_domain *d, unsigned int virq,
+static void gic_irq_domain_free(struct irq_domain *d, unsigned int virq,
 			 unsigned int nr_irqs)
 {
 }
Signature · 1 line
2.39.2
Reviewed-by on v1 2/3
#2 lore raw

Re: [PATCH 2/3] irqchip: mips-gic: mark gic_irq_domain_free() static

Quoted 10 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

This function is only used locally and should be static to avoid a warning:

drivers/irqchip/irq-mips-gic.c:560:6: error: no previous prototype for 'gic_irq_domain_free' [-Werror=missing-prototypes]

---
  drivers/irqchip/irq-mips-gic.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by on v1 2/3
#3 lore raw

Re: [PATCH 2/3] irqchip: mips-gic: mark gic_irq_domain_free() static

In reply to Arnd Bergmann
Quoted 16 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

This function is only used locally and should be static to avoid a warning:

drivers/irqchip/irq-mips-gic.c:560:6: error: no previous prototype for 'gic_irq_domain_free' [-Werror=missing-prototypes]

---
 drivers/irqchip/irq-mips-gic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/irqchip/irq-mips-gic.c +0 -0
index 6d5ecc10a8703..76253e864f230 100644

drivers/irqchip/irq-mips-gic.c static int gic_irq_domain_alloc(struct irq_domain *d, unsigned int virq, · line 562

Quoted 7 lines
drivers/irqchip/irq-mips-gic.c +1 -1
@@ -557,7 +557,7 @@ static int gic_irq_domain_alloc(struct irq_domain *d, unsigned int virq,
 	return gic_irq_domain_map(d, virq, hwirq);
 }
 
 
-void gic_irq_domain_free(struct irq_domain *d, unsigned int virq,
+static void gic_irq_domain_free(struct irq_domain *d, unsigned int virq,
 			 unsigned int nr_irqs)

Right. Thanks! Note the descendant line should be aligned to the function open parenthesis to preserve the coding style well utilized in the driver. With that fixed feel free to add:

-Serge(y)

Quoted 5 lines
drivers/irqchip/irq-mips-gic.c +0 -0
 {

}

Signature · 1 line
2.39.2
#4 lore raw

[irqchip: irq/irqchip-next] irqchip/mips-gic: Mark gic_irq_domain_free() static

In reply to Arnd Bergmann
The following commit has been merged into the irq/irqchip-next branch of irqchip:

The following commit has been merged into the irq/irqchip-next branch of irqchip:

Commit-ID:     90e921d768677172cbb4be1d7597d556ae018020
Gitweb:        https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/90e921d768677172cbb4be1d7597d556ae018020
Author:        Arnd Bergmann <[email protected]>
AuthorDate:    Thu, 10 Aug 2023 14:33:55 +02:00
Committer:     Marc Zyngier <[email protected]>
CommitterDate: Mon, 21 Aug 2023 17:40:20 +01:00

irqchip/mips-gic: Mark gic_irq_domain_free() static

This function is only used locally and should be static to avoid a warning:

drivers/irqchip/irq-mips-gic.c:560:6: error: no previous prototype for 'gic_irq_domain_free' [-Werror=missing-prototypes]

---
 drivers/irqchip/irq-mips-gic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/irqchip/irq-mips-gic.c +1 -1
index 6d5ecc1..76253e8 100644
@@ -557,7 +557,7 @@ static int gic_irq_domain_alloc(struct irq_domain *d, unsigned int virq,
 	return gic_irq_domain_map(d, virq, hwirq);
 }
 
-void gic_irq_domain_free(struct irq_domain *d, unsigned int virq,
+static void gic_irq_domain_free(struct irq_domain *d, unsigned int virq,
 			 unsigned int nr_irqs)
 {
 }
#5 lore raw

PATCH 3/3 irqchip: i8259: mark i8259_of_init() static

In reply to Arnd Bergmann

From: Arnd Bergmann <[email protected]>

i8259_of_init() is only used as an initcall and does not need to be global, so mark it static to avoid:

drivers/irqchip/irq-i8259.c:343:12: warning: no previous prototype for 'i8259_of_init' [-Wmissing-prototypes]

---
 drivers/irqchip/irq-i8259.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/irqchip/irq-i8259.c +1 -1
index b70ce0d3c092e..115bdcffab248 100644
@@ -340,7 +340,7 @@ static void i8259_irq_dispatch(struct irq_desc *desc)
 	generic_handle_domain_irq(domain, hwirq);
 }
 
-int __init i8259_of_init(struct device_node *node, struct device_node *parent)
+static int __init i8259_of_init(struct device_node *node, struct device_node *parent)
 {
 	struct irq_domain *domain;
 	unsigned int parent_irq;
Signature · 1 line
2.39.2
#6 lore raw

[irqchip: irq/irqchip-next] irqchipr/i8259: Mark i8259_of_init() static

The following commit has been merged into the irq/irqchip-next branch of irqchip:

The following commit has been merged into the irq/irqchip-next branch of irqchip:

Commit-ID:     424a4aec7a2392d248e2f260ba571a01e24b8ec2
Gitweb:        https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/424a4aec7a2392d248e2f260ba571a01e24b8ec2
Author:        Arnd Bergmann <[email protected]>
AuthorDate:    Thu, 10 Aug 2023 14:33:56 +02:00
Committer:     Marc Zyngier <[email protected]>
CommitterDate: Mon, 21 Aug 2023 17:40:30 +01:00

irqchipr/i8259: Mark i8259_of_init() static

i8259_of_init() is only used as an initcall and does not need to be global, so mark it static to avoid:

drivers/irqchip/irq-i8259.c:343:12: warning: no previous prototype for 'i8259_of_init' [-Wmissing-prototypes]

---
 drivers/irqchip/irq-i8259.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/irqchip/irq-i8259.c +1 -1
index b70ce0d..115bdcf 100644
@@ -340,7 +340,7 @@ static void i8259_irq_dispatch(struct irq_desc *desc)
 	generic_handle_domain_irq(domain, hwirq);
 }
 
-int __init i8259_of_init(struct device_node *node, struct device_node *parent)
+static int __init i8259_of_init(struct device_node *node, struct device_node *parent)
 {
 	struct irq_domain *domain;
 	unsigned int parent_irq;
maintainer Reviewed-by on v1 1/3
#7 lore raw
In reply to Arnd Bergmann
Quoted 11 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

The declaration for this function is not included, which leads to a harmless warning:

drivers/irqchip/irq-xtensa-pic.c:91:12: error: no previous prototype for 'xtensa_pic_init_legacy' [-Werror=missing-prototypes]

---
 drivers/irqchip/irq-xtensa-pic.c | 1 +
 1 file changed, 1 insertion(+)
Signature · 2 lines
Thanks.
-- Max
#8 lore raw

[irqchip: irq/irqchip-next] irqchip/xtensa-pic: Include header for xtensa_pic_init_legacy()

In reply to Arnd Bergmann
The following commit has been merged into the irq/irqchip-next branch of irqchip:

The following commit has been merged into the irq/irqchip-next branch of irqchip:

Commit-ID:     9bdd26b6477f798e292d0c196b9a8e5b77ce5e1d
Gitweb:        https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/9bdd26b6477f798e292d0c196b9a8e5b77ce5e1d
Author:        Arnd Bergmann <[email protected]>
AuthorDate:    Thu, 10 Aug 2023 14:33:54 +02:00
Committer:     Marc Zyngier <[email protected]>
CommitterDate: Mon, 21 Aug 2023 17:40:08 +01:00

irqchip/xtensa-pic: Include header for xtensa_pic_init_legacy()

The declaration for this function is not included, which leads to a harmless warning:

drivers/irqchip/irq-xtensa-pic.c:91:12: error: no previous prototype for 'xtensa_pic_init_legacy' [-Werror=missing-prototypes]

---
 drivers/irqchip/irq-xtensa-pic.c | 1 +
 1 file changed, 1 insertion(+)
drivers/irqchip/irq-xtensa-pic.c +1 -0
index ab12328..0c18d1f 100644
@@ -16,6 +16,7 @@
 #include <linux/irqdomain.h>
 #include <linux/irq.h>
 #include <linux/irqchip.h>
+#include <linux/irqchip/xtensa-pic.h>
 #include <linux/of.h>
 
 unsigned int cached_irq_mask;