Skip to contentSkip to conversation

6.1.45-rc1 review

PATCH In review Greg Kroah-Hartman 14 participants 149 messages Aug 9, 2023 – Aug 14, 2023 Page 2 of 2

Subsystems (6)
lore
Share & tools
lore
Tested-by on the v1 series
#140 lore raw
In reply to Greg Kroah-Hartman
Quoted 4 lines · Greg Kroah-Hartman

This is the start of the stable review cycle for the 6.1.45 release. There are 127 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

For Rust, build tested and booted to see the trivial Rust sample output in the kernel log:

Cheers,
Miguel

#141 lore raw
In reply to Greg Kroah-Hartman
Quoted 10 lines · Greg Kroah-Hartman

This is the start of the stable review cycle for the 6.1.45 release. There are 127 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

Responses should be made by Fri, 11 Aug 2023 10:36:10 +0000. Anything received after that time might be too late.

The whole patch series can be found in one patch at:

Quoted 8 lines
        https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.45-rc1.gz

or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y
and the diffstat can be found below.

thanks,

greg k-h

While building Linux stable rc 6.1 x86_64 with clang-17 failed due to following warnings / errors.

Regressions found on x86_64:

- build/clang-nightly-lkftconfig-kselftest
- build/clang-nightly-x86_64_defconfig
- build/clang-nightly-lkftconfig
- build/clang-lkftconfig
- build/clang-nightly-allmodconfig

Build errors:
-----
ld.lld: error: ./arch/x86/kernel/vmlinux.lds:193: at least one side of the expression must be absolute
make[2]: *** [scripts/Makefile.vmlinux:34: vmlinux] Error 1

upstream report:
-----
- https://lore.kernel.org/llvm/CA+G9fYsdUeNu-gwbs0+T6XHi4hYYk=Y9725-wFhZ7gJMspLDRA@mail.gmail.com/

Proposed fix patch:
-----
[PATCH] x86/srso: fix build breakage for LD=ld.lld
- https://lore.kernel.org/lkml/[email protected]/T/

This patch is yet to be backported and CC to stable.

--
Linaro LKFT
https://lkft.linaro.org

#142 lore raw
Quoted 13 lines · Naresh Kamboju

Build errors:
-----
ld.lld: error: ./arch/x86/kernel/vmlinux.lds:193: at least one side of the expression must be absolute
make[2]: *** [scripts/Makefile.vmlinux:34: vmlinux] Error 1

upstream report:
-----
- https://lore.kernel.org/llvm/CA+G9fYsdUeNu-gwbs0+T6XHi4hYYk=Y9725-wFhZ7gJMspLDRA@mail.gmail.com/

Quoted 6 lines

Proposed fix patch:
-----
[PATCH] x86/srso: fix build breakage for LD=ld.lld
- https://lore.kernel.org/lkml/[email protected]/T/

This patch is yet to be backported and CC to stable.

It's now in -tip, I would expect it to make -rc6:

https://git.kernel.org/tip/cbe8ded48b939b9d55d2c5589ab56caa7b530709

It should have had 'Cc: [email protected]' but I hope the Fixes:
tag alone will ensure it gets picked up once it hits mainline, especially since there are other fixes that will come in that pull.

Cheers,
Nathan

#143 lore raw
In reply to Naresh Kamboju
Quoted 34 lines · Naresh Kamboju
Quoted 10 lines · Greg Kroah-Hartman

This is the start of the stable review cycle for the 6.1.45 release. There are 127 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

Responses should be made by Fri, 11 Aug 2023 10:36:10 +0000. Anything received after that time might be too late.

The whole patch series can be found in one patch at:

Quoted 8 lines
         https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.45-rc1.gz

or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y
and the diffstat can be found below.

thanks,

greg k-h

While building Linux stable rc 6.1 x86_64 with clang-17 failed due to following warnings / errors.

Regressions found on x86_64:

- build/clang-nightly-lkftconfig-kselftest
- build/clang-nightly-x86_64_defconfig
- build/clang-nightly-lkftconfig
- build/clang-lkftconfig
- build/clang-nightly-allmodconfig

Quoted 6 lines

Build errors:
-----
ld.lld: error: ./arch/x86/kernel/vmlinux.lds:193: at least one side of the expression must be absolute
make[2]: *** [scripts/Makefile.vmlinux:34: vmlinux] Error 1

We see that with v5.10.y, v5.15.y, and v6.1.y when building ChromeOS images with clang/lld. There are additional problems with LTO and the built-in assembler. See
https://www.linuxquestions.org/questions/slackware-14/error-building-kernel-6-1-44-on-current-with-clang-4175727865/
for a summary.

As far as I can see none of those problems has been fixed in the upstream kernel.

Guenter

Quoted 17 lines

upstream report:
-----
- https://lore.kernel.org/llvm/CA+G9fYsdUeNu-gwbs0+T6XHi4hYYk=Y9725-wFhZ7gJMspLDRA@mail.gmail.com/

Proposed fix patch:
-----
[PATCH] x86/srso: fix build breakage for LD=ld.lld
- https://lore.kernel.org/lkml/[email protected]/T/

This patch is yet to be backported and CC to stable.

   --

Linaro LKFT
https://lkft.linaro.org

#144 lore raw
Quoted 8 lines · Guenter Roeck
Quoted 6 lines · Naresh Kamboju

Build errors:
-----
ld.lld: error: ./arch/x86/kernel/vmlinux.lds:193: at least one side of the expression must be absolute
make[2]: *** [scripts/Makefile.vmlinux:34: vmlinux] Error 1

Quoted 4 lines

We see that with v5.10.y, v5.15.y, and v6.1.y when building ChromeOS images with clang/lld. There are additional problems with LTO and the built-in assembler. See
https://www.linuxquestions.org/questions/slackware-14/error-building-kernel-6-1-44-on-current-with-clang-4175727865/
for a summary.

Yup, we have issues open for all of those:

https://github.com/ClangBuiltLinux/linux/issues/1907
https://github.com/ClangBuiltLinux/linux/issues/1909
https://github.com/ClangBuiltLinux/linux/issues/1911

1907 is fixed in -tip and I am sure it will make -rc6 [1].

1909 is fixed with [2] but it is sitting in x86/core (i.e., slated for next merge window). I am guessing at the time it was picked up, it was not fixing a noticeable issue, which is obviously not the case now. Nick reached out to the -tip folks on IRC to inquire about getting that applied to a branch that is going to Linus soon, as it is more of a process issue since it has conflicts with SRSO and an separate issue that was pointed out post-acceptance (which I addressed and pushed to
[3] for testing). I never saw a response there (which is understandable, it is a busy time...) so looping the -tip folks in now, just to make sure it does not get lost (apologies if this is noise).

1911 is still being investigated (some additional eyes on it would not hurt).

[1]: https://git.kernel.org/tip/cbe8ded48b939b9d55d2c5589ab56caa7b530709
[2]: https://git.kernel.org/tip/973ab2d61f33dc85212c486e624af348c4eeb5c9
[3]: https://github.com/ClangBuiltLinux/linux/commit/150c42407f87463c27a2459e06845965291d9973

Quoted 1 line

As far as I can see none of those problems has been fixed in the upstream kernel.

Indeed, embargos are fun... :)

Cheers,
Nathan

#145 lore raw
Quoted 2 lines · Nathan Chancellor

1911 is still being investigated (some additional eyes on it would not hurt).

I'm hoping that we can take this one:

https://lore.kernel.org/r/[email protected]

which should resolve this issue, right?

Signature · 4 lines
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette
#146 lore raw
Quoted 9 lines · Borislav Petkov
Quoted 2 lines · Nathan Chancellor

1911 is still being investigated (some additional eyes on it would not hurt).

I'm hoping that we can take this one:

https://lore.kernel.org/r/[email protected]

which should resolve this issue, right?

Yes, it does, as least for mainline and 6.4. The backport to 6.1 seems hairy (due to a lack of call depth tracking me thinks). It may be worth taking Nick's change there for simplicity's sake but I'll let y'all make that decision.

Cheers,
Nathan

Tested-by on the v1 series
#147 lore raw
In reply to Greg Kroah-Hartman
Quoted 9 lines · Greg Kroah-Hartman

This is the start of the stable review cycle for the 6.1.45 release. There are 127 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

Responses should be made by Fri, 11 Aug 2023 10:36:10 +0000. Anything received after that time might be too late.

The whole patch series can be found in one patch at:

Quoted 8 lines
	https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.45-rc1.gz

or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y
and the diffstat can be found below.

thanks,

greg k-h

All tests passing for Tegra ...

Test results for stable-v6.1:

    11 builds:	11 pass, 0 fail
    28 boots:	28 pass, 0 fail
    130 tests:	130 pass, 0 fail

Linux version: 6.1.45-rc1-g02a4c6c322d1
Boards tested: tegra124-jetson-tk1, tegra186-p2771-0000,

                tegra194-p2972-0000, tegra194-p3509-0000+p3668-0000,
                tegra20-ventana, tegra210-p2371-2180,
                tegra210-p3450-0000, tegra30-cardhu-a04
Tested-by on the v1 series
#148 lore raw
In reply to Greg Kroah-Hartman
Quoted 4 lines · Greg Kroah-Hartman

This is the start of the stable review cycle for the 6.1.45 release. There are 127 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

Nothing looking amiss from here..

Thanks,
Conor.