dmaengine: idxd: Allow ATS disable update only for configurable devices
Subsystems (2)
PATCH 1/2 dmaengine: idxd: Allow ATS disable update only for configurable devices
ATS disable status in a WQ is read-only if the device is not configurable. This change ensures that the ATS disable attribute can be modified via sysfs only on configurable devices.
---
Applied cleanly to
https://git.kernel.org/pub/scm/linux/kernel/git/vkoul/dmaengine next
drivers/dma/idxd/sysfs.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/dma/idxd/sysfs.c +4 -0
@@ -1088,12 +1088,16 @@ static ssize_t wq_ats_disable_store(struct device *dev, struct device_attribute const char *buf, size_t count) {struct idxd_wq *wq =confdev_to_wq (dev); +struct idxd_device *idxd = wq->idxd;bool ats_dis;int rc;if (wq->state !=IDXD_WQ_DISABLED )return -EPERM ; +if (!test_bit (IDXD_FLAG_CONFIGURABLE , &idxd->flags)) +return -EPERM ; + rc =kstrtobool (buf, &ats_dis);if (rc <0 )return rc;
Signature · 1 line
2.37.1
PATCH 2/2 dmaengine: idxd: Fix issues with PRS disable sysfs knob
There are two issues in the current PRS disable sysfs store function wq_prs_disable_store():
1. Since PRS disable knob is invisible if PRS disable is not supported in WQ, it's redundant to check PRS support again in the store function again. Remove the redundant PRS support check.
2. Since PRS disable is read-only when the device is not configurable, PRS disable cannot be changed on the device. Add device configurable check in the store function.
---
Applied cleanly to
https://git.kernel.org/pub/scm/linux/kernel/git/vkoul/dmaengine next
drivers/dma/idxd/sysfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/dma/idxd/sysfs.c +2 -2
@@ -1131,8 +1131,8 @@ static ssize_t wq_prs_disable_store(struct device *dev, struct device_attributeif (wq->state !=IDXD_WQ_DISABLED )return -EPERM ; -if (!idxd->hw.wq_cap.wq_prs_support) -return -EOPNOTSUPP ; +if (!test_bit (IDXD_FLAG_CONFIGURABLE , &idxd->flags)) +return -EPERM ; rc =kstrtobool (buf, &prs_dis);if (rc <0 )
Signature · 1 line
2.37.1
Quoted 5 lines · Fenghua Yu
ATS disable status in a WQ is read-only if the device is not configurable. This change ensures that the ATS disable attribute can be modified via sysfs only on configurable devices.
Applied, thanks!
[1/2] dmaengine: idxd: Allow ATS disable update only for configurable devices
commit: 0056a7f07b0a63e6cee815a789eabba6f3a710f0
[2/2] dmaengine: idxd: Fix issues with PRS disable sysfs knob
commit: 8cae66574398326134a41513b419e00ad4e380caBest regards,
Signature · 1 line
~Vinod