Skip to contentSkip to conversation

server/process: fix sig handle

PATCH In review [email protected] 2 participants 2 messages Aug 11, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 server/process: fix sig handle

From: Yang Xu <[email protected]>

process.signal_received is a list for signum and not iterable, change a suitable method to handle sig.

---
 lib/bb/server/process.py | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)
lib/bb/server/process.py +4 -5
index 4d4fa6d1..f62faed0 100644
@@ -860,11 +860,10 @@ class ConnectionWriter(object):
                 process.queue_signals = True
                 self._send(obj)
                 process.queue_signals = False
-                try:
-                    for sig in process.signal_received.pop():
-                        process.handle_sig(sig, None)
-                except IndexError:
-                    pass
+
+                while len(process.signal_received) > 0:
+                    sig = process.signal_received.pop()
+                    process.handle_sig(sig, None)
         else:
             self._send(obj)
 
Signature · 1 line
2.25.1
#1 lore raw
Quoted 20 lines · On Fri, 2023-08-11 at 02:20 +0000, [email protected] wrote:

From: Yang Xu <[email protected]>

process.signal_received is a list for signum and not iterable, change a suitable method to handle sig.

---
 lib/bb/server/process.py | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)
lib/bb/server/process.py +0 -2
index 4d4fa6d1..f62faed0 100644
@@ -860,11 +860,10 @@ class ConnectionWriter(object):
                 process.queue_signals = True
                 self._send(obj)
                 process.queue_signals = False
-                try:
-                    for sig in process.signal_received.pop():

lib/bb/server/process.py class ConnectionWriter(object): · line 869

Quoted 10 lines
lib/bb/server/process.py +4 -3
-                        process.handle_sig(sig, None)
-                except IndexError:
-                    pass
+
+                while len(process.signal_received) > 0:
+                    sig = process.signal_received.pop()
+                    process.handle_sig(sig, None)
         else:
             self._send(obj)
 

Well spotted, thanks!

Cheers,

Richard