dt-bindings: opp/cpufreq: Convert ti-cpufreq to json schema
Subsystems (3)
Nishanth Menon
maintainerv4 cover dt-bindings: opp/cpufreq: Convert ti-cpufreq to json schema
Hi,
Convert the long pending free-form text bindings of ti-cpufreq and omap5-opp-supply bindings to json-schema.
Hopefully, this version is better..
Changes from V3:
* Changed the description of the bindings documents to be more aligned with current standards (Dhruva's comments)
V3: https://lore.kernel.org/all/[email protected]/
V2: https://lore.kernel.org/all/[email protected]/
V1: https://lore.kernel.org/all/[email protected]/
Nishanth Menon (2):
dt-bindings: opp: Convert ti-omap5-opp-supply to json schema
dt-bindings: cpufreq: Convert ti-cpufreq to json schema
.../bindings/cpufreq/ti-cpufreq.txt | 132 ------------------ .../opp/operating-points-v2-ti-cpu.yaml | 92 ++++++++++++ .../bindings/opp/ti,omap-opp-supply.yaml | 106 ++++++++++++++ .../bindings/opp/ti-omap5-opp-supply.txt | 63 --------- 4 files changed, 198 insertions(+), 195 deletions(-) delete mode 100644 Documentation/devicetree/bindings/cpufreq/ti-cpufreq.txt create mode 100644 Documentation/devicetree/bindings/opp/operating-points-v2-ti-cpu.yaml create mode 100644 Documentation/devicetree/bindings/opp/ti,omap-opp-supply.yaml delete mode 100644 Documentation/devicetree/bindings/opp/ti-omap5-opp-supply.txt
Signature · 1 line
2.40.0
Nishanth Menon
maintainerPATCH v4 1/2 dt-bindings: opp: Convert ti-omap5-opp-supply to json schema
Rename ti-omap5-opp-supply to be bit more generic omap-opp-supply and convert the free text binding to json-schema.
---
Changes since V3:
* Rewrote the description of the binding to something more relevant to current style of documentation.
V3: https://lore.kernel.org/all/[email protected]/
V2: https://lore.kernel.org/all/[email protected]/
V1: https://lore.kernel.org/all/[email protected]/
.../bindings/opp/ti,omap-opp-supply.yaml | 106 ++++++++++++++++++ .../bindings/opp/ti-omap5-opp-supply.txt | 63 ----------- 2 files changed, 106 insertions(+), 63 deletions(-) create mode 100644 Documentation/devicetree/bindings/opp/ti,omap-opp-supply.yaml delete mode 100644 Documentation/devicetree/bindings/opp/ti-omap5-opp-supply.txt
Documentation/devicetree/bindings/opp/ti,omap-opp-supply.yaml new file +106 -0
@@ -0,0 +1,106 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/opp/ti,omap-opp-supply.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Texas Instruments OMAP compatible OPP supply + +description: + OMAP5, DRA7, and AM57 families of SoCs have Class 0 AVS eFuse + registers, which contain OPP-specific voltage information tailored + for the specific device. This binding provides the information + needed to describe such a hardware values and relate them to program + the primary regulator during an OPP transition. + + Also, some supplies may have an associated vbb-supply, an Adaptive + Body Bias regulator, which must transition in a specific sequence + w.r.t the vdd-supply and clk when making an OPP transition. By + supplying two regulators to the device that will undergo OPP + transitions, we can use the multi-regulator support implemented by + the OPP core to describe both regulators the platform needs. The + OPP core binding Documentation/devicetree/bindings/opp/opp-v2.yaml + provides further information (refer to Example 4 Handling multiple + regulators). + +maintainers: + - Nishanth Menon <[email protected]> + +properties: + $nodename: + pattern: '^opp-supply(@[0-9a-f]+)?$' + + compatible: + oneOf: + - description: Basic OPP supply controlling VDD and VBB + items: + - const: ti,omap-opp-supply + - description: OMAP5+ optimized voltages in efuse(Class 0) VDD along with + VBB. + items: + - const: ti,omap5-opp-supply + - description: OMAP5+ optimized voltages in efuse(class0) VDD but no VBB + items: + - const: ti,omap5-core-opp-supply + + reg: + maxItems: 1 + + ti,absolute-max-voltage-uv: + $ref: /schemas/types.yaml#/definitions/uint32 + description: Absolute maximum voltage for the OPP supply in micro-volts. + minimum: 750000 + maximum: 1500000 + + ti,efuse-settings: + description: An array of u32 tuple items providing information about + optimized efuse configuration. + minItems: 1 + $ref: /schemas/types.yaml#/definitions/uint32-matrix + items: + items: + - + description: Reference voltage in micro-volts (OPP Voltage) + minimum: 750000 + maximum: 1500000 + multipleOf: 10000 + - + description: efuse offset where the optimized voltage is located + multipleOf: 4 + maximum: 256 + +required: + - compatible + - ti,absolute-max-voltage-uv + +allOf: + - if: + not: + properties: + compatible: + contains: + const: ti,omap-opp-supply + then: + required: + - reg + - ti,efuse-settings + +additionalProperties: false + +examples: + - | + opp-supply { + compatible = "ti,omap-opp-supply"; + ti,absolute-max-voltage-uv = <1375000>; + }; + - | + opp-supply@4a003b20 { + compatible = "ti,omap5-opp-supply"; + reg = <0x4a003b20 0x8>; + ti,efuse-settings = + /* uV offset */ + <1060000 0x0>, + <1160000 0x4>, + <1210000 0x8>; + ti,absolute-max-voltage-uv = <1500000>; + };
Documentation/devicetree/bindings/opp/ti-omap5-opp-supply.txt deleted +0 -63
63 lines not on this page · raw message
Signature · 1 line
2.40.0
Re: [PATCH V4 1/2] dt-bindings: opp: Convert ti-omap5-opp-supply to json schema
Quoted 38 lines · Nishanth Menon
Rename ti-omap5-opp-supply to be bit more generic omap-opp-supply and convert the free text binding to json-schema.
Signed-off-by Nishanth Menon <[email protected]>---
Changes since V3:
* Rewrote the description of the binding to something more relevant to current style of documentation.V3: https://lore.kernel.org/all/[email protected]/
V2: https://lore.kernel.org/all/[email protected]/
V1: https://lore.kernel.org/all/[email protected]/.../bindings/opp/ti,omap-opp-supply.yaml | 106 ++++++++++++++++++ .../bindings/opp/ti-omap5-opp-supply.txt | 63 ----------- 2 files changed, 106 insertions(+), 63 deletions(-) create mode 100644 Documentation/devicetree/bindings/opp/ti,omap-opp-supply.yaml delete mode 100644 Documentation/devicetree/bindings/opp/ti-omap5-opp-supply.txtDocumentation/devicetree/bindings/opp/ti,omap-opp-supply.yaml new file +13
-0@@ -0,0 +1,106 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/opp/ti,omap-opp-supply.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Texas Instruments OMAP compatible OPP supply + +description: + OMAP5, DRA7, and AM57 families of SoCs have Class 0 AVS eFuse + registers, which contain OPP-specific voltage information tailored + for the specific device. This binding provides the information + needed to describe such a hardware values and relate them to program
Documentation/devicetree/bindings/opp/ti,omap-opp-supply.yaml line 23
Quoted 10 lines
Documentation/devicetree/bindings/opp/ti,omap-opp-supply.yaml new file +10
-0+ the primary regulator during an OPP transition. + + Also, some supplies may have an associated vbb-supply, an Adaptive + Body Bias regulator, which must transition in a specific sequence + w.r.t the vdd-supply and clk when making an OPP transition. By + supplying two regulators to the device that will undergo OPP + transitions, we can use the multi-regulator support implemented by + the OPP core to describe both regulators the platform needs. The + OPP core binding Documentation/devicetree/bindings/opp/opp-v2.yaml + provides further information (refer to Example 4 Handling multiple
Thanks, this makes it much more clear to me :)
Quoted 5 lines
Documentation/devicetree/bindings/opp/ti,omap-opp-supply.yaml new file +5
-0+ regulators). + +maintainers: + - Nishanth Menon <[email protected]> +
[...]
Signature · 2 lines
Best regards, Dhruva Gole <[email protected]>
Re: [PATCH V4 1/2] dt-bindings: opp: Convert ti-omap5-opp-supply to json schema
In reply to Nishanth MenonQuoted 58 lines · Nishanth Menon
Rename ti-omap5-opp-supply to be bit more generic omap-opp-supply and convert the free text binding to json-schema.
Signed-off-by Nishanth Menon <[email protected]>---
Changes since V3:
* Rewrote the description of the binding to something more relevant to current style of documentation.V3: https://lore.kernel.org/all/[email protected]/
V2: https://lore.kernel.org/all/[email protected]/
V1: https://lore.kernel.org/all/[email protected]/.../bindings/opp/ti,omap-opp-supply.yaml | 106 ++++++++++++++++++ .../bindings/opp/ti-omap5-opp-supply.txt | 63 ----------- 2 files changed, 106 insertions(+), 63 deletions(-) create mode 100644 Documentation/devicetree/bindings/opp/ti,omap-opp-supply.yaml delete mode 100644 Documentation/devicetree/bindings/opp/ti-omap5-opp-supply.txtDocumentation/devicetree/bindings/opp/ti,omap-opp-supply.yaml new file +33
-0@@ -0,0 +1,106 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/opp/ti,omap-opp-supply.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Texas Instruments OMAP compatible OPP supply + +description: + OMAP5, DRA7, and AM57 families of SoCs have Class 0 AVS eFuse + registers, which contain OPP-specific voltage information tailored + for the specific device. This binding provides the information + needed to describe such a hardware values and relate them to program + the primary regulator during an OPP transition. + + Also, some supplies may have an associated vbb-supply, an Adaptive + Body Bias regulator, which must transition in a specific sequence + w.r.t the vdd-supply and clk when making an OPP transition. By + supplying two regulators to the device that will undergo OPP + transitions, we can use the multi-regulator support implemented by + the OPP core to describe both regulators the platform needs. The + OPP core binding Documentation/devicetree/bindings/opp/opp-v2.yaml + provides further information (refer to Example 4 Handling multiple + regulators). + +maintainers: + - Nishanth Menon <[email protected]> + +properties: + $nodename: + pattern: '^opp-supply(@[0-9a-f]+)?$' + + compatible:
Documentation/devicetree/bindings/opp/ti,omap-opp-supply.yaml line 43
Quoted 10 lines
Documentation/devicetree/bindings/opp/ti,omap-opp-supply.yaml new file +10
-0+ oneOf: + - description: Basic OPP supply controlling VDD and VBB + items: + - const: ti,omap-opp-supply + - description: OMAP5+ optimized voltages in efuse(Class 0) VDD along with + VBB. + items: + - const: ti,omap5-opp-supply + - description: OMAP5+ optimized voltages in efuse(class0) VDD but no VBB + items:
This and previous cases should be just "const:", because you have only one item.
Quoted 9 lines
Documentation/devicetree/bindings/opp/ti,omap-opp-supply.yaml new file +9
-0+ - const: ti,omap5-core-opp-supply + + reg: + maxItems: 1 + + ti,absolute-max-voltage-uv: + $ref: /schemas/types.yaml#/definitions/uint32 + description: Absolute maximum voltage for the OPP supply in micro-volts. + minimum: 750000
Documentation/devicetree/bindings/opp/ti,omap-opp-supply.yaml line 62
Quoted 10 lines
Documentation/devicetree/bindings/opp/ti,omap-opp-supply.yaml new file +10
-0+ maximum: 1500000 + + ti,efuse-settings: + description: An array of u32 tuple items providing information about + optimized efuse configuration. + minItems: 1 + $ref: /schemas/types.yaml#/definitions/uint32-matrix + items: + items: + -
Don't wrap (drop line break). It should be just like you have in compatible.
Documentation/devicetree/bindings/opp/ti,omap-opp-supply.yaml line 71
Quoted 9 lines
Documentation/devicetree/bindings/opp/ti,omap-opp-supply.yaml new file +9
-0+ description: Reference voltage in micro-volts (OPP Voltage) + minimum: 750000 + maximum: 1500000 + multipleOf: 10000 + - + description: efuse offset where the optimized voltage is located + multipleOf: 4 + maximum: 256 +
Rest looks good to me, so with above:
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Nishanth Menon
maintainerPATCH v4 2/2 dt-bindings: cpufreq: Convert ti-cpufreq to json schema
In reply to Nishanth MenonMove the ti-cpufreq binding over to opp and convert the free text binding to json-schema.
---
Changes since V3:
* Rewrote the description of the binding to something more relevant to current style of documentation.
* Due to the rewrite in description, I have dropped Dhruva's Reviewed-by.
V3: https://lore.kernel.org/all/[email protected]/
V2: https://lore.kernel.org/all/[email protected]
V1: https://lore.kernel.org/all/[email protected]/
.../bindings/cpufreq/ti-cpufreq.txt | 132 ------------------ .../opp/operating-points-v2-ti-cpu.yaml | 92 ++++++++++++ 2 files changed, 92 insertions(+), 132 deletions(-) delete mode 100644 Documentation/devicetree/bindings/cpufreq/ti-cpufreq.txt create mode 100644 Documentation/devicetree/bindings/opp/operating-points-v2-ti-cpu.yaml
Documentation/devicetree/bindings/cpufreq/ti-cpufreq.txt deleted +0 -132
@@ -1,132 +0,0 @@ -TI CPUFreq and OPP bindings -================================ - -Certain TI SoCs, like those in the am335x, am437x, am57xx, and dra7xx -families support different OPPs depending on the silicon variant in use. -The ti-cpufreq driver can use revision and an efuse value from the SoC to -provide the OPP framework with supported hardware information. This is -used to determine which OPPs from the operating-points-v2 table get enabled -when it is parsed by the OPP framework. - -Required properties: --------------------- -In 'cpus' nodes: -- operating-points-v2: Phandle to the operating-points-v2 table to use. - -In 'operating-points-v2' table: -- compatible: Should be - - 'operating-points-v2-ti-cpu' for am335x, am43xx, and dra7xx/am57xx, - omap34xx, omap36xx and am3517 SoCs -- syscon: A phandle pointing to a syscon node representing the control module - register space of the SoC. - -Optional properties: --------------------- -- "vdd-supply", "vbb-supply": to define two regulators for dra7xx -- "cpu0-supply", "vbb-supply": to define two regulators for omap36xx - -For each opp entry in 'operating-points-v2' table: -- opp-supported-hw: Two bitfields indicating: - 1. Which revision of the SoC the OPP is supported by - 2. Which eFuse bits indicate this OPP is available - - A bitwise AND is performed against these values and if any bit - matches, the OPP gets enabled. - -Example: --------- - -/* From arch/arm/boot/dts/am33xx.dtsi */ -cpus { - #address-cells = <1>; - #size-cells = <0>; - cpu@0 { - compatible = "arm,cortex-a8"; - device_type = "cpu"; - reg = <0>; - - operating-points-v2 = <&cpu0_opp_table>; - - clocks = <&dpll_mpu_ck>; - clock-names = "cpu"; - - clock-latency = <300000>; /* From omap-cpufreq driver */ - }; -}; - -/* - * cpu0 has different OPPs depending on SoC revision and some on revisions - * 0x2 and 0x4 have eFuse bits that indicate if they are available or not - */ -cpu0_opp_table: opp-table { - compatible = "operating-points-v2-ti-cpu"; - syscon = <&scm_conf>; - - /* - * The three following nodes are marked with opp-suspend - * because they can not be enabled simultaneously on a - * single SoC. - */ - opp50-300000000 { - opp-hz = /bits/ 64 <300000000>; - opp-microvolt = <950000 931000 969000>; - opp-supported-hw = <0x06 0x0010>; - opp-suspend; - }; - - opp100-275000000 { - opp-hz = /bits/ 64 <275000000>; - opp-microvolt = <1100000 1078000 1122000>; - opp-supported-hw = <0x01 0x00FF>; - opp-suspend; - }; - - opp100-300000000 { - opp-hz = /bits/ 64 <300000000>; - opp-microvolt = <1100000 1078000 1122000>; - opp-supported-hw = <0x06 0x0020>; - opp-suspend; - }; - - opp100-500000000 { - opp-hz = /bits/ 64 <500000000>; - opp-microvolt = <1100000 1078000 1122000>; - opp-supported-hw = <0x01 0xFFFF>; - }; - - opp100-600000000 { - opp-hz = /bits/ 64 <600000000>; - opp-microvolt = <1100000 1078000 1122000>; - opp-supported-hw = <0x06 0x0040>; - }; - - opp120-600000000 { - opp-hz = /bits/ 64 <600000000>; - opp-microvolt = <1200000 1176000 1224000>; - opp-supported-hw = <0x01 0xFFFF>; - }; - - opp120-720000000 { - opp-hz = /bits/ 64 <720000000>; - opp-microvolt = <1200000 1176000 1224000>; - opp-supported-hw = <0x06 0x0080>; - }; - - oppturbo-720000000 { - opp-hz = /bits/ 64 <720000000>; - opp-microvolt = <1260000 1234800 1285200>; - opp-supported-hw = <0x01 0xFFFF>; - }; - - oppturbo-800000000 { - opp-hz = /bits/ 64 <800000000>; - opp-microvolt = <1260000 1234800 1285200>; - opp-supported-hw = <0x06 0x0100>; - }; - - oppnitro-1000000000 { - opp-hz = /bits/ 64 <1000000000>; - opp-microvolt = <1325000 1298500 1351500>; - opp-supported-hw = <0x04 0x0200>; - }; -};
Documentation/devicetree/bindings/opp/operating-points-v2-ti-cpu.yaml new file +92 -0
92 lines not on this page · raw message
Signature · 1 line
2.40.0
Re: [PATCH V4 2/2] dt-bindings: cpufreq: Convert ti-cpufreq to json schema
Quoted 10 lines · Nishanth Menon
Move the ti-cpufreq binding over to opp and convert the free text binding to json-schema.
Signed-off-by Nishanth Menon <[email protected]>---
Changes since V3:
* Rewrote the description of the binding to something more relevant to current style of documentation.
* Due to the rewrite in description, I have dropped Dhruva's Reviewed-by.
OK
Quoted 11 lines
V3: https://lore.kernel.org/all/[email protected]/
V2: https://lore.kernel.org/all/[email protected]
V1: https://lore.kernel.org/all/[email protected]/.../bindings/cpufreq/ti-cpufreq.txt | 132 ------------------ .../opp/operating-points-v2-ti-cpu.yaml | 92 ++++++++++++ 2 files changed, 92 insertions(+), 132 deletions(-) delete mode 100644 Documentation/devicetree/bindings/cpufreq/ti-cpufreq.txt create mode 100644 Documentation/devicetree/bindings/opp/operating-points-v2-ti-cpu.yaml
[...]
Quoted 16 lines
Documentation/devicetree/bindings/opp/operating-points-v2-ti-cpu.yaml new file +10
-0@@ -0,0 +1,92 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/opp/operating-points-v2-ti-cpu.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: TI CPU OPP (Operating Performance Points) + +description: + TI SoCs, like those in the AM335x, AM437x, AM57xx, AM62x, and DRA7xx
Documentation/devicetree/bindings/opp/operating-points-v2-ti-cpu.yaml line 20
Quoted 10 lines
Documentation/devicetree/bindings/opp/operating-points-v2-ti-cpu.yaml new file +10
-0+ families, the CPU frequencies subset and the voltage value of each + OPP vary based on the silicon variant used. The data sheet sections + corresponding to "Operating Performance Points" describe the frequency + and voltage values based on device type and speed bin information + blown in corresponding eFuse bits as referred to by the Technical + Reference Manual. + + This document extends the operating-points-v2 binding by providing + the hardware description for the scheme mentioned above. +
[...]
Thanks for addressing my comments,
Signature · 2 lines
Best regards, Dhruva Gole <[email protected]>