arm64: dts: imx8m-venice: Pass "brcm,bcm4329-fmac"
Subsystems (2)
Fabio Estevam
reviewerPATCH 1/1 arm64: dts: imx8m-venice: Pass "brcm,bcm4329-fmac"
From: Fabio Estevam <[email protected]>
Pass "brcm,bcm4329-fmac" to fix the following schema warnings:
imx8mp-venice-gw74xx.dtb: wifi@0: compatible: 'oneOf' conditional failed, one must be fixed:
['cypress,cyw4373-fmac'] is too short 'cypress,cyw4373-fmac' is not one of ['brcm,bcm4329-fmac', 'pci14e4,43dc', 'pci14e4,4464', 'pci14e4,4488', 'pci14e4,4425', 'pci14e4,4433'] from schema $id: http://devicetree.org/schemas/net/wireless/brcm,bcm4329-fmac.yaml#
imx8mn-venice-gw7902.dtb: wifi@0: compatible: 'oneOf' conditional failed, one must be fixed:
['brcm,bcm43455-fmac'] is too short 'brcm,bcm43455-fmac' is not one of ['brcm,bcm4329-fmac', 'pci14e4,43dc', 'pci14e4,4464', 'pci14e4,4488', 'pci14e4,4425', 'pci14e4,4433'] from schema $id: http://devicetree.org/schemas/net/wireless/brcm,bcm4329-fmac.yaml#
--- arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts | 2 +- arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts | 2 +- arch/arm64/boot/dts/freescale/imx8mn-venice-gw7902.dts | 2 +- arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-)
arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts +1 -1
@@ -801,7 +801,7 @@ &usdhc1 { status = "okay"; wifi@0 { - compatible = "brcm,bcm43455-fmac"; + compatible = "brcm,bcm43455-fmac", "brcm,bcm4329-fmac"; reg = <0>; }; };
arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts +1 -1
@@ -726,7 +726,7 @@ &usdhc2 { status = "okay"; wifi@0 { - compatible = "brcm,bcm43455-fmac"; + compatible = "brcm,bcm43455-fmac", "brcm,bcm4329-fmac"; reg = <0>; }; };
arch/arm64/boot/dts/freescale/imx8mn-venice-gw7902.dts +1 -1
@@ -679,7 +679,7 @@ &usdhc2 { status = "okay"; wifi@0 { - compatible = "brcm,bcm43455-fmac"; + compatible = "brcm,bcm43455-fmac", "brcm,bcm4329-fmac"; reg = <0>; }; };
arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts +1 -1
@@ -737,7 +737,7 @@ &usdhc1 { status = "okay"; wifi@0 { - compatible = "cypress,cyw4373-fmac"; + compatible = "cypress,cyw4373-fmac", "brcm,bcm4329-fmac"; reg = <0>; }; };
Signature · 1 line
2.34.1
Quoted 76 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
Pass "brcm,bcm4329-fmac" to fix the following schema warnings:
imx8mp-venice-gw74xx.dtb: wifi@0: compatible: 'oneOf' conditional failed, one must be fixed:
['cypress,cyw4373-fmac'] is too short 'cypress,cyw4373-fmac' is not one of ['brcm,bcm4329-fmac', 'pci14e4,43dc', 'pci14e4,4464', 'pci14e4,4488', 'pci14e4,4425', 'pci14e4,4433'] from schema $id: http://devicetree.org/schemas/net/wireless/brcm,bcm4329-fmac.yaml#imx8mn-venice-gw7902.dtb: wifi@0: compatible: 'oneOf' conditional failed, one must be fixed:
['brcm,bcm43455-fmac'] is too short 'brcm,bcm43455-fmac' is not one of ['brcm,bcm4329-fmac', 'pci14e4,43dc', 'pci14e4,4464', 'pci14e4,4488', 'pci14e4,4425', 'pci14e4,4433'] from schema $id: http://devicetree.org/schemas/net/wireless/brcm,bcm4329-fmac.yaml#Signed-off-by Fabio Estevam <[email protected]>--- arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts | 2 +- arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts | 2 +- arch/arm64/boot/dts/freescale/imx8mn-venice-gw7902.dts | 2 +- arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-)arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts +1
-1@@ -801,7 +801,7 @@ &usdhc1 { status = "okay"; wifi@0 { - compatible = "brcm,bcm43455-fmac"; + compatible = "brcm,bcm43455-fmac", "brcm,bcm4329-fmac"; reg = <0>; }; };arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts +1
-1@@ -726,7 +726,7 @@ &usdhc2 { status = "okay"; wifi@0 { - compatible = "brcm,bcm43455-fmac"; + compatible = "brcm,bcm43455-fmac", "brcm,bcm4329-fmac"; reg = <0>; }; };arch/arm64/boot/dts/freescale/imx8mn-venice-gw7902.dts +1
-1@@ -679,7 +679,7 @@ &usdhc2 { status = "okay"; wifi@0 { - compatible = "brcm,bcm43455-fmac"; + compatible = "brcm,bcm43455-fmac", "brcm,bcm4329-fmac"; reg = <0>; }; };arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts +1
-2@@ -737,7 +737,7 @@ &usdhc1 { status = "okay"; wifi@0 { - compatible = "cypress,cyw4373-fmac"; + compatible = "cypress,cyw4373-fmac", "brcm,bcm4329-fmac"; reg = <0>; }; }; --
Quoted 2 lines
2.34.1
Fabio,
Thank you for your continued efforts to squash out all these dt-binding warnings/issues.
Can you explain what the difference is in the dt-binding yaml between compatible/oneOf/items/{enum,const} and compatible/oneOf/enum? The first list for Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml has a much larger set of enums including the bcm43455 on these boards but the second set of enums has a much more limited set. There is no driver code to look at for this because it is bound via SDIO device id's instead of the dt compatible property.
Best regards,
Tim
Quoted 82 lines · Tim Harvey
Quoted 76 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
Pass "brcm,bcm4329-fmac" to fix the following schema warnings:
imx8mp-venice-gw74xx.dtb: wifi@0: compatible: 'oneOf' conditional failed, one must be fixed:
['cypress,cyw4373-fmac'] is too short 'cypress,cyw4373-fmac' is not one of ['brcm,bcm4329-fmac', 'pci14e4,43dc', 'pci14e4,4464', 'pci14e4,4488', 'pci14e4,4425', 'pci14e4,4433'] from schema $id: http://devicetree.org/schemas/net/wireless/brcm,bcm4329-fmac.yaml#imx8mn-venice-gw7902.dtb: wifi@0: compatible: 'oneOf' conditional failed, one must be fixed:
['brcm,bcm43455-fmac'] is too short 'brcm,bcm43455-fmac' is not one of ['brcm,bcm4329-fmac', 'pci14e4,43dc', 'pci14e4,4464', 'pci14e4,4488', 'pci14e4,4425', 'pci14e4,4433'] from schema $id: http://devicetree.org/schemas/net/wireless/brcm,bcm4329-fmac.yaml#Signed-off-by Fabio Estevam <[email protected]>--- arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts | 2 +- arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts | 2 +- arch/arm64/boot/dts/freescale/imx8mn-venice-gw7902.dts | 2 +- arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-)arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts +1
-1@@ -801,7 +801,7 @@ &usdhc1 { status = "okay"; wifi@0 { - compatible = "brcm,bcm43455-fmac"; + compatible = "brcm,bcm43455-fmac", "brcm,bcm4329-fmac"; reg = <0>; }; };arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts +1
-1@@ -726,7 +726,7 @@ &usdhc2 { status = "okay"; wifi@0 { - compatible = "brcm,bcm43455-fmac"; + compatible = "brcm,bcm43455-fmac", "brcm,bcm4329-fmac"; reg = <0>; }; };arch/arm64/boot/dts/freescale/imx8mn-venice-gw7902.dts +1
-1@@ -679,7 +679,7 @@ &usdhc2 { status = "okay"; wifi@0 { - compatible = "brcm,bcm43455-fmac"; + compatible = "brcm,bcm43455-fmac", "brcm,bcm4329-fmac"; reg = <0>; }; };arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts +1
-2@@ -737,7 +737,7 @@ &usdhc1 { status = "okay"; wifi@0 { - compatible = "cypress,cyw4373-fmac"; + compatible = "cypress,cyw4373-fmac", "brcm,bcm4329-fmac"; reg = <0>; }; }; --Quoted 2 lines
2.34.1
Fabio,
Quoted 5 lines
Thank you for your continued efforts to squash out all these dt-binding warnings/issues.
Can you explain what the difference is in the dt-binding yaml between compatible/oneOf/items/{enum,const} and compatible/oneOf/enum? The
items defines a list. items with enum and const, defines a list of two items, where first is an enum (so oneOf few) and second is fixed.
compatible/oneOf/enum is not a list. Or you could look at it as one-element-list.
Quoted 3 lines
first list for
Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yamlhas a much larger set of enums including the bcm43455 on these boards but the second set of enums has a much more limited set.
What's the question here? Both define different things. One defines compatible devices with some model, second defines just some devices.
Quoted 7 lines
There is no
driver code to look at for this because it is bound via SDIO device id's instead of the dt compatible property.Best regards,
Tim
Best regards,
Krzysztof
Tim Harvey
Acked-byQuoted 97 lines · Krzysztof Kozlowski
Quoted 82 lines · Tim Harvey
Quoted 76 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
Pass "brcm,bcm4329-fmac" to fix the following schema warnings:
imx8mp-venice-gw74xx.dtb: wifi@0: compatible: 'oneOf' conditional failed, one must be fixed:
['cypress,cyw4373-fmac'] is too short 'cypress,cyw4373-fmac' is not one of ['brcm,bcm4329-fmac', 'pci14e4,43dc', 'pci14e4,4464', 'pci14e4,4488', 'pci14e4,4425', 'pci14e4,4433'] from schema $id: http://devicetree.org/schemas/net/wireless/brcm,bcm4329-fmac.yaml#imx8mn-venice-gw7902.dtb: wifi@0: compatible: 'oneOf' conditional failed, one must be fixed:
['brcm,bcm43455-fmac'] is too short 'brcm,bcm43455-fmac' is not one of ['brcm,bcm4329-fmac', 'pci14e4,43dc', 'pci14e4,4464', 'pci14e4,4488', 'pci14e4,4425', 'pci14e4,4433'] from schema $id: http://devicetree.org/schemas/net/wireless/brcm,bcm4329-fmac.yaml#Signed-off-by Fabio Estevam <[email protected]>--- arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts | 2 +- arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts | 2 +- arch/arm64/boot/dts/freescale/imx8mn-venice-gw7902.dts | 2 +- arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-)arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts +1
-1@@ -801,7 +801,7 @@ &usdhc1 { status = "okay"; wifi@0 { - compatible = "brcm,bcm43455-fmac"; + compatible = "brcm,bcm43455-fmac", "brcm,bcm4329-fmac"; reg = <0>; }; };arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts +1
-1@@ -726,7 +726,7 @@ &usdhc2 { status = "okay"; wifi@0 { - compatible = "brcm,bcm43455-fmac"; + compatible = "brcm,bcm43455-fmac", "brcm,bcm4329-fmac"; reg = <0>; }; };arch/arm64/boot/dts/freescale/imx8mn-venice-gw7902.dts +1
-1@@ -679,7 +679,7 @@ &usdhc2 { status = "okay"; wifi@0 { - compatible = "brcm,bcm43455-fmac"; + compatible = "brcm,bcm43455-fmac", "brcm,bcm4329-fmac"; reg = <0>; }; };arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts +1
-2@@ -737,7 +737,7 @@ &usdhc1 { status = "okay"; wifi@0 { - compatible = "cypress,cyw4373-fmac"; + compatible = "cypress,cyw4373-fmac", "brcm,bcm4329-fmac"; reg = <0>; }; }; --Quoted 2 lines
2.34.1
Fabio,
Quoted 5 lines
Thank you for your continued efforts to squash out all these dt-binding warnings/issues.
Can you explain what the difference is in the dt-binding yaml between compatible/oneOf/items/{enum,const} and compatible/oneOf/enum? The
items defines a list. items with enum and const, defines a list of two items, where first is an enum (so oneOf few) and second is fixed.
compatible/oneOf/enum is not a list. Or you could look at it as one-element-list.
Quoted 16 lines
Quoted 3 lines
first list for
Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yamlhas a much larger set of enums including the bcm43455 on these boards but the second set of enums has a much more limited set.What's the question here? Both define different things. One defines compatible devices with some model, second defines just some devices.
Quoted 7 lines
There is no
driver code to look at for this because it is bound via SDIO device id's instead of the dt compatible property.Best regards,
Tim
Krzysztof,
Thanks for the explanation. I see now that if I want to specify anything other than the enums in the second item (brcm,bcm4329-fmac, and the pci14e4*), per the first item I must follow it with 'brcm,bcm4329-fmac'.
best regards,
Tim
Shawn Guo
AppliedQuoted 9 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
Pass "brcm,bcm4329-fmac" to fix the following schema warnings:
imx8mp-venice-gw74xx.dtb: wifi@0: compatible: 'oneOf' conditional failed, one must be fixed:
['cypress,cyw4373-fmac'] is too short 'cypress,cyw4373-fmac' is not one of ['brcm,bcm4329-fmac', 'pci14e4,43dc', 'pci14e4,4464', 'pci14e4,4488', 'pci14e4,4425', 'pci14e4,4433'] from schema $id: http://devicetree.org/schemas/net/wireless/brcm,bcm4329-fmac.yaml#
Quoted 6 lines
imx8mn-venice-gw7902.dtb: wifi@0: compatible: 'oneOf' conditional failed, one must be fixed:
['brcm,bcm43455-fmac'] is too short 'brcm,bcm43455-fmac' is not one of ['brcm,bcm4329-fmac', 'pci14e4,43dc', 'pci14e4,4464', 'pci14e4,4488', 'pci14e4,4425', 'pci14e4,4433'] from schema $id: http://devicetree.org/schemas/net/wireless/brcm,bcm4329-fmac.yaml#Signed-off-by Fabio Estevam <[email protected]>
Applied, thanks!