Skip to contentSkip to conversation

tpm_tis: opt-in interrupts

PATCH New Jarkko Sakkinen 1 participant 3 messages Aug 11, 2023

Subsystems (3)
lore
Share & tools
lore

Jarkko Sakkinen

author maintainer
#0 lore raw

cover tpm_tis: opt-in interrupts

Hopefully the last IRQ fixes for some time.

Jarkko Sakkinen (1):
tpm_tis: Opt-in interrupts

Peter Ujfalusi (1):
tpm: tpm_tis: Fix UPX-i11 DMI_MATCH condition

 drivers/char/tpm/tpm_tis.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Signature · 1 line
2.39.2
author maintainer
#1 lore raw

PATCH 1/2 tpm: tpm_tis: Fix UPX-i11 DMI_MATCH condition

From: Peter Ujfalusi <[email protected]>

The patch which made it to the kernel somehow changed the match condition from
DMI_MATCH(DMI_PRODUCT_NAME, "UPX-TGL01")
to
DMI_MATCH(DMI_PRODUCT_VERSION, "UPX-TGL")

Revert back to the correct match condition to disable the interrupt mode on the board.

Fixes edb13d7bb034 ("tpm: tpm_tis: Disable interrupts *only* for AEON UPX-i11")
---
 drivers/char/tpm/tpm_tis.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/char/tpm/tpm_tis.c +1 -1
index ac4daaf294a3..3c0f68b9e44f 100644
@@ -183,7 +183,7 @@ static const struct dmi_system_id tpm_tis_dmi_table[] = {
 		.ident = "UPX-TGL",
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "AAEON"),
-			DMI_MATCH(DMI_PRODUCT_VERSION, "UPX-TGL"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "UPX-TGL01"),
 		},
 	},
 	{}
Signature · 1 line
2.39.2
author maintainer
#2 lore raw

PATCH 2/2 tpm_tis: Opt-in interrupts

In reply to Jarkko Sakkinen
---
 drivers/char/tpm/tpm_tis.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/char/tpm/tpm_tis.c +1 -1
index 3c0f68b9e44f..7fa3d91042b2 100644
@@ -89,7 +89,7 @@ static inline void tpm_tis_iowrite32(u32 b, void __iomem *iobase, u32 addr)
 	tpm_tis_flush(iobase);
 }
 
-static int interrupts = -1;
+static int interrupts;
 module_param(interrupts, int, 0444);
 MODULE_PARM_DESC(interrupts, "Enable interrupts");
 
Signature · 1 line
2.39.2