Skip to contentSkip to conversation

net: veth: Page pool creation error handling for existing pools only

PATCH Applied Liang Chen 2 participants 2 messages Aug 12, 2023 – Aug 15, 2023

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Liang Chen

author
#0 lore raw

PATCH v2 1/1 net: veth: Page pool creation error handling for existing pools only

The failure handling procedure destroys page pools for all queues, including those that haven't had their page pool created yet. this patch introduces necessary adjustments to prevent potential risks and inconsistency with the error handling behavior.

Fixes 0ebab78cbcbf ("net: veth: add page_pool for page recycling")
Acked-by Jesper Dangaard Brouer <[email protected]>
Signed-off-by Liang Chen <[email protected]>

---
Changes from v1:
- add fixes tag

---
 drivers/net/veth.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/veth.c +2 -1
index 614f3e3efab0..509e901da41d 100644
@@ -1081,8 +1081,9 @@ static int __veth_napi_enable_range(struct net_device *dev, int start, int end)
 err_xdp_ring:
 	for (i--; i >= start; i--)
 		ptr_ring_cleanup(&priv->rq[i].xdp_ring, veth_ptr_free);
+	i = end;
 err_page_pool:
-	for (i = start; i < end; i++) {
+	for (i--; i >= start; i--) {
 		page_pool_destroy(priv->rq[i].page_pool);
 		priv->rq[i].page_pool = NULL;
 	}
Signature · 1 line
2.40.1
CI Applied
#1 lore raw
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:

Quoted 10 lines · On Sat, 12 Aug 2023 10:30:16 +0800 you wrote:

The failure handling procedure destroys page pools for all queues, including those that haven't had their page pool created yet. this patch introduces necessary adjustments to prevent potential risks and inconsistency with the error handling behavior.

Fixes 0ebab78cbcbf ("net: veth: add page_pool for page recycling")
Acked-by Jesper Dangaard Brouer <[email protected]>
Signed-off-by Liang Chen <[email protected]>

[...]

Here is the summary with links:
- [net-next,v2] net: veth: Page pool creation error handling for existing pools only

    https://git.kernel.org/netdev/net/c/8a519a572598

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html