Skip to contentSkip to conversation

ARM: dts: qcom: apq8960: reflect that memory node starts at offset 0

PATCH In review David Heidelberg 2 participants 3 messages Aug 12, 2023 – Jul 5, 2024

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: qcom: apq8960: reflect that memory node starts at offset 0

Fixes warning generated by make qcom-msm8960-cdp.dtb:
arch/arm/boot/dts/qcom-msm8960-cdp.dt.yaml: /: memory: False schema does not allow {'device_type': ['memory'], 'reg': [[0, 0]]}

---
 arch/arm/boot/dts/qcom/qcom-msm8960.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/qcom/qcom-msm8960.dtsi +1 -1
index c10797f3793c..c20f16845a97 100644
@@ -47,7 +47,7 @@ L2: l2-cache {
 		};
 	};
 
-	memory {
+	memory@0 {
 		device_type = "memory";
 		reg = <0x0 0x0>;
 	};
Signature · 1 line
2.40.1
#1 lore raw
Quoted 5 lines · David Heidelberg

Fixes warning generated by make qcom-msm8960-cdp.dtb:
arch/arm/boot/dts/qcom-msm8960-cdp.dt.yaml: /: memory: False schema does not allow {'device_type': ['memory'], 'reg': [[0, 0]]}

---

But does it really?

i.e., if you boot it on a device and xxd /sys/firmware/devicetree/base/memory or decompile /sys/firmware/fdt, is it updated to <0x0 0xsomesize>?

Konrad

Quoted 16 lines
 arch/arm/boot/dts/qcom/qcom-msm8960.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/qcom/qcom-msm8960.dtsi +1 -1
index c10797f3793c..c20f16845a97 100644
@@ -47,7 +47,7 @@ L2: l2-cache {
 		};
 	};
 
-	memory {
+	memory@0 {
 		device_type = "memory";
 		reg = <0x0 0x0>;
 	};
#2 lore raw

Can we get this in then?

Thanks
David

Quoted 28 lines · Konrad Dybcio
Quoted 5 lines · David Heidelberg

Fixes warning generated by make qcom-msm8960-cdp.dtb:
arch/arm/boot/dts/qcom-msm8960-cdp.dt.yaml: /: memory: False schema does not allow {'device_type': ['memory'], 'reg': [[0, 0]]}

---

But does it really?

i.e., if you boot it on a device and xxd /sys/firmware/devicetree/base/memory or decompile /sys/firmware/fdt, is it updated to <0x0 0xsomesize>?

Konrad

Quoted 16 lines
  arch/arm/boot/dts/qcom/qcom-msm8960.dtsi | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/qcom/qcom-msm8960.dtsi +1 -1
index c10797f3793c..c20f16845a97 100644
@@ -47,7 +47,7 @@ L2: l2-cache {
  		};
  	};
 
-	memory {
+	memory@0 {
  		device_type = "memory";
  		reg = <0x0 0x0>;
  	};
Signature · 1 line
David Heidelberg