Skip to contentSkip to conversation

support/scripts/gen-bootlin-toolchains: generate BR2_ARCH_NEEDS_GCC_AT_LEAST_X guard

PATCH Applied Vincent Fazio 2 participants 2 messages Aug 13, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 support/scripts/gen-bootlin-toolchains: generate BR2_ARCH_NEEDS_GCC_AT_LEAST_X guard

Previously, gen-bootlin-toolchains did not add a depends guard to limit the available toolchains based on the minimum required GCC version for the user selected CPU tuning.

Now, the proper BR2_ARCH_NEEDS_GCC_AT_LEAST_X guard will be added based on the version of GCC provided by the toolchain.

---
 support/scripts/gen-bootlin-toolchains | 2 ++
 1 file changed, 2 insertions(+)
support/scripts/gen-bootlin-toolchains +2 -0
index 23ebfbdce9..4344221213 100755
@@ -338,6 +338,8 @@ class Toolchain:
                 m = re.match("^BR2_TOOLCHAIN_EXTERNAL_GCC_([0-9_]*)=y$", frag)
                 assert m, "Cannot get gcc version for toolchain %s" % self.fname_prefix
                 selects.append("BR2_TOOLCHAIN_GCC_AT_LEAST_%s" % m[1])
+                # respect the GCC requirement for the selected CPU/arch tuning
+                depends.append("!BR2_ARCH_NEEDS_GCC_AT_LEAST_%s" % str(int(m[1]) + 1))
 
             # kernel headers version
             if frag.startswith("BR2_TOOLCHAIN_EXTERNAL_HEADERS_"):
Signature · 6 lines
2.25.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

Vincent, All,

On 2023-08-12 23:59 -0500, Vincent Fazio spake thusly:

Quoted 8 lines

Previously, gen-bootlin-toolchains did not add a depends guard to limit the available toolchains based on the minimum required GCC version for the user selected CPU tuning.

Now, the proper BR2_ARCH_NEEDS_GCC_AT_LEAST_X guard will be added based on the version of GCC provided by the toolchain.

s for the other external toolchains, this is a fix, so I applied to master.

I did regenerate the toolchains, after adding a litle temporary kludge so that the latest Bootlin toolchain version was ignored.

Applied to master, thanks.

Regards,
Yann E. MORIN.

Quoted 24 lines
---
 support/scripts/gen-bootlin-toolchains | 2 ++
 1 file changed, 2 insertions(+)
support/scripts/gen-bootlin-toolchains +2 -0
index 23ebfbdce9..4344221213 100755
@@ -338,6 +338,8 @@ class Toolchain:
                 m = re.match("^BR2_TOOLCHAIN_EXTERNAL_GCC_([0-9_]*)=y$", frag)
                 assert m, "Cannot get gcc version for toolchain %s" % self.fname_prefix
                 selects.append("BR2_TOOLCHAIN_GCC_AT_LEAST_%s" % m[1])
+                # respect the GCC requirement for the selected CPU/arch tuning
+                depends.append("!BR2_ARCH_NEEDS_GCC_AT_LEAST_%s" % str(int(m[1]) + 1))
 
             # kernel headers version
             if frag.startswith("BR2_TOOLCHAIN_EXTERNAL_HEADERS_"):
Signature · 6 lines
2.25.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Signature · 10 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot