clone.2: Fix the erroneous statement about CLONE_NEWPID
PATCH 1/1 clone.2: Fix the erroneous statement about CLONE_NEWPID
It appears like the documentation is based on out of date information in regards to using CLONE_NEWPID and CLONE_PARENT together.
For example, in this test program, one can see that it works:
static pid_t sys_clone3(struct clone_args *args)
{
fflush(stdout);
fflush(stderr);
return syscall(__NR_clone3, args, sizeof(*args));
}int main() {
struct clone_args args = {
.flags = CLONE_PARENT | CLONE_NEWPID,
};
int ret;
printf("The main program is running with pid: %d, and ppid: %d\n", getpid(), getppid());
ret = sys_clone3(&args);
assert(ret != -1);
if (ret == 0) {
printf("This is the child, running with pid: %d, and ppid: %d\n", getpid(), getppid());
_exit(0);
}
return 0;
}This test program (successfully) outputs:
The main program is running with pid: 648411, and ppid: 648397 This is the child, running with pid: 1, and ppid: 0
--- man2/clone.2 | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
man2/clone.2 +1 -3
@@ -736,9 +736,7 @@ Only a privileged process can employ .BR CLONE_NEWPID . This flag can't be specified in conjunction with -.B CLONE_THREAD -or -.BR CLONE_PARENT . +.B CLONE_THREAD. .TP .B CLONE_NEWUSER (This flag first became meaningful for
Signature · 1 line
2.39.3
Alejandro Colomar
maintainerHello Sargun,
Quoted 12 lines · Sargun Dhillon
It appears like the documentation is based on out of date information in regards to using
CLONE_NEWPIDandCLONE_PARENTtogether.For example, in this test program, one can see that it works:
static
pid_tsys_clone3(struct clone_args *args){ fflush(stdout); fflush(stderr); return syscall(__NR_clone3, args, sizeof(*args)); }
Quoted 12 lines
int main() {
struct clone_args args = {
.flags = CLONE_PARENT | CLONE_NEWPID,
};
int ret;
printf("The main program is running with pid: %d, and ppid: %d\n", getpid(), getppid());
ret = sys_clone3(&args);
assert(ret != -1);
if (ret == 0) {
printf("This is the child, running with pid: %d, and ppid: %d\n", getpid(), getppid());
_exit(0);Do we really need _exit(3)? Why not exit(3)? There are no atexit(3) or on_exit(3) handlers registered, so the only difference I expect is the flushing of stdio(3) streams, which _exit(3) doesn't perform but exit(3) does. So exit(3) seems more appropriate, isn't it?
Quoted 4 lines
} return 0; }
Thanks for the example program! It helps a lot with the review. :)
Quoted 15 lines
This test program (successfully) outputs:
The main program is running with pid: 648411, and ppid: 648397 This is the child, running with pid: 1, and ppid: 0Signed-off-by Sargun Dhillon <[email protected]>--- man2/clone.2 | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)man2/clone.2 +0
-0
man2/clone.2 Only a privileged process · line 739
Quoted 7 lines
man2/clone.2 +1
-3@@ -736,9 +736,7 @@ Only a privileged process can employ .BR CLONE_NEWPID . This flag can't be specified in conjunction with -.B CLONE_THREAD -or -.BR CLONE_PARENT . +.B CLONE_THREAD.
You'll need BR here, and the space before the period; otherwise, the period will be in bold, which we don't want (as it's not part of the identifier).
Thanks,
Alex
Quoted 3 lines
man2/clone.2 +0
-0.TP .B CLONE_NEWUSER (This flag first became meaningful for
Signature · 2 lines
<http://www.alejandro-colomar.es/> GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5
Alejandro Colomar
maintainerQuoted 33 lines · Alejandro Colomar
Hello Sargun,
Quoted 12 lines · Sargun Dhillon
It appears like the documentation is based on out of date information in regards to using
CLONE_NEWPIDandCLONE_PARENTtogether.For example, in this test program, one can see that it works:
static
pid_tsys_clone3(struct clone_args *args){ fflush(stdout); fflush(stderr); return syscall(__NR_clone3, args, sizeof(*args)); }Quoted 12 lines
int main() { struct clone_args args = { .flags = CLONE_PARENT | CLONE_NEWPID, }; int ret; printf("The main program is running with pid: %d, and ppid: %d\n", getpid(), getppid()); ret = sys_clone3(&args); assert(ret != -1); if (ret == 0) { printf("This is the child, running with pid: %d, and ppid: %d\n", getpid(), getppid()); _exit(0);Do we really need
_exit(3)? Why not exit(3)? There are no atexit(3) oron_exit(3)handlers registered, so the only difference I expect is the flushing of stdio(3) streams, which_exit(3)doesn't perform but exit(3) does. So exit(3) seems more appropriate, isn't it?
Quoted 11 lines
Quoted 4 lines
} return 0; }Thanks for the example program! It helps a lot with the review. :)
Quoted 4 lines
This test program (successfully) outputs:
The main program is running with pid: 648411, and ppid: 648397 This is the child, running with pid: 1, and ppid: 0
Does this depend on any recent kernel version? In my system, the assertion fails.
$ cat clone.c #include <assert.h> #include <linux/sched.h> #include <sched.h> #include <stdio.h> #include <sys/syscall.h> #include <unistd.h>
static pid_tsys_clone3(struct clone_args *args)
{
fflush(stdout);
fflush(stderr);
return syscall(SYS_clone3, args, sizeof(*args));
}int
main(void)
{
int ret;
struct clone_args args = { .flags = CLONE_PARENT | CLONE_NEWPID, };
printf("main program: pid: %d, and ppid: %d\n", getpid(), getppid());
ret = sys_clone3(&args);
assert(ret != -1);
if (ret == 0) {
printf("This is the child, running with pid: %d, and ppid: %d\n", getpid(), getppid());
_exit(0);
}
return 0;
}$ cc -Wall -Wextra clone.c $ ./a.out main program: pid: 18783, and ppid: 18703 a.out: clone.c:24: main: Assertion `ret != -1' failed. Aborted
Quoted 30 lines
Quoted 11 lines
Signed-off-by Sargun Dhillon <[email protected]>--- man2/clone.2 | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)man2/clone.2 +0
-0man2/clone.2 Only a privileged process · line 739
Quoted 7 lines
man2/clone.2 +1
-3@@ -736,9 +736,7 @@ Only a privileged process can employ .BR CLONE_NEWPID . This flag can't be specified in conjunction with -.B CLONE_THREAD -or -.BR CLONE_PARENT . +.B CLONE_THREAD.You'll need BR here, and the space before the period; otherwise, the period will be in bold, which we don't want (as it's not part of the identifier).
Thanks,
AlexQuoted 3 lines
man2/clone.2 +0
-0.TP .B CLONE_NEWUSER (This flag first became meaningful for
Signature · 2 lines
<http://www.alejandro-colomar.es/> GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5
Quoted 4 lines · Alejandro Colomar
Does this depend on any recent kernel version? In my system, the assertion fails.
Quoted 8 lines
$ cat clone.c ...$ cc -Wall -Wextra clone.c $ ./a.out main program: pid: 18783, and ppid: 18703 a.out: clone.c:24: main: Assertion `ret != -1' failed. Aborted
On my systerm I get the same result. strace says this:
clone3({flags=CLONE_PARENT|CLONE_NEWPID, exit_signal=0, stack=NULL, stack_size=0}, 88) = -1 EPERM (Operation not permitted)
However when running as root it works.
John.
Quoted 6 lines · John Watts
Quoted 4 lines · Alejandro Colomar
Does this depend on any recent kernel version? In my system, the assertion fails.
Quoted 8 lines
Quoted 8 lines
$ cat clone.c ...$ cc -Wall -Wextra clone.c $ ./a.out main program: pid: 18783, and ppid: 18703 a.out: clone.c:24: main: Assertion `ret != -1' failed. Aborted
It looks like this was added in 1f7f4dde5c945f41a7abc2285be43d918029ecc5 in v3.13.
Quoted 8 lines
On my systerm I get the same result. strace says this:
clone3({flags=CLONE_PARENT|CLONE_NEWPID, exit_signal=0, stack=NULL, stack_size=0}, 88)= -1 EPERM (Operation not permitted)However when running as root it works.
John.
CLONE_NEWPID requires privileges.
See:
Only a privileged process (CAP_SYS_ADMIN) can employ CLONE_NEWPID. This flag can't be specified in conjunction with CLONE_THREAD or CLONE_PARENT.
Alejandro Colomar
maintainerPATCH v2 1/1 clone.2: Fix outdated statement about CLONE_NEWPID
From: Sargun Dhillon <[email protected]>
[TO += Serge]
Hi Sargun, Serge!
Sargun, I've slightly changed your patch, to keep the historical information that in old versions of Linux this restriction was in place. I also cleaned up the example program a little bit, and fixed the formatting mistake I mentioned. See scissor patch below.
However, reading the Linux commit that changed this, I had some doubts. I've added Serge, in case he can remember the details.
Serge, I see that the commit message for (Linux) 1f7f4dde5c94 quotes some email of yours, and mentions that the commit fixes a regression. So my doubt is: was this restriction in place before v3.13 as a stable thing, or was it only accidentally introduced temporarily and soon fixed? How should we document it?
Cheers,
Alex
---8<-----
It appears like the documentation is based on out of date information in regards to using CLONE_NEWPID and CLONE_PARENT together. Since Linux v3.13, this restriction has been lifted. See commit 1f7f4dde5c94 ("fork: Allow CLONE_PARENT after setns(CLONE_NEWPID)").
For example, in this test program, one can see that it works:
#include <assert.h>
#include <err.h>
#include <linux/sched.h>
#include <sched.h>
#include <stdio.h>
#include <stdlib.h>
#include <sys/syscall.h>
#include <unistd.h>
static pid_t sys_clone3(struct clone_args *args);
int
main(void)
{
int ret;
struct clone_args args = {
.flags = CLONE_PARENT | CLONE_NEWPID,
};
printf("main program: pid: %d, and ppid: %d\n", getpid(), getppid());
ret = sys_clone3(&args);
switch (ret) {
case -1:
err(EXIT_FAILURE, "clone3");
case 0:
printf("child: pid: %d, and ppid: %d\n", getpid(), getppid());
exit(EXIT_SUCCESS);
default:
exit(EXIT_SUCCESS);
}
}static pid_tsys_clone3(struct clone_args *args)
{
fflush(stdout);
fflush(stderr);
return syscall(SYS_clone3, args, sizeof(*args));
}This test program (successfully) outputs:
# ./a.out
main program: pid: 34663, and ppid: 34662
child: pid: 1, and ppid: 0---
man2/clone.2 | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
man2/clone.2 +5 -3
@@ -736,9 +736,11 @@ .SS The flags mask can employ .BR CLONE_NEWPID . This flag can't be specified in conjunction with -.B CLONE_THREAD -or -.BR CLONE_PARENT . +.BR CLONE_THREAD . +Before Linux 3.13, +this flag couldn't be specified in conjunction with +.B CLONE_PARENT +either. .TP .B CLONE_NEWUSER (This flag first became meaningful for
Signature · 1 line
2.40.1
Re: [PATCH v2] clone.2: Fix outdated statement about CLONE_NEWPID
Quoted 93 lines · Alejandro Colomar
From: Sargun Dhillon <[email protected]>
[TO += Serge]
Hi Sargun, Serge!
Sargun, I've slightly changed your patch, to keep the historical information that in old versions of Linux this restriction was in place. I also cleaned up the example program a little bit, and fixed the formatting mistake I mentioned. See scissor patch below.
However, reading the Linux commit that changed this, I had some doubts. I've added Serge, in case he can remember the details.
Serge, I see that the commit message for (Linux)
1f7f4dde5c94quotes some email of yours, and mentions that the commit fixes a regression. So my doubt is: was this restriction in place before v3.13 as a stable thing, or was it only accidentally introduced temporarily and soon fixed? How should we document it?Cheers,
Alex---8<-----
It appears like the documentation is based on out of date information in regards to using
CLONE_NEWPIDandCLONE_PARENTtogether. Since Linux v3.13, this restriction has been lifted. See commit1f7f4dde5c94("fork: AllowCLONE_PARENTaftersetns(CLONE_NEWPID)").For example, in this test program, one can see that it works:
#include <
assert.h>
#include <err.h>
#include <linux/sched.h>
#include <sched.h>
#include <stdio.h>
#include <stdlib.h>
#include <sys/syscall.h>
#include <unistd.h>static
pid_tsys_clone3(struct clone_args *args);int
main(void){ int ret; struct clone_args args = { .flags = CLONE_PARENT | CLONE_NEWPID, }; printf("main program: pid: %d, and ppid: %d\n", getpid(), getppid()); ret = sys_clone3(&args); switch (ret) { case -1: err(EXIT_FAILURE, "clone3"); case 0: printf("child: pid: %d, and ppid: %d\n", getpid(), getppid()); exit(EXIT_SUCCESS); default: exit(EXIT_SUCCESS); } }static
pid_tsys_clone3(struct clone_args *args){ fflush(stdout); fflush(stderr); return syscall(SYS_clone3, args, sizeof(*args)); }This test program (successfully) outputs:
# ./a.out main program: pid: 34663, and ppid: 34662 child: pid: 1, and ppid: 0Cowritten-by Sargun Dhillon <[email protected]>Cc Serge Hallyn <[email protected]>Cc John Watts <[email protected]>Signed-off-by Alejandro Colomar <[email protected]>---
man2/clone.2 | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)man2/clone.2 +0
-0
man2/clone.2 .SS The flags mask · line 742
Quoted 10 lines
man2/clone.2 +4
-3@@ -736,9 +736,11 @@ .SS The flags mask can employ .BR CLONE_NEWPID . This flag can't be specified in conjunction with -.B CLONE_THREAD -or -.BR CLONE_PARENT . +.BR CLONE_THREAD . +Before Linux 3.13, +this flag couldn't be specified in conjunction with +.B CLONE_PARENT
Well no, I don't think that's right. That implies that the CLONE_PARENT check was a long standing one. In fact, the point was that it was a regression introduced in
40a0d32d1 (Wed Sep 11 14:19:41 2013 -0700)
and then fixed in 1f7f4dde5 two months later.
Quoted 6 lines
man2/clone.2 +1
-0+either. .TP .B CLONE_NEWUSER (This flag first became meaningful forSignature · 1 line
2.40.1
Alejandro Colomar
maintainerRe: [PATCH v2] clone.2: Fix outdated statement about CLONE_NEWPID
Hi Serge,
On 2023-08-13 15:35, Serge E. Hallyn wrote:
[...]
Quoted 8 lines
Well no, I don't think that's right. That implies that the
CLONE_PARENTcheck was a long standing one. In fact, the point was that it was a regression introduced in
40a0d32d1(Wed Sep 11 14:19:41 2013 -0700)and then fixed in
1f7f4dde5two months later.
Thanks! I'll rewrite the commit accordingly (more like Sargun's v1) and include this info.
Cheers,
Alex
Quoted 7 lines
Quoted 7 lines
+either.
.TP
.BCLONE_NEWUSER
(This flag first became meaningful forSignature · 1 line
2.40.1
Signature · 2 lines
<http://www.alejandro-colomar.es/> GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5
Re: [PATCH v2] clone.2: Fix outdated statement about CLONE_NEWPID
Quoted 10 lines · Alejandro Colomar
Hi Serge,
On 2023-08-13 15:35, Serge E. Hallyn wrote:
[...]Quoted 5 lines
Well no, I don't think that's right. That implies that the
CLONE_PARENTcheck was a long standing one. In fact, the point was that it was a regression introduced in
Quoted 6 lines
Quoted 3 lines
40a0d32d1(Wed Sep 11 14:19:41 2013 -0700)and then fixed in
1f7f4dde5two months later.Thanks! I'll rewrite the commit accordingly (more like Sargun's v1) and include this info.
Thanks :)
-serge
Alejandro Colomar
maintainerPATCH v3 1/1 clone.2: Fix erroneous statement about CLONE_NEWPID|CLONE_PARENT
In reply to Sargun DhillonFrom: Sargun Dhillon <[email protected]>
CLONE_NEWPID|CLONE_PARENT was only prohibited during a short period. That prohibition was introduced in Linux 3.12, in commit 40a0d32d1eaf ("fork: unify and tighten up CLONE_NEWUSER/CLONE_NEWPID checks"), but was a regression, and was fixed in Linux 3.13, in commit 1f7f4dde5c94 ("fork: Allow CLONE_PARENT after setns(CLONE_NEWPID)").
In this test program, one can see that it works:
#include <err.h>
#include <linux/sched.h>
#include <sched.h>
#include <stdio.h>
#include <stdlib.h>
#include <sys/syscall.h>
#include <unistd.h>
static pid_t sys_clone3(struct clone_args *args);
int
main(void)
{
int ret;
struct clone_args args = {
.flags = CLONE_PARENT | CLONE_NEWPID,
};
printf("main program: pid: %d, and ppid: %d\n", getpid(), getppid());
ret = sys_clone3(&args);
switch (ret) {
case -1:
err(EXIT_FAILURE, "clone3");
case 0:
printf("child: pid: %d, and ppid: %d\n", getpid(), getppid());
exit(EXIT_SUCCESS);
default:
exit(EXIT_SUCCESS);
}
}static pid_tsys_clone3(struct clone_args *args)
{
fflush(stdout);
fflush(stderr);
return syscall(SYS_clone3, args, sizeof(*args));
}This test program (successfully) outputs:
# ./a.out
main program: pid: 34663, and ppid: 34662
child: pid: 1, and ppid: 0--- man2/clone.2 | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
man2/clone.2 +1 -3
@@ -736,9 +736,7 @@ .SS The flags mask can employ .BR CLONE_NEWPID . This flag can't be specified in conjunction with -.B CLONE_THREAD -or -.BR CLONE_PARENT . +.BR CLONE_THREAD . .TP .B CLONE_NEWUSER (This flag first became meaningful for
Signature · 1 line
2.40.1
Alejandro Colomar
maintainerRe: [PATCH v3] clone.2: Fix erroneous statement about CLONE_NEWPID|CLONE_PARENT
On 2023-08-13 15:55, Alejandro Colomar wrote:
[...]
Quoted 9 lines
--- man2/clone.2 | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)man2/clone.2 +0
-0
man2/clone.2 .SS The flags mask · line 742
Quoted 10 lines
man2/clone.2 +1
-3@@ -736,9 +736,7 @@ .SS The flags mask can employ .BR CLONE_NEWPID . This flag can't be specified in conjunction with -.B CLONE_THREAD -or -.BR CLONE_PARENT . +.BR CLONE_THREAD . .TP .B CLONE_NEWUSER (This flag first became meaningful for
Hmm, it seems this patch was incomplete. This is a reminder that we should specify 'Fixes: ...commit...' for these fixes as much as possible. Doing that, I found that the commit that it fixes did more than that, and we need to fix those places too. :)
I'll prepare a v4 reverting that patch entirely.
Cheers,
Alex
$ git show f00071920e commit f00071920ec3ff5ed3ae2a8933259c535aae15a6 Author: Michael Kerrisk <[email protected]> Date: Tue Mar 5 09:55:39 2013 +0100
clone.2: EINVAL if (CLONE_NEWUSER|CLONE_NEWPID) && (CLONE_THREAD|CLONE_PARENT)
man2/clone.2 +15 -3
@@ -407,7 +407,9 @@ .SH DESCRIPTION can employ .BR CLONE_NEWPID . This flag can't be specified in conjunction with -.BR CLONE_THREAD . +.BR CLONE_THREAD +or +.BR CLONE_PARENT . .TP .BR CLONE_NEWUSER (This flag first became meaningful for
@@ -441,6 +443,12 @@ .SH DESCRIPTION .\" Before Linux 2.6.29, it appears that only CAP_SYS_ADMIN was needed Starting with Linux 3.8, no privileges are needed to create a user namespace. + +.BR CLONE_NEWUSER +cannot be specified in conjunction with +.BR CLONE_NEWPID +or +.BR CLONE_PARENT . .TP .BR CLONE_NEWUTS " (since Linux 2.6.19)" If
@@ -895,10 +903,14 @@ .SH ERRORS .IR flags . .TP .B EINVAL -Both +One (or both) of .BR CLONE_NEWPID -and +or +.BR CLONE_NEWUSER +and one (or both) of .BR CLONE_THREAD +or +.BR CLONE_PARENT were specified in .IR flags . .TP
Signature · 2 lines
<http://www.alejandro-colomar.es/> GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5
Re: [PATCH v3] clone.2: Fix erroneous statement about CLONE_NEWPID|CLONE_PARENT
In reply to Alejandro ColomarQuoted 50 lines · Alejandro Colomar
From: Sargun Dhillon <[email protected]>
CLONE_NEWPID|CLONE_PARENT was only prohibited during a short period. That prohibition was introduced in Linux 3.12, in commit
40a0d32d1eaf("fork: unify and tighten up CLONE_NEWUSER/CLONE_NEWPID checks"), but was a regression, and was fixed in Linux 3.13, in commit1f7f4dde5c94("fork: AllowCLONE_PARENTaftersetns(CLONE_NEWPID)").In this test program, one can see that it works:
#include <
err.h>
#include <linux/sched.h>
#include <sched.h>
#include <stdio.h>
#include <stdlib.h>
#include <sys/syscall.h>
#include <unistd.h>static
pid_tsys_clone3(struct clone_args *args);int
main(void){ int ret; struct clone_args args = { .flags = CLONE_PARENT | CLONE_NEWPID, }; printf("main program: pid: %d, and ppid: %d\n", getpid(), getppid()); ret = sys_clone3(&args); switch (ret) { case -1: err(EXIT_FAILURE, "clone3"); case 0: printf("child: pid: %d, and ppid: %d\n", getpid(), getppid()); exit(EXIT_SUCCESS); default: exit(EXIT_SUCCESS); } }static
pid_tsys_clone3(struct clone_args *args){ fflush(stdout); fflush(stderr); return syscall(SYS_clone3, args, sizeof(*args)); }
Quoted 8 lines
This test program (successfully) outputs:
# ./a.out main program: pid: 34663, and ppid: 34662 child: pid: 1, and ppid: 0Cowritten-by Sargun Dhillon <[email protected]>Cc Serge Hallyn <[email protected]>
Quoted 23 lines
Cc John Watts <[email protected]>Signed-off-by Alejandro Colomar <[email protected]>--- man2/clone.2 | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)man2/clone.2 +1
-3@@ -736,9 +736,7 @@ .SS The flags mask can employ .BR CLONE_NEWPID . This flag can't be specified in conjunction with -.B CLONE_THREAD -or -.BR CLONE_PARENT . +.BR CLONE_THREAD . .TP .B CLONE_NEWUSER (This flag first became meaningful forSignature · 1 line
2.40.1
Alejandro Colomar
maintainerRe: [PATCH v3] clone.2: Fix erroneous statement about CLONE_NEWPID|CLONE_PARENT
Hi Sargun, Serge,
Quoted 1 line · Serge E. Hallyn
Quoted 1 line
Cowritten-by Sargun Dhillon <[email protected]>
Sargun, would you please sign the patch?
Quoted 3 lines
Quoted 1 line
Cc Serge Hallyn <[email protected]>Reviewed-by Serge Hallyn <[email protected]>
Thanks!
Cheers,
Alex
Quoted 4 lines
Quoted 4 lines
Cc John Watts <[email protected]>Signed-off-by Alejandro Colomar <[email protected]>---
Signature · 2 lines
<http://www.alejandro-colomar.es/> GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5
Alejandro Colomar
maintainerRe: [PATCH v3] clone.2: Fix erroneous statement about CLONE_NEWPID|CLONE_PARENT
Quoted 10 lines · Alejandro Colomar
Hi Sargun, Serge,
Quoted 1 line · Serge E. Hallyn
Quoted 1 line
Cowritten-by Sargun Dhillon <[email protected]>Sargun, would you please sign the patch?
Quoted 3 lines
Quoted 1 line
Cc Serge Hallyn <[email protected]>Reviewed-by Serge Hallyn <[email protected]>
Oops, I just realized that I accidentally pushed the patch to <kernel.org> a few minutes ago. I can't add your tag :(
Cheers,
Alex
Quoted 10 lines
Thanks!
Cheers,
AlexQuoted 4 lines
Quoted 4 lines
Cc John Watts <[email protected]>Signed-off-by Alejandro Colomar <[email protected]>---
Signature · 2 lines
<http://www.alejandro-colomar.es/> GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5
Alejandro Colomar
maintainerPATCH v4 1/1 clone.2: Fix erroneous statement about CLONE_NEWPID|CLONE_PARENT
In reply to Sargun DhillonFrom: Sargun Dhillon <[email protected]>
CLONE_NEWPID|CLONE_PARENT was only prohibited during a short period. That prohibition was introduced in Linux 3.12, in commit 40a0d32d1eaf ("fork: unify and tighten up CLONE_NEWUSER/CLONE_NEWPID checks"), but was a regression, and was fixed in Linux 3.13, in commit 1f7f4dde5c94 ("fork: Allow CLONE_PARENT after setns(CLONE_NEWPID)").
In this test program, one can see that it works:
#include <err.h>
#include <linux/sched.h>
#include <sched.h>
#include <stdio.h>
#include <stdlib.h>
#include <sys/syscall.h>
#include <unistd.h>
static pid_t sys_clone3(struct clone_args *args);
int
main(void)
{
int ret;
struct clone_args args = {
.flags = CLONE_PARENT | CLONE_NEWPID,
};
printf("main program: pid: %d, and ppid: %d\n", getpid(), getppid());
ret = sys_clone3(&args);
switch (ret) {
case -1:
err(EXIT_FAILURE, "clone3");
case 0:
printf("child: pid: %d, and ppid: %d\n", getpid(), getppid());
exit(EXIT_SUCCESS);
default:
exit(EXIT_SUCCESS);
}
}static pid_tsys_clone3(struct clone_args *args)
{
fflush(stdout);
fflush(stderr);
return syscall(SYS_clone3, args, sizeof(*args));
}This test program (successfully) outputs:
# ./a.out
main program: pid: 34663, and ppid: 34662
child: pid: 1, and ppid: 0--- man2/clone.2 | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-)
man2/clone.2 +9 -6
@@ -729,23 +729,21 @@ .SS The flags mask For further information on PID namespaces, see .BR namespaces (7) and .BR pid_namespaces (7). .IP Only a privileged process .RB ( CAP_SYS_ADMIN ) can employ .BR CLONE_NEWPID . This flag can't be specified in conjunction with -.B CLONE_THREAD -or -.BR CLONE_PARENT . +.BR CLONE_THREAD . .TP .B CLONE_NEWUSER (This flag first became meaningful for .BR clone () in Linux 2.6.23, the current .BR clone () semantics were merged in Linux 3.5, and the final pieces to make the user namespaces completely usable were merged in Linux 3.8.)
@@ -1310,32 +1308,37 @@ .SH ERRORS .B EINVAL Both .B CLONE_NEWIPC and .B CLONE_SYSVSEM were specified in the .I flags mask. .TP .B EINVAL -One (or both) of .B CLONE_NEWPID -or -.B CLONE_NEWUSER and one (or both) of .B CLONE_THREAD or .B CLONE_PARENT were specified in the .I flags mask. .TP +.B EINVAL +.B CLONE_NEWUSER +and +.B CLONE_THREAD +were specified in the +.I flags +mask. +.TP .BR EINVAL " (since Linux 2.6.32)" .\" commit 123be07b0b399670a7cc3d82fef0cb4f93ef885c .B CLONE_PARENT was specified, and the caller is an init process. .TP .B EINVAL Returned by the glibc .BR clone () wrapper function when .I fn
Signature · 1 line
2.40.1