Skip to contentSkip to conversation

selftests/bpf: clean-up fmod_ret in bench_rename test script

bpf-next Applied Yipeng Zou 2 participants 2 messages Aug 14, 2023

Subsystems (3)
lore
Share & tools
lore

Yipeng Zou

author
#0 lore raw

[root@localhost bpf]# ./benchs/run_bench_rename.sh

base      :    0.819 ± 0.012M/s
kprobe    :    0.538 ± 0.009M/s
kretprobe :    0.503 ± 0.004M/s
rawtp     :    0.779 ± 0.020M/s
fentry    :    0.726 ± 0.007M/s
fexit     :    0.691 ± 0.007M/s

benchmark 'rename-fmodret' not found

The bench_rename_fmod_ret has been removed in the commit [1], clean-up it in test script.

[1] b000def2e052 ("selftests: Remove fmod_ret from test_overhead").

Fixes b000def2e052 ("selftests: Remove fmod_ret from test_overhead")
---
 tools/testing/selftests/bpf/benchs/run_bench_rename.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/bpf/benchs/run_bench_rename.sh +1 -1
index 16f774b1cdbe..7b281dbe4165 100755
@@ -2,7 +2,7 @@
 
 set -eufo pipefail
 
-for i in base kprobe kretprobe rawtp fentry fexit fmodret
+for i in base kprobe kretprobe rawtp fentry fexit
 do
 	summary=$(sudo ./bench -w2 -d5 -a rename-$i | tail -n1 | cut -d'(' -f1 | cut -d' ' -f3-)
 	printf "%-10s: %s\n" $i "$summary"
Signature · 1 line
2.34.1
#1 lore raw
This patch was applied to bpf/bpf-next.git (master) by Daniel Borkmann <[email protected]>:

Hello:

This patch was applied to bpf/bpf-next.git (master) by Daniel Borkmann <[email protected]>:

Quoted 10 lines · On Mon, 14 Aug 2023 11:07:27 +0800 you wrote:

[root@localhost bpf]# ./benchs/run_bench_rename.sh

base      :    0.819 ± 0.012M/s
kprobe    :    0.538 ± 0.009M/s
kretprobe :    0.503 ± 0.004M/s
rawtp     :    0.779 ± 0.020M/s
fentry    :    0.726 ± 0.007M/s
fexit     :    0.691 ± 0.007M/s

benchmark 'rename-fmodret' not found

[...]

Here is the summary with links:
- [bpf-next] selftests/bpf: clean-up fmod_ret in bench_rename test script

    https://git.kernel.org/bpf/bpf-next/c/83a89c4b6ae9

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html