Introduce Intel Tangier pinctrl driver
cover Introduce Intel Tangier pinctrl driver
Merrifield and Moorefield pinctrl driver implementations are similar in terms of how they access the hardware. We can consolidate their pinctrl functionalities into a common library driver.
This patch set introduces:
1. Intel Tangier driver that supports the common pinctrl functionalities for Merrifield and Moorefield platforms.
2. Intel Tangier adaptation for Merrifield pinctrl driver.
3. Intel Tangier adaptation for Moorefield pinctrl driver.
Tested on Intel Edison platform.
No deviation observed in the contents of below entries before and after this patchset.
- /proc/interrupts
- /sys/kernel/debug/gpio
- /sys/kernel/debug/pinctrl/*/pins
Raag Jadav (3):
pinctrl: tangier: Introduce Intel Tangier driver
pinctrl: merrifield: Adapt to Intel Tangier driver
pinctrl: moorefield: Adapt to Intel Tangier driver
drivers/pinctrl/intel/Kconfig | 23 +- drivers/pinctrl/intel/Kconfig.tng | 33 + drivers/pinctrl/intel/Makefile | 1 + drivers/pinctrl/intel/pinctrl-merrifield.c | 677 +-------------------- drivers/pinctrl/intel/pinctrl-moorefield.c | 640 +------------------ drivers/pinctrl/intel/pinctrl-tangier.c | 589 ++++++++++++++++++ drivers/pinctrl/intel/pinctrl-tangier.h | 92 +++ 7 files changed, 778 insertions(+), 1277 deletions(-) create mode 100644 drivers/pinctrl/intel/Kconfig.tng create mode 100644 drivers/pinctrl/intel/pinctrl-tangier.c create mode 100644 drivers/pinctrl/intel/pinctrl-tangier.h
Signature · 1 line
2.17.1
PATCH 1/3 pinctrl: tangier: Introduce Intel Tangier driver
Intel Tangier implements the common pinctrl functionalities for Merrifield and Moorefield platforms.
--- drivers/pinctrl/intel/Kconfig | 1 + drivers/pinctrl/intel/Kconfig.tng | 17 + drivers/pinctrl/intel/Makefile | 1 + drivers/pinctrl/intel/pinctrl-tangier.c | 589 ++++++++++++++++++++++++ drivers/pinctrl/intel/pinctrl-tangier.h | 92 ++++ 5 files changed, 700 insertions(+) create mode 100644 drivers/pinctrl/intel/Kconfig.tng create mode 100644 drivers/pinctrl/intel/pinctrl-tangier.c create mode 100644 drivers/pinctrl/intel/pinctrl-tangier.h
drivers/pinctrl/intel/Kconfig +1 -0
@@ -187,4 +187,5 @@ config PINCTRL_TIGERLAKE This pinctrl driver provides an interface that allows configuring of Intel Tiger Lake PCH pins and using them as GPIOs. +source "drivers/pinctrl/intel/Kconfig.tng" endmenu
drivers/pinctrl/intel/Kconfig.tng new file +17 -0
@@ -0,0 +1,17 @@ +# SPDX-License-Identifier: GPL-2.0-only +# Intel Tangier and compatible pin control drivers + +if X86_INTEL_MID || COMPILE_TEST + +config PINCTRL_TANGIER + tristate + select PINMUX + select PINCONF + select GENERIC_PINCONF + help + This is a library driver for Intel Tangier pin controller and to + be selected and used by respective compatible platform drivers. + + If built as a module its name will be pinctrl-tangier. + +endif
drivers/pinctrl/intel/Makefile +1 -0
@@ -4,6 +4,7 @@ obj-$(CONFIG_PINCTRL_BAYTRAIL) += pinctrl-baytrail.o obj-$(CONFIG_PINCTRL_CHERRYVIEW) += pinctrl-cherryview.o obj-$(CONFIG_PINCTRL_LYNXPOINT) += pinctrl-lynxpoint.o +obj-$(CONFIG_PINCTRL_TANGIER) += pinctrl-tangier.o obj-$(CONFIG_PINCTRL_MERRIFIELD) += pinctrl-merrifield.o obj-$(CONFIG_PINCTRL_MOOREFIELD) += pinctrl-moorefield.o obj-$(CONFIG_PINCTRL_INTEL) += pinctrl-intel.o
drivers/pinctrl/intel/pinctrl-tangier.c new file +589 -0
589 lines not on this page · raw message
drivers/pinctrl/intel/pinctrl-tangier.h new file +92 -0
92 lines not on this page · raw message
Signature · 1 line
2.17.1
PATCH 2/3 pinctrl: merrifield: Adapt to Intel Tangier driver
In reply to Raag JadavMake use of Intel Tangier as a library driver for Merrifield.
--- drivers/pinctrl/intel/Kconfig | 11 - drivers/pinctrl/intel/Kconfig.tng | 8 + drivers/pinctrl/intel/pinctrl-merrifield.c | 677 +-------------------- 3 files changed, 41 insertions(+), 655 deletions(-)
drivers/pinctrl/intel/Kconfig +0 -11
@@ -36,17 +36,6 @@ config PINCTRL_LYNXPOINT provides an interface that allows configuring of PCH pins and using them as GPIOs. -config PINCTRL_MERRIFIELD - tristate "Intel Merrifield pinctrl driver" - depends on X86_INTEL_MID - select PINMUX - select PINCONF - select GENERIC_PINCONF - help - Merrifield Family-Level Interface Shim (FLIS) driver provides an - interface that allows configuring of SoC pins and using them as - GPIOs. - config PINCTRL_MOOREFIELD tristate "Intel Moorefield pinctrl driver" depends on X86_INTEL_MID
drivers/pinctrl/intel/Kconfig.tng +8 -0
@@ -14,4 +14,12 @@ config PINCTRL_TANGIER If built as a module its name will be pinctrl-tangier. +config PINCTRL_MERRIFIELD + tristate "Intel Merrifield pinctrl driver" + select PINCTRL_TANGIER + help + Intel Merrifield Family-Level Interface Shim (FLIS) driver provides + an interface that allows configuring of SoC pins and using them as + GPIOs. + endif
drivers/pinctrl/intel/pinctrl-merrifield.c +33 -644
708 lines not on this page · raw message
Signature · 1 line
2.17.1
PATCH 3/3 pinctrl: moorefield: Adapt to Intel Tangier driver
In reply to Raag JadavMake use of Intel Tangier as a library driver for Moorefield.
--- drivers/pinctrl/intel/Kconfig | 11 - drivers/pinctrl/intel/Kconfig.tng | 8 + drivers/pinctrl/intel/pinctrl-moorefield.c | 640 +-------------------- 3 files changed, 37 insertions(+), 622 deletions(-)
drivers/pinctrl/intel/Kconfig +0 -11
@@ -36,17 +36,6 @@ config PINCTRL_LYNXPOINT provides an interface that allows configuring of PCH pins and using them as GPIOs. -config PINCTRL_MOOREFIELD - tristate "Intel Moorefield pinctrl driver" - depends on X86_INTEL_MID - select PINMUX - select PINCONF - select GENERIC_PINCONF - help - Moorefield Family-Level Interface Shim (FLIS) driver provides an - interface that allows configuring of SoC pins and using them as - GPIOs. - config PINCTRL_INTEL tristate select PINMUX
drivers/pinctrl/intel/Kconfig.tng +8 -0
@@ -22,4 +22,12 @@ config PINCTRL_MERRIFIELD an interface that allows configuring of SoC pins and using them as GPIOs. +config PINCTRL_MOOREFIELD + tristate "Intel Moorefield pinctrl driver" + select PINCTRL_TANGIER + help + Intel Moorefield Family-Level Interface Shim (FLIS) driver provides + an interface that allows configuring of SoC pins and using them as + GPIOs. + endif
drivers/pinctrl/intel/pinctrl-moorefield.c +29 -611
670 lines not on this page · raw message
Signature · 1 line
2.17.1
Quoted 13 lines · Raag Jadav
Merrifield and Moorefield pinctrl driver implementations are similar in terms of how they access the hardware. We can consolidate their pinctrl functionalities into a common library driver.
This patch set introduces:
1. Intel Tangier driver that supports the common pinctrl functionalities for Merrifield and Moorefield platforms.
2. Intel Tangier adaptation for Merrifield pinctrl driver.
3. Intel Tangier adaptation for Moorefield pinctrl driver.
Quoted 7 lines
Tested on Intel Edison platform.
No deviation observed in the contents of below entries before and after this patchset.-
/proc/interrupts
-/sys/kernel/debug/gpio
-/sys/kernel/debug/pinctrl/*/pins
Pushed to my review and testing queue, thanks!
Signature · 2 lines
With Best Regards, Andy Shevchenko