dma: dmatest: Use div64_s64
PATCH 1/1 dma: dmatest: Use div64_s64
From: Rajeshwar R Shinde <[email protected]>
In the function do_div, the dividend is evaluated multiple times so it can cause side effects. Therefore replace it with div64_s64.
This fixes warning such as:
drivers/dma/dmatest.c:496:1-7:
WARNING: do_div() does a 64-by-32 division,
please consider using div64_s64 instead.
Signed-off-by Rajeshwar R Shinde <[email protected]>
--- drivers/dma/dmatest.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/dma/dmatest.c +2 -1
@@ -9,6 +9,7 @@#include <linux/err.h> #include <linux/delay.h> +#include <linux/math64.h> #include <linux/dma-mapping.h> #include <linux/dmaengine.h> #include <linux/freezer.h>
@@ -493,7 +494,7 @@ static unsigned long long dmatest_persec(s64 runtime, unsigned int val) per_sec *= val; per_sec =INT_TO_FIXPT (per_sec); -do_div (per_sec, runtime); + per_sec=div64_s64 (per_sec, runtime);return per_sec; }
Signature · 6 lines
2.25.1 _______________________________________________ Linux-kernel-mentees mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees