lib/vsprintf: Rework header inclusions
Subsystems (4)
Andy Shevchenko
reviewerv3 cover lib/vsprintf: Rework header inclusions
Some patches that reduce the mess with the header inclusions related to vsprintf.c module. Each patch has its own description, and has no dependencies to each other, except the collisions over modifications of the same places. Hence the series.
Changelog v3:
- dropped sorting headers patch (Petr)
- added tag (Marco)
Changelog v2:
- covered test_printf.c in patches 1 & 2
- do not remove likely implict inclusions (Rasmus)
- declare no_hash_pointers in sprintf.h (Marco, Steven, Rasmus)
Andy Shevchenko (2):
lib/vsprintf: Split out sprintf() and friends lib/vsprintf: Declare no_hash_pointers in sprintf.h
include/linux/kernel.h | 30 +----------------------------- include/linux/sprintf.h | 27 +++++++++++++++++++++++++++ lib/test_printf.c | 3 +-- lib/vsprintf.c | 1 + mm/kfence/report.c | 3 +-- 5 files changed, 31 insertions(+), 33 deletions(-) create mode 100644 include/linux/sprintf.h
Signature · 1 line
2.40.0.1.gaa8946217a0b
Andy Shevchenko
reviewerPATCH v3 1/2 lib/vsprintf: Split out sprintf() and friends
kernel.h is being used as a dump for all kinds of stuff for a long time. sprintf() and friends are used in many drivers without need of the full kernel.h dependency train with it.
Here is the attempt on cleaning it up by splitting out sprintf() and friends.
--- include/linux/kernel.h | 30 +----------------------------- include/linux/sprintf.h | 25 +++++++++++++++++++++++++ lib/test_printf.c | 1 + lib/vsprintf.c | 1 + 4 files changed, 28 insertions(+), 29 deletions(-) create mode 100644 include/linux/sprintf.h
include/linux/kernel.h +1 -29
@@ -29,6 +29,7 @@#include <linux/panic.h> #include <linux/printk.h> #include <linux/build_bug.h> +#include <linux/sprintf.h> #include <linux/static_call_types.h> #include <linux/instruction_pointer.h> #include <asm/byteorder.h>
@@ -203,35 +204,6 @@ static inline void might_fault(void) { }void do_exit (long error_code)__noreturn ; -extern int num_to_str(char *buf, int size, - unsigned long long num, unsigned int width); - -/* lib/printf utilities */ - -extern __printf(2, 3) int sprintf(char *buf, const char * fmt, ...); -extern __printf(2, 0) int vsprintf(char *buf, const char *, va_list); -extern __printf(3, 4) -int snprintf(char *buf, size_t size, const char *fmt, ...); -extern __printf(3, 0) -int vsnprintf(char *buf, size_t size, const char *fmt, va_list args); -extern __printf(3, 4) -int scnprintf(char *buf, size_t size, const char *fmt, ...); -extern __printf(3, 0) -int vscnprintf(char *buf, size_t size, const char *fmt, va_list args); -extern __printf(2, 3) __malloc -char *kasprintf(gfp_t gfp, const char *fmt, ...); -extern __printf(2, 0) __malloc -char *kvasprintf(gfp_t gfp, const char *fmt, va_list args); -extern __printf(2, 0) -const char *kvasprintf_const(gfp_t gfp, const char *fmt, va_list args); - -extern __scanf(2, 3) -int sscanf(const char *, const char *, ...); -extern __scanf(2, 0) -int vsscanf(const char *, const char *, va_list); - -extern int no_hash_pointers_enable(char *str); -extern int get_option (char **str,int *pint);extern char *get_options (const char *str,int nints,int *ints);extern unsigned long long memparse (const char *ptr,char **retptr);
include/linux/sprintf.h new file +25 -0
@@ -0,0 +1,25 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef _LINUX_KERNEL_SPRINTF_H_ +#define _LINUX_KERNEL_SPRINTF_H_ + +#include <linux/compiler_attributes.h> +#include <linux/types.h> + +int num_to_str (char *buf,int size,unsigned long long num,unsigned int width); + +__printf(2, 3) int sprintf(char *buf, const char * fmt, ...); +__printf(2, 0) int vsprintf(char *buf, const char *, va_list); +__printf(3, 4) int snprintf(char *buf, size_t size, const char *fmt, ...); +__printf(3, 0) int vsnprintf(char *buf, size_t size, const char *fmt, va_list args); +__printf(3, 4) int scnprintf(char *buf, size_t size, const char *fmt, ...); +__printf(3, 0) int vscnprintf(char *buf, size_t size, const char *fmt, va_list args); +__printf(2, 3) __malloc char *kasprintf(gfp_t gfp, const char *fmt, ...); +__printf(2, 0) __malloc char *kvasprintf(gfp_t gfp, const char *fmt, va_list args); +__printf(2, 0) const char *kvasprintf_const(gfp_t gfp, const char *fmt, va_list args); + +__scanf(2, 3) int sscanf(const char *, const char *, ...); +__scanf(2, 0) int vsscanf(const char *, const char *, va_list); + +int no_hash_pointers_enable (char *str); + +#endif /* _LINUX_KERNEL_SPRINTF_H */
lib/test_printf.c +1 -0
@@ -12,6 +12,7 @@#include <linux/random.h> #include <linux/rtc.h> #include <linux/slab.h> +#include <linux/sprintf.h> #include <linux/string.h> #include <linux/bitmap.h>
lib/vsprintf.c +1 -0
@@ -34,6 +34,7 @@#include <linux/dcache.h> #include <linux/cred.h> #include <linux/rtc.h> +#include <linux/sprintf.h> #include <linux/time.h> #include <linux/uuid.h> #include <linux/of.h>
Signature · 1 line
2.40.0.1.gaa8946217a0b
Re: [PATCH v3 1/2] lib/vsprintf: Split out sprintf() and friends
Quoted 8 lines · Andy Shevchenko
kernel.his being used as a dump for all kinds of stuff for a long time.sprintf()and friends are used in many drivers without need of the fullkernel.hdependency train with it.Here is the attempt on cleaning it up by splitting out
sprintf()and friends.Signed-off-by Andy Shevchenko <[email protected]>
Best Regards,
Petr
Andy Shevchenko
reviewerPATCH v3 2/2 lib/vsprintf: Declare no_hash_pointers in sprintf.h
In reply to Andy ShevchenkoSparse is not happy to see non-static variable without declaration:lib/vsprintf.c:61:6: warning: symbol 'no_hash_pointers' was not declared. Should it be static?
Declare respective variable in the sprintf.h. With this, add a comment to discourage its use if no real need.
--- include/linux/sprintf.h | 2 ++ lib/test_printf.c | 2 -- mm/kfence/report.c | 3 +-- 3 files changed, 3 insertions(+), 4 deletions(-)
include/linux/sprintf.h +2 -0
@@ -20,6 +20,8 @@ __printf(2, 0) const char *kvasprintf_const(gfp_t gfp, const char *fmt, va_list __scanf(2, 3) int sscanf(const char *, const char *, ...); __scanf(2, 0) int vsscanf(const char *, const char *, va_list); +/* These are for specific cases, do not use without real need */ +extern bool no_hash_pointers;int no_hash_pointers_enable (char *str);#endif /* _LINUX_KERNEL_SPRINTF_H */
lib/test_printf.c +0 -2
@@ -42,8 +42,6 @@ KSTM_MODULE_GLOBALS();static char *test_buffer__initdata ;static char *alloced_buffer__initdata ; -extern bool no_hash_pointers; - static int __printf(4, 0) __init do_test(int bufsize, const char *expect, int elen, const char *fmt, va_list ap)
mm/kfence/report.c +1 -2
@@ -13,6 +13,7 @@#include <linux/printk.h> #include <linux/sched/debug.h> #include <linux/seq_file.h> +#include <linux/sprintf.h> #include <linux/stacktrace.h> #include <linux/string.h> #include <trace/events/error_report.h>
@@ -26,8 +27,6 @@#define ARCH_FUNC_PREFIX ""#endif -extern bool no_hash_pointers; -/* Helper function to either print to a seq_file or to console. */ __printf(2, 3)static void seq_con_printf (struct seq_file *seq,const char *fmt, ...)
Signature · 1 line
2.40.0.1.gaa8946217a0b
Re: [PATCH v3 2/2] lib/vsprintf: Declare no_hash_pointers in sprintf.h
Quoted 8 lines · Andy Shevchenko
Sparse is not happy to see non-static variable without declaration:
lib/vsprintf.c:61:6: warning: symbol 'no_hash_pointers' was not declared. Should it be static?Declare respective variable in the
sprintf.h. With this, add a comment to discourage its use if no real need.Signed-off-by Andy Shevchenko <[email protected]>Acked-by Marco Elver <[email protected]>
Best Regards,
Petr