configs/andes_ae350_45: Fix build failure caused by Zicsr and Zifencei
PATCH 1/2 configs/andes_ae350_45: Fix build failure caused by Zicsr and Zifencei
Don't specify the ARCH_FLAGS of U-Boot, so both extensions can be appended to -march when building w/ gcc-12.
Fixes:
- https://gitlab.com/buildroot.org/buildroot/-/jobs/4839059655
--- configs/andes_ae350_45_defconfig | 1 - 1 file changed, 1 deletion(-)
configs/andes_ae350_45_defconfig +0 -1
@@ -38,7 +38,6 @@ BR2_TARGET_UBOOT_NEEDS_OPENSBI=y BR2_TARGET_UBOOT_FORMAT_CUSTOM=y BR2_TARGET_UBOOT_FORMAT_CUSTOM_NAME="u-boot.itb" BR2_TARGET_UBOOT_SPL=y -BR2_TARGET_UBOOT_CUSTOM_MAKEOPTS="ARCH_FLAGS=-march=rv64imafdc" BR2_PACKAGE_HOST_DOSFSTOOLS=y BR2_PACKAGE_HOST_GENIMAGE=y BR2_PACKAGE_HOST_MTOOLS=y
Signature · 6 lines
2.34.1 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
PATCH 2/2 configs/andes_ae350_45: Select RVA for AE350 platform
The BR2_PACKAGE_GLIBC_ARCH_SUPPORTS requires the RVA extension, so we select it to enable and use glibc by default.
--- configs/andes_ae350_45_defconfig | 1 + 1 file changed, 1 insertion(+)
configs/andes_ae350_45_defconfig +1 -0
@@ -1,6 +1,7 @@ BR2_riscv=y BR2_riscv_custom=y BR2_RISCV_ISA_CUSTOM_RVM=y +BR2_RISCV_ISA_CUSTOM_RVA=y BR2_RISCV_ISA_CUSTOM_RVF=y BR2_RISCV_ISA_CUSTOM_RVD=y BR2_RISCV_ISA_CUSTOM_RVC=y
Signature · 6 lines
2.34.1 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Re: [Buildroot] [PATCH 2/2] configs/andes_ae350_45: Select RVA for AE350 platform
Quoted 2 lines · On Mon, 14 Aug 2023 10:48:34 +0800 Yu Chien Peter Lin <[email protected]>…
The
BR2_PACKAGE_GLIBC_ARCH_SUPPORTSrequires the RVA extension, so we select it to enable and use glibc by default.
Thanks for the patch. However, the commit log is not a proper justification. Indeed, BR2_RISCV_ISA_CUSTOM_RVA should be enabled if the hardware supports it, not because glibc needs it. If glibc needs it, but the hardware doesn't support this instruction set extension, it doesn't make sense to enable it.
Thomas
Signature · 7 lines
Thomas Petazzoni, co-owner and CEO, Bootlin Embedded Linux and Kernel engineering and training https://bootlin.com _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Re: [Buildroot] [PATCH 2/2] configs/andes_ae350_45: Select RVA for AE350 platform
Quoted 11 lines · Thomas Petazzoni
Quoted 2 lines · On Mon, 14 Aug 2023 10:48:34 +0800 Yu Chien Peter Lin <[email protected]>…
The
BR2_PACKAGE_GLIBC_ARCH_SUPPORTSrequires the RVA extension, so we select it to enable and use glibc by default.Thanks for the patch. However, the commit log is not a proper justification. Indeed,
BR2_RISCV_ISA_CUSTOM_RVAshould be enabled if the hardware supports it, not because glibc needs it. If glibc needs it, but the hardware doesn't support this instruction set extension, it doesn't make sense to enable it.
No problem, will reword properly in the next patch. Thanks!
Peter Lin
Quoted 5 lines
Thomas
Signature · 3 lines
Thomas Petazzoni, co-owner and CEO, Bootlin Embedded Linux and Kernel engineering and training https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Yann E. MORIN
AppliedYu Chien Peter Lin, All,
On 2023-08-14 10:48 +0800, Yu Chien Peter Lin spake thusly:
Quoted 7 lines
Don't specify the
ARCH_FLAGSof U-Boot, so both extensions can be appended to -march when building w/ gcc-12.Fixes:
- https://gitlab.com/buildroot.org/buildroot/-/jobs/4839059655Signed-off-by Yu Chien Peter Lin <[email protected]>
Applied to master, thanks.
Regards,
Yann E. MORIN.
Quoted 23 lines
--- configs/andes_ae350_45_defconfig | 1 - 1 file changed, 1 deletion(-)configs/andes_ae350_45_defconfig +0
-1@@ -38,7 +38,6 @@ BR2_TARGET_UBOOT_NEEDS_OPENSBI=y BR2_TARGET_UBOOT_FORMAT_CUSTOM=y BR2_TARGET_UBOOT_FORMAT_CUSTOM_NAME="u-boot.itb" BR2_TARGET_UBOOT_SPL=y -BR2_TARGET_UBOOT_CUSTOM_MAKEOPTS="ARCH_FLAGS=-march=rv64imafdc" BR2_PACKAGE_HOST_DOSFSTOOLS=y BR2_PACKAGE_HOST_GENIMAGE=y BR2_PACKAGE_HOST_MTOOLS=ySignature · 6 lines
2.34.1 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Signature · 10 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot