Skip to contentSkip to conversation

thermal: generic-adc: removed unneeded call to platform_set_drvdata()

PATCH In review Andrei Coardos 2 participants 2 messages Aug 14, 2023 – Aug 15, 2023 Thermal

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 thermal: generic-adc: removed unneeded call to platform_set_drvdata()

This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.

---
 drivers/thermal/thermal-generic-adc.c | 1 -
 1 file changed, 1 deletion(-)
drivers/thermal/thermal-generic-adc.c +0 -1
index f4f1a04f8c0f..1717e4a19dcb 100644
@@ -142,7 +142,6 @@ static int gadc_thermal_probe(struct platform_device *pdev)
 		return ret;
 
 	gti->dev = &pdev->dev;
-	platform_set_drvdata(pdev, gti);
 
 	gti->tz_dev = devm_thermal_of_zone_register(&pdev->dev, 0, gti,
 						    &gadc_thermal_ops);
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Andrei Coardos

This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.

Quoted 20 lines
---
 drivers/thermal/thermal-generic-adc.c | 1 -
 1 file changed, 1 deletion(-)
drivers/thermal/thermal-generic-adc.c +0 -2
index f4f1a04f8c0f..1717e4a19dcb 100644
@@ -142,7 +142,6 @@ static int gadc_thermal_probe(struct platform_device *pdev)
                return ret;
 
        gti->dev = &pdev->dev;
-       platform_set_drvdata(pdev, gti);
 
        gti->tz_dev = devm_thermal_of_zone_register(&pdev->dev, 0, gti,
                                                    &gadc_thermal_ops);
--

2.34.1