KVM: selftests: Remove x86's so called "MMIO warning" test
Sean Christopherson
reviewerPATCH 1/1 KVM: selftests: Remove x86's so called "MMIO warning" test
Remove x86's mmio_warning_test, as it is unnecessarily complex (there's no reason to fork, spawn threads, initialize srand(), etc..), unnecessarily restrictive (triggering triple fault is not unique to Intel CPUs without unrestricted guest), and provides no meaningful coverage beyond what basic fuzzing can achieve (running a vCPU with garbage is fuzzing's bread and butter).
That the test has *all* of the above flaws is not coincidental, as the code was copy+pasted almost verbatim from the syzkaller reproducer that originally found the KVM bug (which has long since been fixed).
--- tools/testing/selftests/kvm/Makefile | 1 - .../selftests/kvm/x86_64/mmio_warning_test.c | 121 ------------------ 2 files changed, 122 deletions(-) delete mode 100644 tools/testing/selftests/kvm/x86_64/mmio_warning_test.c
tools/testing/selftests/kvm/Makefile +0 -1
@@ -76,7 +76,6 @@ TEST_GEN_PROGS_x86_64 += x86_64/hyperv_svm_test TEST_GEN_PROGS_x86_64 += x86_64/hyperv_tlb_flush TEST_GEN_PROGS_x86_64 += x86_64/kvm_clock_test TEST_GEN_PROGS_x86_64 += x86_64/kvm_pv_test -TEST_GEN_PROGS_x86_64 += x86_64/mmio_warning_test TEST_GEN_PROGS_x86_64 += x86_64/monitor_mwait_test TEST_GEN_PROGS_x86_64 += x86_64/nested_exceptions_test TEST_GEN_PROGS_x86_64 += x86_64/platform_info_test
tools/testing/selftests/kvm/x86_64/mmio_warning_test.c deleted +0 -121
121 lines not on this page · raw message
base-commit: 240f736891887939571854bd6d734b6c9291f22e
Signature · 1 line
2.41.0.694.ge786442a9b-goog
Sean Christopherson
reviewerQuoted 8 lines · Sean Christopherson
Remove x86's
mmio_warning_test, as it is unnecessarily complex (there's no reason to fork, spawn threads, initializesrand(), etc..), unnecessarily restrictive (triggering triple fault is not unique to Intel CPUs without unrestricted guest), and provides no meaningful coverage beyond what basic fuzzing can achieve (running a vCPU with garbage is fuzzing's bread and butter).[...]
Applied to kvm-x86 selftests, thanks!
[1/1] KVM: selftests: Remove x86's so called "MMIO warning" test
https://github.com/kvm-x86/linux/commit/e29f5d0c3c7c