arm64: dts: imx8mp: Fix SDMA2/3 clocks
Subsystems (2)
PATCH v2 1/2 arm64: dts: imx8mp: Fix SDMA2/3 clocks
A previous patch to remove the Audio clocks from the main clock node was intended to force people to setup the audio PLL clocks per board instead of having a common set of rates since not all boards may use the various audio PLL clocks for audio devices.
Unfortunately, with this parenting removed, the SDMA2 and SDMA3 clocks were slowed to 24MHz because the SDMA2/3 clocks are controlled via the audio_blk_ctrl which is clocked from IMX8MP_CLK_AUDIO_ROOT, and that clock is enabled by pgc_audio.
Per the TRM, "The SDMA2/3 target frequency is 400MHz IPG and 400MHz AHB, always 1:1 mode, to make sure there is enough throughput for all the audio use cases."
Instead of cluttering the clock node, place the clock rate and parent information into the pgc_audio node.
With the parenting and clock rates restored for IMX8MP_CLK_AUDIO_AHB, and IMX8MP_CLK_AUDIO_AXI_SRC, it appears the SDMA2 and SDMA3 run at 400MHz again.
---
V2: Slow AUDIO_AXI to 600MHz for nominal drive. Individual boards can increase
this to 800MHz if they have the proper voltage configured.
arch/arm64/boot/dts/freescale/imx8mp.dtsi +6 -0
@@ -790,6 +790,12 @@ pgc_audio: power-domain@5 { reg = <IMX8MP_POWER_DOMAIN_AUDIOMIX>; clocks = <&clk IMX8MP_CLK_AUDIO_ROOT>, <&clk IMX8MP_CLK_AUDIO_AXI>; + assigned-clocks = <&clk IMX8MP_CLK_AUDIO_AHB>, + <&clk IMX8MP_CLK_AUDIO_AXI_SRC>; + assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_800M>, + <&clk IMX8MP_SYS_PLL1_800M>; + assigned-clock-rates = <400000000>, + <600000000>; }; pgc_gpu2d: power-domain@6 {
Signature · 7 lines
2.39.2 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
PATCH v2 2/2 arm64: dts: imx8mp-beacon-kit: Fix audio_pll2 clock
A previous patch removed the audio PLL configuration from the clk node, which resulted in an incorrect clock rate when attempting to playback audio. Fix this by setting the AUDIO_PLL2 rate inside the SAI3 node since it's the SAI3 that needs it.
---
V2: No change
arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts +3 -2
@@ -381,9 +381,10 @@ &pcie_phy { &sai3 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_sai3>; - assigned-clocks = <&clk IMX8MP_CLK_SAI3>; + assigned-clocks = <&clk IMX8MP_CLK_SAI3>, + <&clk IMX8MP_AUDIO_PLL2> ; assigned-clock-parents = <&clk IMX8MP_AUDIO_PLL2_OUT>; - assigned-clock-rates = <12288000>; + assigned-clock-rates = <12288000>, <361267200>; fsl,sai-mclk-direction-output; status = "okay"; };
Signature · 7 lines
2.39.2 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Re: [PATCH V2 2/2] arm64: dts: imx8mp-beacon-kit: Fix audio_pll2 clock
Quoted 2 lines · Adam Ford
A previous patch removed the audio PLL configuration from the clk
Same comment as in previous patch.
Quoted 7 lines
node, which resulted in an incorrect clock rate when attempting to playback audio. Fix this by setting the
AUDIO_PLL2rate inside the SAI3 node since it's the SAI3 that needs it.Fixes 16c984524862 ("arm64: dts: imx8mp: don't initialize audio clocks from CCM node")Signed-off-by Adam Ford <[email protected]>Reviewed-by Lucas Stach <[email protected]>
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Hi Adam,
Quoted 2 lines · Adam Ford
A previous patch to remove the Audio clocks from the main clock node
Nit: Instead of referring to "A previous patch", it would be clearer to explicitly
refer to the actual commit.
Quoted 16 lines
was intended to force people to setup the audio PLL clocks per board instead of having a common set of rates since not all boards may use the various audio PLL clocks for audio devices.
Unfortunately, with this parenting removed, the SDMA2 and SDMA3 clocks were slowed to 24MHz because the SDMA2/3 clocks are controlled via the
audio_blk_ctrlwhich is clocked fromIMX8MP_CLK_AUDIO_ROOT, and that clock is enabled bypgc_audio.Per the TRM, "The SDMA2/3 target frequency is 400MHz IPG and 400MHz AHB, always 1:1 mode, to make sure there is enough throughput for all the audio use cases."
Instead of cluttering the clock node, place the clock rate and parent information into the
pgc_audionode.
Quoted 7 lines
With the parenting and clock rates restored for
IMX8MP_CLK_AUDIO_AHB, andIMX8MP_CLK_AUDIO_AXI_SRC, it appears the SDMA2 and SDMA3 run at 400MHz again.Fixes 16c984524862 ("arm64: dts: imx8mp: don't initialize audio clocks from CCM node")Signed-off-by Adam Ford <[email protected]>Reviewed-by Lucas Stach <[email protected]>
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Quoted 10 lines · Fabio Estevam
Hi Adam,
Quoted 2 lines · Adam Ford
A previous patch to remove the Audio clocks from the main clock node
Nit: Instead of referring to "A previous patch", it would be clearer to explicitly
refer to the actual commit.
I tried to do that with the fixes tag below. Do you want me to re-submit the patches with this changed? I was hoping to avoid referencing the same patch and hash twice in the same commit message.
adam
Quoted 21 lines
Quoted 21 lines
was intended to force people to setup the audio PLL clocks per board instead of having a common set of rates since not all boards may use the various audio PLL clocks for audio devices.
Unfortunately, with this parenting removed, the SDMA2 and SDMA3 clocks were slowed to 24MHz because the SDMA2/3 clocks are controlled via the
audio_blk_ctrlwhich is clocked fromIMX8MP_CLK_AUDIO_ROOT, and that clock is enabled bypgc_audio.Per the TRM, "The SDMA2/3 target frequency is 400MHz IPG and 400MHz AHB, always 1:1 mode, to make sure there is enough throughput for all the audio use cases."
Instead of cluttering the clock node, place the clock rate and parent information into the
pgc_audionode.With the parenting and clock rates restored for
IMX8MP_CLK_AUDIO_AHB, andIMX8MP_CLK_AUDIO_AXI_SRC, it appears the SDMA2 and SDMA3 run at 400MHz again.
Quoted 5 lines
Quoted 3 lines
Fixes 16c984524862 ("arm64: dts: imx8mp: don't initialize audio clocks from CCM node")Signed-off-by Adam Ford <[email protected]>Reviewed-by Lucas Stach <[email protected]>Reviewed-by Fabio Estevam <[email protected]>
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Fabio Estevam
reviewerHi Adam,
Quoted 3 lines · Adam Ford
I tried to do that with the fixes tag below. Do you want me to re-submit the patches with this changed? I was hoping to avoid referencing the same patch and hash twice in the same commit message.
IMHO there is no problem at all by referencing the same commit hash twice.
In fact, it makes it clearer as to what exactly you are referencing.
Please re-submit it, thanks.
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel