Skip to contentSkip to conversation

tpm_tis: Revert "tpm_tis: Disable interrupts on ThinkPad T490s"

PATCH New Jarkko Sakkinen 1 participant 1 message Aug 16, 2023

Subsystems (5)
lore
Share & tools
lore

Jarkko Sakkinen

author maintainer
#0 lore raw

PATCH v2 1/1 tpm_tis: Revert "tpm_tis: Disable interrupts on ThinkPad T490s"

Since for MMIO driver using FIFO registers, also known as tpm_tis, the default (and tbh recommended) behaviour is now the polling mode, the "tristate" workaround is no longer for benefit.

If someone wants to explicitly enable IRQs for a TPM chip that should be without question allowed. It could very well be a piece hardware in the existing deny list because of e.g. firmware update or something similar.

While at it, document the module parameter, as this was not done in 2006 when it first appeared in the mainline.

---
v2:
* s/look up to/see/ (Randy)
https://lore.kernel.org/linux-integrity/[email protected]/

 .../admin-guide/kernel-parameters.txt         |  7 ++
 drivers/char/tpm/tpm_tis.c                    | 93 +------------------
 2 files changed, 9 insertions(+), 91 deletions(-)
Documentation/admin-guide/kernel-parameters.txt +7 -0
index 722b6eca2e93..155101120438 100644
@@ -6340,6 +6340,13 @@
 			This will guarantee that all the other pcrs
 			are saved.
 
+	tpm_tis.interrupts= [HW,TPM]
+			Enable interrupts for the MMIO based physical layer
+			for the FIFO interface. By default it is set to false
+			(0). For more information about TPM hardware interfaces
+			defined by Trusted Computing Group (TCG) see
+			https://trustedcomputinggroup.org/resource/pc-client-platform-tpm-profile-ptp-specification/
+
 	tp_printk	[FTRACE]
 			Have the tracepoints sent to printk as well as the
 			tracing ring buffer. This is useful for early boot up
drivers/char/tpm/tpm_tis.c +2 -91

117 lines not on this page · raw message

Signature · 1 line
2.39.2