Skip to contentSkip to conversation

SDM670 CPU frequency scaling: dtschema fixes

PATCH Applied Richard Acayan 5 participants 9 messages Aug 16, 2023 – Oct 22, 2023

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

v2 cover SDM670 CPU frequency scaling: dtschema fixes

Changes since v1 ([email protected]):
- add compatible to allOf area (2/3)
- change subject line (Acked-by tag retained) (1/3)
- add fixes tag (2/3)

This adds appropriate compatible strings to pass bindings checks.

Patch 1/3 is preserved from a previous series, as it was not applied to linux-next yet and I wasn't notified that it was applied anywhere else:
https://lore.kernel.org/linux-arm-msm/[email protected]/

Richard Acayan (3):
dt-bindings: interconnect: OSM L3: add SDM670 compatible
dt-bindings: cpufreq: cpufreq-qcom-hw: add SDM670 compatible
arm64: dts: qcom: sdm670: add specific cpufreq compatible

 Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml  | 2 ++
 Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml | 1 +
 arch/arm64/boot/dts/qcom/sdm670.dtsi                            | 2 +-
 3 files changed, 4 insertions(+), 1 deletion(-)
Signature · 1 line
2.41.0
#1 lore raw

PATCH v2 1/3 dt-bindings: interconnect: OSM L3: add SDM670 compatible

Add the compatible for the OSM L3 interconnect used in the Snapdragon 670.

---
 Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml +1 -0
index 9d0a98d77ae9..21dae0b92819 100644
@@ -21,6 +21,7 @@ properties:
           - enum:
               - qcom,sc7180-osm-l3
               - qcom,sc8180x-osm-l3
+              - qcom,sdm670-osm-l3
               - qcom,sdm845-osm-l3
               - qcom,sm6350-osm-l3
               - qcom,sm8150-osm-l3
Signature · 1 line
2.41.0
#2 lore raw

PATCH v2 2/3 dt-bindings: cpufreq: cpufreq-qcom-hw: add SDM670 compatible

In reply to Richard Acayan

The bindings for Qualcomm CPU frequency have a compatible for each SoC. Add the compatible for SDM670.

Fixes 0c665213d126 ("arm64: dts: qcom: sdm670: add cpu frequency scaling")
---
 Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml +2 -0
index a6b3bb8fdf33..3ce288c5e591 100644
@@ -23,6 +23,7 @@ properties:
           - enum:
               - qcom,qcm2290-cpufreq-hw
               - qcom,sc7180-cpufreq-hw
+              - qcom,sdm670-cpufreq-hw
               - qcom,sdm845-cpufreq-hw
               - qcom,sm6115-cpufreq-hw
               - qcom,sm6350-cpufreq-hw
@@ -125,6 +126,7 @@ allOf:
               - qcom,qdu1000-cpufreq-epss
               - qcom,sc7180-cpufreq-hw
               - qcom,sc8280xp-cpufreq-epss
+              - qcom,sdm670-cpufreq-hw
               - qcom,sdm845-cpufreq-hw
               - qcom,sm6115-cpufreq-hw
               - qcom,sm6350-cpufreq-hw
Signature · 1 line
2.41.0
maintainer Applied
#4 lore raw

Re: [PATCH v2 2/3] dt-bindings: cpufreq: cpufreq-qcom-hw: add SDM670 compatible

Quoted 10 lines · Krzysztof Kozlowski
Quoted 6 lines · Richard Acayan

The bindings for Qualcomm CPU frequency have a compatible for each SoC. Add the compatible for SDM670.

Fixes 0c665213d126 ("arm64: dts: qcom: sdm670: add cpu frequency scaling")

---

Applied. Thanks.

Signature · 1 line
viresh
#5 lore raw

PATCH v2 3/3 arm64: dts: qcom: sdm670: add specific cpufreq compatible

In reply to Richard Acayan

The bindings for the CPU frequency scaling driver require a specific compatible for the SoC. Add the compatible.

Fixes 0c665213d126 ("arm64: dts: qcom: sdm670: add cpu frequency scaling")
---
 arch/arm64/boot/dts/qcom/sdm670.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/qcom/sdm670.dtsi +1 -1
index 84cd2e39266f..dae426b08e86 100644
@@ -1531,7 +1531,7 @@ osm_l3: interconnect@17d41000 {
 		};
 
 		cpufreq_hw: cpufreq@17d43000 {
-			compatible = "qcom,cpufreq-hw";
+			compatible = "qcom,sdm670-cpufreq-hw", "qcom,cpufreq-hw";
 			reg = <0 0x17d43000 0 0x1400>, <0 0x17d45800 0 0x1400>;
 			reg-names = "freq-domain0", "freq-domain1";
 
Signature · 1 line
2.41.0
Reviewed-by on v2 3/3
#6 lore raw

Re: [PATCH v2 3/3] arm64: dts: qcom: sdm670: add specific cpufreq compatible

Quoted 6 lines · Richard Acayan

The bindings for the CPU frequency scaling driver require a specific compatible for the SoC. Add the compatible.

Fixes 0c665213d126 ("arm64: dts: qcom: sdm670: add cpu frequency scaling")

---

Konrad

#7 lore raw
In reply to Richard Acayan
Quoted 7 lines · Richard Acayan

Changes since v1 ([email protected]):
- add compatible to allOf area (2/3)
- change subject line (Acked-by tag retained) (1/3)
- add fixes tag (2/3)

This adds appropriate compatible strings to pass bindings checks.

Quoted 8 lines

Patch 1/3 is preserved from a previous series, as it was not applied to linux-next yet and I wasn't notified that it was applied anywhere else:
https://lore.kernel.org/linux-arm-msm/[email protected]/

Richard Acayan (3):
dt-bindings: interconnect: OSM L3: add SDM670 compatible
dt-bindings: cpufreq: cpufreq-qcom-hw: add SDM670 compatible
arm64: dts: qcom: sdm670: add specific cpufreq compatible

Hi, just a reminder that this series is here, and patches 2-3 are stale.

Would it help to send them separately?

Quoted 9 lines
 Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml  | 2 ++
 Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml | 1 +
 arch/arm64/boot/dts/qcom/sdm670.dtsi                            | 2 +-
 3 files changed, 4 insertions(+), 1 deletion(-)
Signature · 1 line
2.41.0
maintainer Applied
#8 lore raw

Re: (subset) [PATCH v2 0/3] SDM670 CPU frequency scaling: dtschema fixes

In reply to Richard Acayan
Quoted 8 lines · Richard Acayan

Changes since v1 ([email protected]):
- add compatible to allOf area (2/3)
- change subject line (Acked-by tag retained) (1/3)
- add fixes tag (2/3)

This adds appropriate compatible strings to pass bindings checks.

[...]

Applied, thanks!

[3/3] arm64: dts: qcom: sdm670: add specific cpufreq compatible

      commit: 032ff6a3b39addd54427844affaf21e1e80fabc2

Best regards,

Signature · 1 line
Bjorn Andersson <[email protected]>