selftests: rtc: Fixes rtctest error handling.

PATCH In review Atul Kumar Pant 2 participants 5 messages Aug 17, 2023 – Nov 12, 2023

Subsystems (2)

Kselftest Real time clock (RTC)

lore

Share & tools

lore

Atul Kumar Pant

author

2023-08-17 09:14 UTC #0 lore raw

PATCH v6 1/1 selftests: rtc: Fixes rtctest error handling.

Adds a check to verify if the rtc device file is valid or not and prints a useful error message if the file is not accessible.

Signed-off-by Atul Kumar Pant <[email protected]>

---

changes since v5:
Updated error message to use strerror().
If the rtc file is invalid, the skip the test.

changes since v4:
Updated the commit message.

changes since v3:
Added Linux-kselftest and Linux-kernel mailing lists.

changes since v2:
Changed error message when rtc file does not exist.

changes since v1:
Removed check for uid=0
If rtc file is invalid, then exit the test.

 tools/testing/selftests/rtc/rtctest.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

tools/testing/selftests/rtc/rtctest.c +2 -1

index 630fef735c7e..27b466111885 100644
@@ -15,6 +15,7 @@
 #include <sys/types.h>
 #include <time.h>
 #include <unistd.h>
+#include <error.h>
 
 #include "../kselftest_harness.h"
 #include "../kselftest.h"

@@ -437,7 +438,7 @@ int main(int argc, char **argv)
 	if (access(rtc_file, F_OK) == 0)
 		ret = test_harness_run(argc, argv);
 	else
-		ksft_exit_fail_msg("[ERROR]: Cannot access rtc file %s - Exiting\n", rtc_file);
+		ksft_exit_skip("%s: %s\n", rtc_file, strerror(errno));
 
 	return ret;
 }

Signature · 6 lines

2.25.1

_______________________________________________
Linux-kernel-mentees mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

Atul Kumar Pant

author

2023-09-23 17:37 UTC #1 lore raw

Quoted 50 lines · Atul Kumar Pant

Adds a check to verify if the rtc device file is valid or not and prints a useful error message if the file is not accessible.
Signed-off-by Atul Kumar Pant <[email protected]>
---
changes since v5:
Updated error message to use strerror().
If the rtc file is invalid, the skip the test.
changes since v4:
Updated the commit message.
changes since v3:
Added Linux-kselftest and Linux-kernel mailing lists.
changes since v2:
Changed error message when rtc file does not exist.
changes since v1:
Removed check for uid=0
If rtc file is invalid, then exit the test.
 tools/testing/selftests/rtc/rtctest.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
tools/testing/selftests/rtc/rtctest.c +2 -1
index 630fef735c7e..27b466111885 100644
@@ -15,6 +15,7 @@
 #include <sys/types.h>
 #include <time.h>
 #include <unistd.h>
+#include <error.h>
 
 #include "../kselftest_harness.h"
 #include "../kselftest.h"
@@ -437,7 +438,7 @@ int main(int argc, char **argv)
 	if (access(rtc_file, F_OK) == 0)
 		ret = test_harness_run(argc, argv);
 	else
-		ksft_exit_fail_msg("[ERROR]: Cannot access rtc file %s - Exiting\n", rtc_file);
+		ksft_exit_skip("%s: %s\n", rtc_file, strerror(errno));
 
 	return ret;
 }
Signature · 1 line
2.25.1

Hi Shuah, I have made the changes as per your comments. Can you please review the changes ?

Atul Kumar Pant

author

2023-10-07 15:43 UTC #2 lore raw

Quoted 46 lines · Atul Kumar Pant

Quoted 45 lines · Atul Kumar Pant
Adds a check to verify if the rtc device file is valid or not and prints a useful error message if the file is not accessible.
Signed-off-by Atul Kumar Pant <[email protected]>
---
changes since v5:
Updated error message to use strerror().
If the rtc file is invalid, the skip the test.
changes since v4:
Updated the commit message.
changes since v3:
Added Linux-kselftest and Linux-kernel mailing lists.
changes since v2:
Changed error message when rtc file does not exist.
changes since v1:
Removed check for uid=0
If rtc file is invalid, then exit the test.
 tools/testing/selftests/rtc/rtctest.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
tools/testing/selftests/rtc/rtctest.c +2 -1
index 630fef735c7e..27b466111885 100644
@@ -15,6 +15,7 @@
 #include <sys/types.h>
 #include <time.h>
 #include <unistd.h>
+#include <error.h>
 
 #include "../kselftest_harness.h"
 #include "../kselftest.h"
@@ -437,7 +438,7 @@ int main(int argc, char **argv)
 	if (access(rtc_file, F_OK) == 0)
 		ret = test_harness_run(argc, argv);
 	else
-		ksft_exit_fail_msg("[ERROR]: Cannot access rtc file %s - Exiting\n", rtc_file);
+		ksft_exit_skip("%s: %s\n", rtc_file, strerror(errno));
 

Quoted 8 lines

Quoted 5 lines
tools/testing/selftests/rtc/rtctest.c +0 -0
 	return ret;
 }
Signature · 1 line
2.25.1
Hi Shuah, I have made the changes as per your comments. Can you please review the changes ?

Hi Shuah, can you please review the changes and provide comments ? It has been quite sometime since I uploaded the change. If something is to be improved, I'll gladly do it.

Shuah Khan

maintainer

2023-11-07 21:27 UTC #3 lore raw

Quoted 7 lines · Atul Kumar Pant

Quoted 6 lines · Atul Kumar Pant
Quoted 5 lines · Atul Kumar Pant
Adds a check to verify if the rtc device file is valid or not and prints a useful error message if the file is not accessible.
Signed-off-by Atul Kumar Pant <[email protected]>
---

Sorry for the delay. I will pick this up for the next rc.

thanks,
-- Shuah

Atul Kumar Pant

author

2023-11-12 13:50 UTC #4 lore raw

Quoted 6 lines · Shuah Khan

Quoted 5 lines · Atul Kumar Pant
Quoted 4 lines · Atul Kumar Pant
Quoted 3 lines · Atul Kumar Pant
Adds a check to verify if the rtc device file is valid or not and prints a useful error message if the file is not accessible.

Quoted 8 lines

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Signed-off-by Atul Kumar Pant <[email protected]>
---
Sorry for the delay. I will pick this up for the next rc.
thanks,
-- Shuah

Thanks Shuah