Skip to contentSkip to conversation

rockchip: Add supported RK3566/RK3568 boards to documentation

PATCH In review Jonas Karlman 5 participants 14 messages Aug 17, 2023 Arm Rockchip

lore
Share & tools
lore
#0 lore raw

cover rockchip: Add supported RK3566/RK3568 boards to documentation

This series add missing supported RK3566/RK3568 boards to documentation and add related device tree files to MAINTAINERS for a few RK35xx boards.

Also added myself as a reviewer for RK3566/RK3568/RK3588 boards that I have and can help with review and testing of e.g. defconfig and device tree changes.

Jonas Karlman (3):
doc: rockchip: Add supported RK3566/RK3568 boards
board: rockchip: rk35xx: Add device tree files to MAINTAINERS
board: rockchip: rk35xx: Add myself as reviewer to MAINTAINERS

 board/anbernic/rgxx3_rk3566/MAINTAINERS       |  3 +
 .../neural-compute-module-6/MAINTAINERS       |  6 ++
 board/radxa/rock5a-rk3588s/MAINTAINERS        |  3 +
 board/radxa/rock5b-rk3588/MAINTAINERS         |  5 +-
 board/rockchip/evb_rk3568/MAINTAINERS         | 55 +++++++++++--------
 board/rockchip/evb_rk3588/MAINTAINERS         |  3 +-
 doc/board/rockchip/rockchip.rst               | 20 ++++---
 7 files changed, 61 insertions(+), 34 deletions(-)
Signature · 1 line
2.41.0
#1 lore raw

PATCH 1/3 doc: rockchip: Add supported RK3566/RK3568 boards

Update Rockchip documentation to include RK3566/RK3568 boards already supported. Also list Pine64 boards under RK3566 and drop defconfig to match other listed boards.

---
 doc/board/rockchip/rockchip.rst | 20 ++++++++++++--------
 1 file changed, 12 insertions(+), 8 deletions(-)
doc/board/rockchip/rockchip.rst +12 -8
index 31aeb8567607..4668e598515e 100644
@@ -91,18 +91,22 @@ List of mainline supported Rockchip boards:
      - Theobroma Systems RK3399-Q7 SoM - Puma (puma_rk3399)
 
 * rk3566
-     - Anbernic RGxx3 (rgxx3-rk3566)
+     - Anbernic RGxx3 (anbernic-rgxx3)
+     - Pine64 Quartz64-A Board (quartz64-a-rk3566)
+     - Pine64 Quartz64-B Board (quartz64-b-rk3566)
+     - Pine64 SOQuartz on Blade (soquartz-blade-rk3566)
+     - Pine64 SOQuartz on CM4-IO (soquartz-cm4-rk3566)
+     - Pine64 SOQuartz on Model A (soquartz-model-a-rk3566)
+     - Radxa CM3 IO Board (radxa-cm3-io-rk3566)
 
 * rk3568
      - Rockchip Evb-RK3568 (evb-rk3568)
-     - EmbedFire Lubancat 2 (lubancat-2-rk3568_defconfig)
+     - EmbedFire LubanCat 2 (lubancat-2-rk3568)
+     - FriendlyElec NanoPi R5C (nanopi-r5c-rk3568)
+     - FriendlyElec NanoPi R5S (nanopi-r5s-rk3568)
      - Hardkernel ODROID-M1 (odroid-m1-rk3568)
-     - Pine64 Quartz64-A Board (quartz64-a-rk3566_defconfig)
-     - Pine64 Quartz64-B Board (quartz64-b-rk3566_defconfig)
-     - Pine64 SOQuartz on Blade (soquartz-blade-rk3566_defconfig)
-     - Pine64 SOQuartz on CM4-IO (soquartz-cm4-rk3566_defconfig)
-     - Pine64 SOQuartz on Model A (soquartz-model-a-rk3566_defconfig)
-     - Radxa E25 Carrier Board (radxa-e25-rk3568_defconfig)
+     - Radxa E25 Carrier Board (radxa-e25-rk3568)
+     - Radxa ROCK 3 Model A (rock-3a-rk3568)
 
 * rk3588
      - Rockchip EVB (evb-rk3588)
Signature · 1 line
2.41.0
#2 lore raw

Re: [PATCH 1/3] doc: rockchip: Add supported RK3566/RK3568 boards

Hi Jonas,

    Thanks for your patch.

Quoted 14 lines · Jonas Karlman

Update Rockchip documentation to include RK3566/RK3568 boards already supported. Also list Pine64 boards under RK3566 and drop defconfig to match other listed boards.

---
  doc/board/rockchip/rockchip.rst | 20 ++++++++++++--------
  1 file changed, 12 insertions(+), 8 deletions(-)
doc/board/rockchip/rockchip.rst +0 -0
index 31aeb8567607..4668e598515e 100644

doc/board/rockchip/rockchip.rst List of mainline supported Rockchip boards: · line 94

Quoted 5 lines
doc/board/rockchip/rockchip.rst +1 -1
@@ -91,18 +91,22 @@ List of mainline supported Rockchip boards:
       - Theobroma Systems RK3399-Q7 SoM - Puma (puma_rk3399)
 
  * rk3566
-     - Anbernic RGxx3 (rgxx3-rk3566)
+     - Anbernic RGxx3 (anbernic-rgxx3)

This board is using anbernic-rgxx3 as defconfig name, but I would prefer update this defconfig to

use name rgxx3-rk3566_defconfig instead, to follow all the other boards with SoC name.

Thanks,

- Kever

Quoted 25 lines
doc/board/rockchip/rockchip.rst +11 -7
+     - Pine64 Quartz64-A Board (quartz64-a-rk3566)
+     - Pine64 Quartz64-B Board (quartz64-b-rk3566)
+     - Pine64 SOQuartz on Blade (soquartz-blade-rk3566)
+     - Pine64 SOQuartz on CM4-IO (soquartz-cm4-rk3566)
+     - Pine64 SOQuartz on Model A (soquartz-model-a-rk3566)
+     - Radxa CM3 IO Board (radxa-cm3-io-rk3566)
 
  * rk3568
       - Rockchip Evb-RK3568 (evb-rk3568)
-     - EmbedFire Lubancat 2 (lubancat-2-rk3568_defconfig)
+     - EmbedFire LubanCat 2 (lubancat-2-rk3568)
+     - FriendlyElec NanoPi R5C (nanopi-r5c-rk3568)
+     - FriendlyElec NanoPi R5S (nanopi-r5s-rk3568)
       - Hardkernel ODROID-M1 (odroid-m1-rk3568)
-     - Pine64 Quartz64-A Board (quartz64-a-rk3566_defconfig)
-     - Pine64 Quartz64-B Board (quartz64-b-rk3566_defconfig)
-     - Pine64 SOQuartz on Blade (soquartz-blade-rk3566_defconfig)
-     - Pine64 SOQuartz on CM4-IO (soquartz-cm4-rk3566_defconfig)
-     - Pine64 SOQuartz on Model A (soquartz-model-a-rk3566_defconfig)
-     - Radxa E25 Carrier Board (radxa-e25-rk3568_defconfig)
+     - Radxa E25 Carrier Board (radxa-e25-rk3568)
+     - Radxa ROCK 3 Model A (rock-3a-rk3568)
 
  * rk3588
       - Rockchip EVB (evb-rk3588)
#3 lore raw

Re: [PATCH 1/3] doc: rockchip: Add supported RK3566/RK3568 boards

Quoted 27 lines · Kever Yang

Hi Jonas,

    Thanks for your patch.

Quoted 14 lines · Jonas Karlman

Update Rockchip documentation to include RK3566/RK3568 boards already supported. Also list Pine64 boards under RK3566 and drop defconfig to match other listed boards.

---
  doc/board/rockchip/rockchip.rst | 20 ++++++++++++--------
  1 file changed, 12 insertions(+), 8 deletions(-)
doc/board/rockchip/rockchip.rst +0 -0
index 31aeb8567607..4668e598515e 100644

doc/board/rockchip/rockchip.rst List of mainline supported Rockchip boards: · line 93

Quoted 4 lines
doc/board/rockchip/rockchip.rst +1 -1
@@ -91,18 +91,22 @@ List of mainline supported Rockchip boards:
       - Theobroma Systems RK3399-Q7 SoM - Puma (puma_rk3399)
  * rk3566
-     - Anbernic RGxx3 (rgxx3-rk3566)
+     - Anbernic RGxx3 (anbernic-rgxx3)

This board is using anbernic-rgxx3 as defconfig name, but I would prefer update this defconfig to

Quoted 2 lines

use name rgxx3-rk3566_defconfig instead, to follow all the other boards with SoC name.

Sorry, in my rush to get more MAINTAINERS entries updated / correct I missed your feedback here. Jonas, please update and I'll make sure it gets in to the tree.

Signature · 1 line
Tom
#4 lore raw

Re: [PATCH 1/3] doc: rockchip: Add supported RK3566/RK3568 boards

Quoted 28 lines · Tom Rini
Quoted 27 lines · Kever Yang

Hi Jonas,

    Thanks for your patch.

Quoted 14 lines · Jonas Karlman

Update Rockchip documentation to include RK3566/RK3568 boards already supported. Also list Pine64 boards under RK3566 and drop defconfig to match other listed boards.

---
  doc/board/rockchip/rockchip.rst | 20 ++++++++++++--------
  1 file changed, 12 insertions(+), 8 deletions(-)
doc/board/rockchip/rockchip.rst +0 -0
index 31aeb8567607..4668e598515e 100644

doc/board/rockchip/rockchip.rst List of mainline supported Rockchip boards: · line 93

Quoted 4 lines
doc/board/rockchip/rockchip.rst +1 -1
@@ -91,18 +91,22 @@ List of mainline supported Rockchip boards:
       - Theobroma Systems RK3399-Q7 SoM - Puma (puma_rk3399)
  * rk3566
-     - Anbernic RGxx3 (rgxx3-rk3566)
+     - Anbernic RGxx3 (anbernic-rgxx3)

This board is using anbernic-rgxx3 as defconfig name, but I would prefer update this defconfig to

Quoted 7 lines
Quoted 2 lines

use name rgxx3-rk3566_defconfig instead, to follow all the other boards with SoC name.

Sorry, in my rush to get more MAINTAINERS entries updated / correct I missed your feedback here. Jonas, please update and I'll make sure it gets in to the tree.

Thanks, will send a patch that rename to anbernic-rgxx3-rk3566_defconfig and update docs to reflect the new name shortly.

Regards,
Jonas

#5 lore raw

Re: [PATCH 1/3] doc: rockchip: Add supported RK3566/RK3568 boards

In reply to Jonas Karlman
Quoted 5 lines · Jonas Karlman

Update Rockchip documentation to include RK3566/RK3568 boards already supported. Also list Pine64 boards under RK3566 and drop defconfig to match other listed boards.

Applied to u-boot/master, thanks!

Signature · 1 line
Tom
#6 lore raw

PATCH 2/3 board: rockchip: rk35xx: Add device tree files to MAINTAINERS

In reply to Jonas Karlman

Update MAINTAINERS files for RK3566/RK3568/RK3588 boards to include related device tree files. Also replace space with tabs.

---
 board/anbernic/rgxx3_rk3566/MAINTAINERS       |  3 ++
 .../neural-compute-module-6/MAINTAINERS       |  6 +++
 board/radxa/rock5a-rk3588s/MAINTAINERS        |  2 +
 board/radxa/rock5b-rk3588/MAINTAINERS         |  4 +-
 board/rockchip/evb_rk3568/MAINTAINERS         | 51 ++++++++++---------
 board/rockchip/evb_rk3588/MAINTAINERS         |  3 +-
 6 files changed, 43 insertions(+), 26 deletions(-)
board/anbernic/rgxx3_rk3566/MAINTAINERS +3 -0
index 1c0d3fe7b5bf..6be16a47e8eb 100644
@@ -4,3 +4,6 @@ S:	Maintained
 F:	board/anbernic/rgxx3_rk3566
 F:	include/configs/anbernic-rgxx3-rk3566.h
 F:	configs/anbernic-rgxx3_defconfig
+F:	arch/arm/dts/rk3566-anbernic-rgxx3.dts
+F:	arch/arm/dts/rk3566-anbernic-rgxx3.dtsi
+F:	arch/arm/dts/rk3566-anbernic-rgxx3-u-boot.dtsi
board/edgeble/neural-compute-module-6/MAINTAINERS +6 -0
index bc7f9b0e680d..42e5df506bf3 100644
@@ -5,3 +5,9 @@ F:	board/edgeble/neural-compute-module-6
 F:	include/configs/neural-compute-module-6.h
 F:	configs/neu6a-io-rk3588_defconfig
 F:	configs/neu6b-io-rk3588_defconfig
+F:	arch/arm/dts/rk3588-edgeble-neu6a.dtsi
+F:	arch/arm/dts/rk3588-edgeble-neu6a-io.dts
+F:	arch/arm/dts/rk3588-edgeble-neu6a-io-u-boot.dtsi
+F:	arch/arm/dts/rk3588-edgeble-neu6b.dtsi
+F:	arch/arm/dts/rk3588-edgeble-neu6b-io.dts
+F:	arch/arm/dts/rk3588-edgeble-neu6b-io-u-boot.dtsi
board/radxa/rock5a-rk3588s/MAINTAINERS +2 -0
index 62fb6b4c0eea..05750269b8dd 100644
@@ -4,3 +4,5 @@ S:	Maintained
 F:	board/radxa/rock5a-rk3588s
 F:	include/configs/rock5a-rk3588s.h
 F:	configs/rock5a-rk3588s_defconfig
+F:	arch/arm/dts/rk3588s-rock-5a.dts
+F:	arch/arm/dts/rk3588s-rock-5a-u-boot.dtsi
board/radxa/rock5b-rk3588/MAINTAINERS +3 -1
index 693751e583d9..734115a4a3dc 100644
@@ -2,5 +2,7 @@ ROCK5B-RK3588
 M:	Eugen Hristev <[email protected]>
 S:	Maintained
 F:	board/radxa/rock5b-rk3588
-F:	include/configs/rock5b-rk3588
+F:	include/configs/rock5b-rk3588.h
 F:	configs/rock5b-rk3588_defconfig
+F:	arch/arm/dts/rk3588-rock-5b.dts
+F:	arch/arm/dts/rk3588-rock-5b-u-boot.dtsi
board/rockchip/evb_rk3568/MAINTAINERS +27 -24

72 lines not on this page · raw message

board/rockchip/evb_rk3588/MAINTAINERS +2 -1
index 7b7df3c5a8ac..6b2c257a1705 100644
@@ -4,4 +4,5 @@ S:	Maintained
 F:	board/rockchip/evb_rk3588
 F:	include/configs/evb_rk3588.h
 F:	configs/evb-rk3588_defconfig
-F:	arch/arm/dts/rk3588-evb-u-boot.dtsi
+F:	arch/arm/dts/rk3588-evb1-v10.dts
+F:	arch/arm/dts/rk3588-evb1-v10-u-boot.dtsi
Signature · 1 line
2.41.0
Acked-by on v1 2/3
#7 lore raw

Re: [PATCH 2/3] board: rockchip: rk35xx: Add device tree files to MAINTAINERS

Quoted 4 lines · Jonas Karlman

Update MAINTAINERS files for RK3566/RK3568/RK3588 boards to include related device tree files. Also replace space with tabs.

Quoted 9 lines
---
  board/anbernic/rgxx3_rk3566/MAINTAINERS       |  3 ++
  .../neural-compute-module-6/MAINTAINERS       |  6 +++
  board/radxa/rock5a-rk3588s/MAINTAINERS        |  2 +
  board/radxa/rock5b-rk3588/MAINTAINERS         |  4 +-
  board/rockchip/evb_rk3568/MAINTAINERS         | 51 ++++++++++---------
  board/rockchip/evb_rk3588/MAINTAINERS         |  3 +-
  6 files changed, 43 insertions(+), 26 deletions(-)

For rock5,

#8 lore raw

Re: [PATCH 2/3] board: rockchip: rk35xx: Add device tree files to MAINTAINERS

In reply to Jonas Karlman

Hi Jonas,

Quoted 18 lines · Jonas Karlman

Update MAINTAINERS files for RK3566/RK3568/RK3588 boards to include related device tree files. Also replace space with tabs.

---
  board/anbernic/rgxx3_rk3566/MAINTAINERS       |  3 ++
  .../neural-compute-module-6/MAINTAINERS       |  6 +++
  board/radxa/rock5a-rk3588s/MAINTAINERS        |  2 +
  board/radxa/rock5b-rk3588/MAINTAINERS         |  4 +-
  board/rockchip/evb_rk3568/MAINTAINERS         | 51 ++++++++++---------
  board/rockchip/evb_rk3588/MAINTAINERS         |  3 +-
  6 files changed, 43 insertions(+), 26 deletions(-)
board/anbernic/rgxx3_rk3566/MAINTAINERS +0 -0
index 1c0d3fe7b5bf..6be16a47e8eb 100644

board/anbernic/rgxx3_rk3566/MAINTAINERS S: Maintained · line 9

Quoted 6 lines
board/anbernic/rgxx3_rk3566/MAINTAINERS +3 -0
@@ -4,3 +4,6 @@ S:	Maintained
  F:	board/anbernic/rgxx3_rk3566
  F:	include/configs/anbernic-rgxx3-rk3566.h
  F:	configs/anbernic-rgxx3_defconfig
+F:	arch/arm/dts/rk3566-anbernic-rgxx3.dts
+F:	arch/arm/dts/rk3566-anbernic-rgxx3.dtsi
+F:	arch/arm/dts/rk3566-anbernic-rgxx3-u-boot.dtsi

An easier way to deal with this is to use the "*" character since it's supported in MAINTAINERS file apparently (ag -Q "*" **/MAINTAINERS returns multiple matches in multiple files). So maybe replace it with something like

F: arch/arm/dts/rk3566-anbernic-rgxx3*

?

That way if the files eventually get split into multiple ones, get renamed, have one created (e.g. -u-boot.dtsi), they are all matched by that same line. Less maintenance here (and hopefully precise enough that we don't have false positives).

Just a suggestion,

Cheers,
Quentin

Quoted 127 lines
board/edgeble/neural-compute-module-6/MAINTAINERS +6 -0
index bc7f9b0e680d..42e5df506bf3 100644
@@ -5,3 +5,9 @@ F:	board/edgeble/neural-compute-module-6
  F:	include/configs/neural-compute-module-6.h
  F:	configs/neu6a-io-rk3588_defconfig
  F:	configs/neu6b-io-rk3588_defconfig
+F:	arch/arm/dts/rk3588-edgeble-neu6a.dtsi
+F:	arch/arm/dts/rk3588-edgeble-neu6a-io.dts
+F:	arch/arm/dts/rk3588-edgeble-neu6a-io-u-boot.dtsi
+F:	arch/arm/dts/rk3588-edgeble-neu6b.dtsi
+F:	arch/arm/dts/rk3588-edgeble-neu6b-io.dts
+F:	arch/arm/dts/rk3588-edgeble-neu6b-io-u-boot.dtsi
board/radxa/rock5a-rk3588s/MAINTAINERS +2 -0
index 62fb6b4c0eea..05750269b8dd 100644
@@ -4,3 +4,5 @@ S:	Maintained
  F:	board/radxa/rock5a-rk3588s
  F:	include/configs/rock5a-rk3588s.h
  F:	configs/rock5a-rk3588s_defconfig
+F:	arch/arm/dts/rk3588s-rock-5a.dts
+F:	arch/arm/dts/rk3588s-rock-5a-u-boot.dtsi
board/radxa/rock5b-rk3588/MAINTAINERS +3 -1
index 693751e583d9..734115a4a3dc 100644
@@ -2,5 +2,7 @@ ROCK5B-RK3588
  M:	Eugen Hristev <[email protected]>
  S:	Maintained
  F:	board/radxa/rock5b-rk3588
-F:	include/configs/rock5b-rk3588
+F:	include/configs/rock5b-rk3588.h
  F:	configs/rock5b-rk3588_defconfig
+F:	arch/arm/dts/rk3588-rock-5b.dts
+F:	arch/arm/dts/rk3588-rock-5b-u-boot.dtsi
board/rockchip/evb_rk3568/MAINTAINERS +27 -24
index 1cdeafcf79b2..5a2ec13e21ee 100644
@@ -1,13 +1,13 @@
  EVB-RK3568
-M:      Joseph Chen <[email protected]>
-S:      Maintained
-F:      board/rockchip/evb_rk3568
-F:      include/configs/evb_rk3568.h
-F:      configs/evb-rk3568_defconfig
-F:	arch/arm/dts/rk3568-evb-boot.dtsi
+M:	Joseph Chen <[email protected]>
+S:	Maintained
+F:	board/rockchip/evb_rk3568
+F:	include/configs/evb_rk3568.h
+F:	configs/evb-rk3568_defconfig
+F:	arch/arm/dts/rk3568-evb-u-boot.dtsi
  F:	arch/arm/dts/rk3568-evb.dts
 
-Lubancat-2
+LUBANCAT-2
  M:	Andy Yan <[email protected]>
  S:	Maintained
  F:	configs/lubancat-2-rk3568_defconfig
@@ -15,24 +15,27 @@ F:	arch/arm/dts/rk3568-lubancat-2.dts
  F:	arch/arm/dts/rk3568-lubancat-2-u-boot.dtsi
 
  NANOPI-R5C
-M:      Tianling Shen <[email protected]>
-S:      Maintained
-F:      configs/nanopi-r5c-rk3568_defconfig
-F:      arch/arm/dts/rk3568-nanopi-r5c.dts
-F:      arch/arm/dts/rk3568-nanopi-r5c-u-boot.dtsi
+M:	Tianling Shen <[email protected]>
+S:	Maintained
+F:	configs/nanopi-r5c-rk3568_defconfig
+F:	arch/arm/dts/rk3568-nanopi-r5c.dts
+F:	arch/arm/dts/rk3568-nanopi-r5c-u-boot.dtsi
 
  NANOPI-R5S
-M:      Tianling Shen <[email protected]>
-S:      Maintained
-F:      configs/nanopi-r5s-rk3568_defconfig
-F:      arch/arm/dts/rk3568-nanopi-r5s.dts
-F:      arch/arm/dts/rk3568-nanopi-r5s.dtsi
-F:      arch/arm/dts/rk3568-nanopi-r5s-u-boot.dtsi
+M:	Tianling Shen <[email protected]>
+S:	Maintained
+F:	configs/nanopi-r5s-rk3568_defconfig
+F:	arch/arm/dts/rk3568-nanopi-r5s.dts
+F:	arch/arm/dts/rk3568-nanopi-r5s.dtsi
+F:	arch/arm/dts/rk3568-nanopi-r5s-u-boot.dtsi
 
-RADXA-CM3
+RADXA-CM3-IO
  M:	Jagan Teki <[email protected]>
  S:	Maintained
  F:	configs/radxa-cm3-io-rk3566_defconfig
+F:	arch/arm/dts/rk3566-radxa-cm3.dtsi
+F:	arch/arm/dts/rk3566-radxa-cm3-io.dts
+F:	arch/arm/dts/rk3566-radxa-cm3-io-u-boot.dtsi
 
  RADXA-E25
  M:	Jonas Karlman <[email protected]>
@@ -43,8 +46,8 @@ F:	arch/arm/dts/rk3568-radxa-e25.dts
  F:	arch/arm/dts/rk3568-radxa-e25-u-boot.dtsi
 
  ROCK-3A
-M:      Akash Gajjar <[email protected]>
-S:      Maintained
-F:      configs/rock-3a-rk3568_defconfig
-F:      arch/arm/dts/rk3568-rock-3a.dts
-F:      arch/arm/dts/rk3568-rock-3a-u-boot.dtsi
+M:	Akash Gajjar <[email protected]>
+S:	Maintained
+F:	configs/rock-3a-rk3568_defconfig
+F:	arch/arm/dts/rk3568-rock-3a.dts
+F:	arch/arm/dts/rk3568-rock-3a-u-boot.dtsi
board/rockchip/evb_rk3588/MAINTAINERS +2 -1
index 7b7df3c5a8ac..6b2c257a1705 100644
@@ -4,4 +4,5 @@ S:	Maintained
  F:	board/rockchip/evb_rk3588
  F:	include/configs/evb_rk3588.h
  F:	configs/evb-rk3588_defconfig
-F:	arch/arm/dts/rk3588-evb-u-boot.dtsi
+F:	arch/arm/dts/rk3588-evb1-v10.dts
+F:	arch/arm/dts/rk3588-evb1-v10-u-boot.dtsi
#9 lore raw

Re: [PATCH 2/3] board: rockchip: rk35xx: Add device tree files to MAINTAINERS

Quoted 34 lines · Quentin Schulz

Hi Jonas,

Quoted 18 lines · Jonas Karlman

Update MAINTAINERS files for RK3566/RK3568/RK3588 boards to include related device tree files. Also replace space with tabs.

---
  board/anbernic/rgxx3_rk3566/MAINTAINERS       |  3 ++
  .../neural-compute-module-6/MAINTAINERS       |  6 +++
  board/radxa/rock5a-rk3588s/MAINTAINERS        |  2 +
  board/radxa/rock5b-rk3588/MAINTAINERS         |  4 +-
  board/rockchip/evb_rk3568/MAINTAINERS         | 51 ++++++++++---------
  board/rockchip/evb_rk3588/MAINTAINERS         |  3 +-
  6 files changed, 43 insertions(+), 26 deletions(-)
board/anbernic/rgxx3_rk3566/MAINTAINERS +0 -0
index 1c0d3fe7b5bf..6be16a47e8eb 100644

board/anbernic/rgxx3_rk3566/MAINTAINERS S: Maintained · line 9

Quoted 6 lines
board/anbernic/rgxx3_rk3566/MAINTAINERS +3 -0
@@ -4,3 +4,6 @@ S:	Maintained
  F:	board/anbernic/rgxx3_rk3566
  F:	include/configs/anbernic-rgxx3-rk3566.h
  F:	configs/anbernic-rgxx3_defconfig
+F:	arch/arm/dts/rk3566-anbernic-rgxx3.dts
+F:	arch/arm/dts/rk3566-anbernic-rgxx3.dtsi
+F:	arch/arm/dts/rk3566-anbernic-rgxx3-u-boot.dtsi

An easier way to deal with this is to use the "*" character since it's supported in MAINTAINERS file apparently (ag -Q "*" **/MAINTAINERS returns multiple matches in multiple files). So maybe replace it with something like

F: arch/arm/dts/rk3566-anbernic-rgxx3*

Quoted 8 lines

?

That way if the files eventually get split into multiple ones, get renamed, have one created (e.g. -u-boot.dtsi), they are all matched by that same line. Less maintenance here (and hopefully precise enough that we don't have false positives).

Just a suggestion,

Using the "N:" syntax might be better-still, since you could do:
N: anbernic-rgxx3
And that covers anything with anbernic-rgxx3 in the name.

Signature · 1 line
Tom
#11 lore raw

PATCH 3/3 board: rockchip: rk35xx: Add myself as reviewer to MAINTAINERS

In reply to Jonas Karlman

Add myself as a reviewer for RK3566/RK3568/RK3588 boards that I have and can help with review and testing of defconfig and device tree changes.

---
 board/radxa/rock5a-rk3588s/MAINTAINERS | 1 +
 board/radxa/rock5b-rk3588/MAINTAINERS  | 1 +
 board/rockchip/evb_rk3568/MAINTAINERS  | 4 ++++
 3 files changed, 6 insertions(+)
board/radxa/rock5a-rk3588s/MAINTAINERS +1 -0
index 05750269b8dd..a569efa74e3e 100644
@@ -1,5 +1,6 @@
 ROCK5A-RK3588
 M:	Eugen Hristev <[email protected]>
+R:	Jonas Karlman <[email protected]>
 S:	Maintained
 F:	board/radxa/rock5a-rk3588s
 F:	include/configs/rock5a-rk3588s.h
board/radxa/rock5b-rk3588/MAINTAINERS +1 -0
index 734115a4a3dc..4460c9971a96 100644
@@ -1,5 +1,6 @@
 ROCK5B-RK3588
 M:	Eugen Hristev <[email protected]>
+R:	Jonas Karlman <[email protected]>
 S:	Maintained
 F:	board/radxa/rock5b-rk3588
 F:	include/configs/rock5b-rk3588.h
board/rockchip/evb_rk3568/MAINTAINERS +4 -0
index 5a2ec13e21ee..cc9eb432a8b5 100644
@@ -16,6 +16,7 @@ F:	arch/arm/dts/rk3568-lubancat-2-u-boot.dtsi
 
 NANOPI-R5C
 M:	Tianling Shen <[email protected]>
+R:	Jonas Karlman <[email protected]>
 S:	Maintained
 F:	configs/nanopi-r5c-rk3568_defconfig
 F:	arch/arm/dts/rk3568-nanopi-r5c.dts
@@ -23,6 +24,7 @@ F:	arch/arm/dts/rk3568-nanopi-r5c-u-boot.dtsi
 
 NANOPI-R5S
 M:	Tianling Shen <[email protected]>
+R:	Jonas Karlman <[email protected]>
 S:	Maintained
 F:	configs/nanopi-r5s-rk3568_defconfig
 F:	arch/arm/dts/rk3568-nanopi-r5s.dts
@@ -31,6 +33,7 @@ F:	arch/arm/dts/rk3568-nanopi-r5s-u-boot.dtsi
 
 RADXA-CM3-IO
 M:	Jagan Teki <[email protected]>
+R:	Jonas Karlman <[email protected]>
 S:	Maintained
 F:	configs/radxa-cm3-io-rk3566_defconfig
 F:	arch/arm/dts/rk3566-radxa-cm3.dtsi
@@ -47,6 +50,7 @@ F:	arch/arm/dts/rk3568-radxa-e25-u-boot.dtsi
 
 ROCK-3A
 M:	Akash Gajjar <[email protected]>
+R:	Jonas Karlman <[email protected]>
 S:	Maintained
 F:	configs/rock-3a-rk3568_defconfig
 F:	arch/arm/dts/rk3568-rock-3a.dts
Signature · 1 line
2.41.0
Acked-by on v1 3/3
#12 lore raw

Re: [PATCH 3/3] board: rockchip: rk35xx: Add myself as reviewer to MAINTAINERS

Quoted 10 lines · Jonas Karlman

Add myself as a reviewer for RK3566/RK3568/RK3588 boards that I have and can help with review and testing of defconfig and device tree changes.

---
  board/radxa/rock5a-rk3588s/MAINTAINERS | 1 +
  board/radxa/rock5b-rk3588/MAINTAINERS  | 1 +
  board/rockchip/evb_rk3568/MAINTAINERS  | 4 ++++
  3 files changed, 6 insertions(+)

For rock5,