wireguard: Fix leaking sockets in wg_socket_init error paths
Subsystems (2)
PATCH 1/1 wireguard: Fix leaking sockets in wg_socket_init error paths
--- drivers/net/wireguard/socket.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
drivers/net/wireguard/socket.c +7 -2
@@ -387,7 +387,7 @@ int wg_socket_init(struct wg_device *wg, u16 port) ret =udp_sock_create (net, &port4, &new4);if (ret <0 ) {pr_err ("%s: Could not create IPv4 socket\n" , wg->dev->name); - goto out; + goto err; }set_sock_opts (new4);setup_udp_tunnel_sock (net, new4, &cfg);
@@ -402,7 +402,7 @@ int wg_socket_init(struct wg_device *wg, u16 port) goto retry;pr_err ("%s: Could not create IPv6 socket\n" , wg->dev->name); - goto out; + goto err; }set_sock_opts (new6);setup_udp_tunnel_sock (net, new6, &cfg);
@@ -414,6 +414,11 @@ int wg_socket_init(struct wg_device *wg, u16 port) out:put_net (net);return ret; + +err: +sock_free (new4 ? new4->sk :NULL ); +sock_free (new6 ? new6->sk :NULL ); + goto out; } void wg_socket_reinit(struct wg_device *wg, struct sock *new4,
Signature · 1 line
2.39.2