wireguard: Add netlink attrs for binding to address and netdev
Subsystems (2)
PATCH 1/1 wireguard: Add netlink attrs for binding to address and netdev
Multihomed hosts may want to run distinct wg tunnels across all their uplinks for redundant connectivity. Currently this entails picking different ports for each wg tunnel since we allow only binding to the wildcard address. Sharing a single port-number for all uplink connections (but bound to a particular IP/netdev) simplifies managment considerably.
A closely related use-case that also touches the socket binding code is having a wg socket be part of a VRF. This mirrors how we support socket and wg device in distinct namespaces. To make using VRFs with wg easy we want to be able to bind to a particular device as this will cause the kernel to automatically route all outgoing packets with the VRF's routing table and (in the default udp_l3mdev_accept=0 config) only accept packets from interfaces in the VRF without the need for netfilter rules.
While users can currently use VRFs for wg tunnel traffic by configuring fwmark ip-rules and setting sysctl udp_l3mdev_accept=1 (with or without additional nft filtering) this is at best a cludge. When VRF membership changes it becomes a major hassle to keep ip-rules up to date.
--- drivers/net/wireguard/device.c | 4 +-- drivers/net/wireguard/device.h | 3 +- drivers/net/wireguard/netlink.c | 51 ++++++++++++++++++++++++++++----- drivers/net/wireguard/socket.c | 41 +++++++++++++++++--------- drivers/net/wireguard/socket.h | 3 +- include/uapi/linux/wireguard.h | 6 ++++ 6 files changed, 83 insertions(+), 25 deletions(-)
drivers/net/wireguard/device.c +2 -2
@@ -48,7 +48,7 @@ static int wg_open(struct net_device *dev) dev_v6->cnf.addr_gen_mode =IN6_ADDR_GEN_MODE_NONE ;mutex_lock (&wg->device_update_lock); - ret =wg_socket_init (wg, wg->incoming_port); + ret =wg_socket_init (wg, wg->port_cfg);if (ret <0 ) goto out;list_for_each_entry (peer, &wg->peer_list, peer_list) {
@@ -249,7 +249,7 @@ static void wg_destruct(struct net_device *dev)rtnl_unlock ();mutex_lock (&wg->device_update_lock);rcu_assign_pointer (wg->creating_net,NULL ); - wg->incoming_port =0 ; +memzero_explicit (&wg->port_cfg,sizeof (wg->port_cfg));wg_socket_reinit (wg,NULL ,NULL );/* The final references are cleared in the below calls to destroy_workqueue. */ wg_peer_remove_all (wg);
drivers/net/wireguard/device.h +2 -1
@@ -17,6 +17,7 @@#include <linux/mutex.h> #include <linux/net.h> #include <linux/ptr_ring.h> +#include <net/udp_tunnel.h> struct wg_device ;
@@ -53,7 +54,7 @@ struct wg_device {atomic_t handshake_queue_len;unsigned int num_peers, device_update_gen;u32 fwmark; -u16 incoming_port; +struct udp_port_cfg port_cfg; };int wg_device_init (void );
drivers/net/wireguard/netlink.c +44 -7
88 lines not on this page · raw message
drivers/net/wireguard/socket.c +27 -14
89 lines not on this page · raw message
drivers/net/wireguard/socket.h +2 -1
@@ -10,8 +10,9 @@#include <linux/udp.h> #include <linux/if_vlan.h> #include <linux/if_ether.h> +#include <net/udp_tunnel.h> -int wg_socket_init (struct wg_device *wg,u16 port); +int wg_socket_init (struct wg_device *wg,struct udp_port_cfg port);void wg_socket_reinit (struct wg_device *wg,struct sock *new4,struct sock *new6); int wg_socket_send_buffer_to_peer(struct wg_peer *peer, void *data,
include/uapi/linux/wireguard.h +6 -0
@@ -28,6 +28,8 @@* WGDEVICE_A_PRIVATE_KEY: NLA_EXACT_LEN, len WG_KEY_LEN * WGDEVICE_A_PUBLIC_KEY: NLA_EXACT_LEN, len WG_KEY_LEN * WGDEVICE_A_LISTEN_PORT: NLA_U16 +* WGDEVICE_A_LISTEN_ADDR : NLA_MIN_LEN(struct sockaddr), struct sockaddr_in or struct sockaddr_in6 +* WGDEVICE_A_LISTEN_IFINDEX : NLA_U32 * WGDEVICE_A_FWMARK: NLA_U32 * WGDEVICE_A_PEERS: NLA_NESTED * 0: NLA_NESTED
@@ -82,6 +84,8 @@* peers should be removed prior to adding the list below. * WGDEVICE_A_PRIVATE_KEY: len WG_KEY_LEN, all zeros to remove * WGDEVICE_A_LISTEN_PORT: NLA_U16, 0 to choose randomly +* WGDEVICE_A_LISTEN_ADDR : struct sockaddr_in or struct sockaddr_in6. +* WGDEVICE_A_LISTEN_IFINDEX : NLA_U32 * WGDEVICE_A_FWMARK: NLA_U32, 0 to disable * WGDEVICE_A_PEERS: NLA_NESTED * 0: NLA_NESTED
@@ -157,6 +161,8 @@ enum wgdevice_attribute {WGDEVICE_A_LISTEN_PORT ,WGDEVICE_A_FWMARK ,WGDEVICE_A_PEERS , +WGDEVICE_A_LISTEN_ADDR , +WGDEVICE_A_LISTEN_IFINDEX , __WGDEVICE_A_LAST };#define WGDEVICE_A_MAX (__WGDEVICE_A_LAST - 1)
Signature · 1 line
2.39.2