Skip to contentSkip to conversation

arm: dts: mediatek: convert gmac link mode to 2500base-x for r3

PATCH In review Frank Wunderlich 3 participants 6 messages Aug 3, 2023 – Aug 29, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm: dts: mediatek: convert gmac link mode to 2500base-x for r3

From: Frank Wunderlich <[email protected]>

Ethernet on Bananapi-r3 is broken after

commit bd70f3cea353 ("net: mediatek: add support for SGMII 1Gbps auto-negotiation mode")

because changes from this commit were not applied to bpi-r3 devicetree too:

commit aef54ea16cac ("arm: dts: medaitek: convert gmac link mode to 2500base-x")

---
 arch/arm/dts/mt7986a-bpi-r3-sd.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/dts/mt7986a-bpi-r3-sd.dts +2 -2
index 15256302b86b..c156a8136343 100644
@@ -76,12 +76,12 @@
 &eth {
 	status = "okay";
 	mediatek,gmac-id = <0>;
-	phy-mode = "sgmii";
+	phy-mode = "2500base-x";
 	mediatek,switch = "mt7531";
 	reset-gpios = <&gpio 5 GPIO_ACTIVE_HIGH>;
 
 	fixed-link {
-		speed = <1000>;
+		speed = <2500>;
 		full-duplex;
 	};
 };
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Frank Wunderlich

From: Frank Wunderlich <[email protected]>

Ethernet on Bananapi-r3 is broken after

commit bd70f3cea353 ("net: mediatek: add support for SGMII 1Gbps auto-negotiation mode")

Quoted 8 lines

because changes from this commit were not applied to bpi-r3 devicetree too:

commit aef54ea16cac ("arm: dts: medaitek: convert gmac link mode to 2500base-x")

---

#2 lore raw
In reply to Frank Wunderlich
Quoted 4 lines · Frank Wunderlich

From: Frank Wunderlich <[email protected]>

Ethernet on Bananapi-r3 is broken after

Quoted 8 lines

commit bd70f3cea353 ("net: mediatek: add support for SGMII 1Gbps auto-negotiation mode")

because changes from this commit were not applied to bpi-r3 devicetree too:

commit aef54ea16cac ("arm: dts: medaitek: convert gmac link mode to 2500base-x")

Applied to u-boot/next, thanks!

Signature · 1 line
Tom
#3 lore raw

Am 18. August 2023 19:49:45 MESZ schrieb Tom Rini <[email protected]>:

Quoted 8 lines · Frank Wunderlich
Quoted 7 lines

From: Frank Wunderlich <[email protected]>

Ethernet on Bananapi-r3 is broken after

commit bd70f3cea353 ("net: mediatek: add support for SGMII 1Gbps auto-negotiation mode")

Quoted 11 lines
Quoted 6 lines

because changes from this commit were not applied to bpi-r3 devicetree too:

commit aef54ea16cac ("arm: dts: medaitek: convert gmac link mode to 2500base-x")

Applied to u-boot/next, thanks!

Signature · 1 line
Tom

Thx,but this leaves ethernet broken on 2023.10 for r3...could this be added to this release too?

regards Frank

#4 lore raw
Quoted 16 lines · Frank Wunderlich

Am 18. August 2023 19:49:45 MESZ schrieb Tom Rini <[email protected]>:

Quoted 15 lines · Frank Wunderlich
Quoted 13 lines

From: Frank Wunderlich <[email protected]>

Ethernet on Bananapi-r3 is broken after

commit bd70f3cea353 ("net: mediatek: add support for SGMII 1Gbps auto-negotiation mode")

because changes from this commit were not applied to bpi-r3 devicetree too:

commit aef54ea16cac ("arm: dts: medaitek: convert gmac link mode to 2500base-x")

Quoted 6 lines
Quoted 4 lines

Applied to u-boot/next, thanks!

Signature · 1 line
Tom

Thx,but this leaves ethernet broken on 2023.10 for r3...could this be added to this release too?

Ah, OK, I'll grab it for master too then, thanks. FWIW, some Fixes tags would have made it more clear as those stand out in patchwork.

Signature · 1 line
Tom
#5 lore raw
In reply to Frank Wunderlich
Quoted 4 lines · Frank Wunderlich

From: Frank Wunderlich <[email protected]>

Ethernet on Bananapi-r3 is broken after

Quoted 8 lines

commit bd70f3cea353 ("net: mediatek: add support for SGMII 1Gbps auto-negotiation mode")

because changes from this commit were not applied to bpi-r3 devicetree too:

commit aef54ea16cac ("arm: dts: medaitek: convert gmac link mode to 2500base-x")

Applied to u-boot/master, thanks!

Signature · 1 line
Tom