fixing ERROR: Macros with compex values must be enclosed within parentheses
Subsystems (2)
PATCH 1/1 fixing ERROR: Macros with compex values must be enclosed within parentheses
Signed-off-by Anshul <[email protected]>
--- drivers/media/usb/uvc/uvc_driver.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/media/usb/uvc/uvc_driver.c +2 -3
@@ -2417,9 +2417,8 @@ static const struct uvc_device_info uvc_quirk_force_y8 = { .quirks = UVC_QUIRK_FORCE_Y8, }; -#define UVC_INFO_QUIRK (q) (kernel_ulong_t)&(struct uvc_device_info){.quirks = q} -#define UVC_INFO_META (m) (kernel_ulong_t)&(struct uvc_device_info) \ - {.meta_format = m} +#define UVC_INFO_QUIRK (q) ((kernel_ulong_t)&(struct uvc_device_info){.quirks = q}) +#define UVC_INFO_META (m) ((kernel_ulong_t)&(struct uvc_device_info) {.meta_format = m})/* * The Logitech cameras listed below have their interface class set to
Signature · 1 line
2.41.0
Laurent Pinchart
maintainerHi Anshul,
On Sat, Aug 19, 2023 at 07:01:13PM +0530, Anshul wrote:
The commit message must explain *why* the change is useful. In this particular case, I don't think it is.
Quoted 21 lines
Signed-off-by Anshul <[email protected]>--- drivers/media/usb/uvc/uvc_driver.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)drivers/media/usb/uvc/uvc_driver.c +2
-3@@ -2417,9 +2417,8 @@ static const struct uvc_device_info uvc_quirk_force_y8 = { .quirks = UVC_QUIRK_FORCE_Y8, }; -#define UVC_INFO_QUIRK (q) (kernel_ulong_t)&(struct uvc_device_info){.quirks = q} -#define UVC_INFO_META (m) (kernel_ulong_t)&(struct uvc_device_info) \ - {.meta_format = m} +#define UVC_INFO_QUIRK (q) ((kernel_ulong_t)&(struct uvc_device_info){.quirks = q}) +#define UVC_INFO_META (m) ((kernel_ulong_t)&(struct uvc_device_info) {.meta_format = m})/* * The Logitech cameras listed below have their interface class set to
Signature · 3 lines
Regards, Laurent Pinchart