net: release reference to inet6_dev pointer
Subsystems (3)
PATCH v2 1/1 net: release reference to inet6_dev pointer
addrconf_prefix_rcv returned early without releasing the inet6_dev pointer when the PIO lifetime is less than accept_ra_min_lft.
Fixes 5027d54a9c30 ("net: change accept_ra_min_rtr_lft to affect all RA lifetimes")
Cc Maciej Żenczykowski <[email protected]>
Cc Lorenzo Colitti <[email protected]>
Cc David Ahern <[email protected]>
Cc Simon Horman <[email protected]>
Reviewed-by Simon Horman <[email protected]>
Reviewed-by Maciej Żenczykowski <[email protected]>
Signed-off-by Patrick Rohr <[email protected]>
--- net/ipv6/addrconf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/ipv6/addrconf.c +1 -1
@@ -2742,7 +2742,7 @@ void addrconf_prefix_rcv(struct net_device *dev, u8 *opt, int len, bool sllao) }if (valid_lft !=0 && valid_lft < in6_dev->cnf.accept_ra_min_lft) -return ; + goto put;/* * Two things going on here:
Signature · 1 line
2.42.0.rc1.204.g551eb34607-goog
Quoted 11 lines · Patrick Rohr
addrconf_prefix_rcvreturned early without releasing theinet6_devpointer when the PIO lifetime is less thanaccept_ra_min_lft.Fixes 5027d54a9c30 ("net: change accept_ra_min_rtr_lft to affect all RA lifetimes")Cc Maciej Żenczykowski <[email protected]>Cc Lorenzo Colitti <[email protected]>Cc David Ahern <[email protected]>Cc Simon Horman <[email protected]>Reviewed-by Simon Horman <[email protected]>Reviewed-by Maciej Żenczykowski <[email protected]>Signed-off-by Patrick Rohr <[email protected]>
Quoted 3 lines
--- net/ipv6/addrconf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks,
Reviewed-by Leon Romanovsky <[email protected]>
This patch was applied to netdev/net-next.git (main) by David S. Miller <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (main) by David S. Miller <[email protected]>:
Quoted 12 lines · On Fri, 18 Aug 2023 11:22:49 -0700 you wrote:
addrconf_prefix_rcvreturned early without releasing theinet6_devpointer when the PIO lifetime is less thanaccept_ra_min_lft.Fixes 5027d54a9c30 ("net: change accept_ra_min_rtr_lft to affect all RA lifetimes")Cc Maciej Żenczykowski <[email protected]>Cc Lorenzo Colitti <[email protected]>Cc David Ahern <[email protected]>Cc Simon Horman <[email protected]>Reviewed-by Simon Horman <[email protected]>Reviewed-by Maciej Żenczykowski <[email protected]>Signed-off-by Patrick Rohr <[email protected]>
Quoted 1 line
[...]
Here is the summary with links:
- [net-next,v2] net: release reference to inet6_dev pointer
https://git.kernel.org/netdev/net-next/c/5cb249686e67
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html