Skip to contentSkip to conversation

Document Sponsored-by tag

PATCH In review Giulio Benetti 1 participant 3 messages Aug 19, 2023 – Sep 11, 2023

lore
Share & tools
lore
#0 lore raw

cover Document Sponsored-by tag

Hi All,

I'm trying to add Sponsored-by tag to give credits to Companies or Physical Persons who sponsor the writing and/or the upstreaming process of a patch. The goal, as described in the commit log, is to increase their involvement into upstreaming patches that are otherwise kept private. The customers I work for are interested in this and I've recently sent a patch for this to Linux too:
https://lore.kernel.org/all/[email protected]/
where I've received 2 feedbacks more or less positive.
I'm not promising that with the use of Sponsored-by: tag the patches will hugely increase, but for me it's worth to try.

Let me know what you all think about it.

Thank you!
Best regards
Giulio Benetti

Giulio Benetti (1):
docs/manual: add Sponsored-by tag

 docs/manual/contribute.txt | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
Signature · 6 lines
2.34.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

PATCH 1/1 docs/manual: add Sponsored-by tag

Sometimes it happens that a Company or a Physical Person sponsors the creation and/or the upstreaming process of a patch, but at the moment there is no way to give credits to it. In Linux there are some commit that include a sort of tag "Sponsored by" without the dash to avoid scripts/checkpatch.pl to complain but a real standard has not been defined. With this patch let's try to define a method to give credits consistently. The goal is to improve contributions from companies or physical persons that this way should gain visibility in Buildroot and so they should be more prone to let the work done for them for to be upstreamed.

---
 docs/manual/contribute.txt | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
docs/manual/contribute.txt +6 -1
index 94f1c64496..384fdb08c1 100644
@@ -118,6 +118,11 @@ Acked-by:: Indicates that you code-reviewed the patch and you are
   Reviewed-by is thus mainly that you are prepared to take the blame on
   Acked patches, but not on Reviewed ones.
 
+Sponsored-by:: Indicates that someone sponsored the creation and/or the
+  upstreaming process of the patch. Sponsored-by can contain a company
+  name or a physical person name plus its e-mail the same way it's done
+  for the other tags listed above.
+
 If you reviewed a patch and have comments on it, you should simply reply
 to the patch stating these comments, without providing a Reviewed-by or
 Acked-by tag. These tags should only be provided if you judge the patch
@@ -128,7 +133,7 @@ that testing has been performed. To indicate that you both reviewed and
 tested the patch, provide two separate tags (Reviewed/Acked-by and
 Tested-by).
 
-Note also that _any developer_ can provide Tested/Reviewed/Acked-by
+Note also that _any developer_ can provide Tested/Reviewed/Acked-by/Sponsored-by
 tags, without exception, and we encourage everyone to do this. Buildroot
 does not have a defined group of _core_ developers, it just so happens
 that some developers are more active than others. The maintainer will
Signature · 6 lines
2.34.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#2 lore raw

Re: [Buildroot] [PATCH 1/1] docs/manual: add Sponsored-by tag

Hello All,

Quoted 32 lines · Giulio Benetti

Sometimes it happens that a Company or a Physical Person sponsors the creation and/or the upstreaming process of a patch, but at the moment there is no way to give credits to it. In Linux there are some commit that include a sort of tag "Sponsored by" without the dash to avoid scripts/checkpatch.pl to complain but a real standard has not been defined. With this patch let's try to define a method to give credits consistently. The goal is to improve contributions from companies or physical persons that this way should gain visibility in Buildroot and so they should be more prone to let the work done for them for to be upstreamed.

---
  docs/manual/contribute.txt | 7 ++++++-
  1 file changed, 6 insertions(+), 1 deletion(-)
docs/manual/contribute.txt +5 -0
index 94f1c64496..384fdb08c1 100644
@@ -118,6 +118,11 @@ Acked-by:: Indicates that you code-reviewed the patch and you are
    Reviewed-by is thus mainly that you are prepared to take the blame on
    Acked patches, but not on Reviewed ones.
 
+Sponsored-by:: Indicates that someone sponsored the creation and/or the
+  upstreaming process of the patch. Sponsored-by can contain a company
+  name or a physical person name plus its e-mail the same way it's done
+  for the other tags listed above.
+
  If you reviewed a patch and have comments on it, you should simply reply
  to the patch stating these comments, without providing a Reviewed-by or
  Acked-by tag. These tags should only be provided if you judge the patch

docs/manual/contribute.txt that testing has been performed. To indicate that you both reviewed and · line 139

Quoted 8 lines
docs/manual/contribute.txt +1 -1
@@ -128,7 +133,7 @@ that testing has been performed. To indicate that you both reviewed and
  tested the patch, provide two separate tags (Reviewed/Acked-by and
  Tested-by).
 
-Note also that _any developer_ can provide Tested/Reviewed/Acked-by
+Note also that _any developer_ can provide Tested/Reviewed/Acked-by/Sponsored-by
  tags, without exception, and we encourage everyone to do this. Buildroot
  does not have a defined group of _core_ developers, it just so happens
  that some developers are more active than others. The maintainer will

after sending the same proposal to Linux Kernel Mailing List I've found that there already are 2 possible ways to give credits to the sponsor:
Name Surname (Sponsor) <[email protected]>
or
Name Surname <[email protected]>

The latter is the most used at the moment so I send a V2 of this patch describing it.

Best regards

Signature · 6 lines
Giulio Benetti
CEO&CTO@Benetti Engineering sas
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot