tools/nolibc: x86_64: Make it compile with -pie
Subsystems (2)
RFC 1/1 tools/nolibc: x86_64: Make it compile with -pie
Use RIP-relative addressing when setting environ and _auxv in startup code.
Some toolchains have -pie enabled by default. On them or when -pie is specified manually gcc produces error like this:
ld: /tmp/cci0uPcR.o: relocation R_X86_64_32S against symbol `environ' can not be used when making a PIE object; recompile with -fPIE
ld: failed to set dynamic section sizes: bad value
This is because asm() startup code accesses there pointers with absolute addressing.
This may inspire others to fix the problem for other architectures too.
--- tools/include/nolibc/arch-x86_64.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
tools/include/nolibc/arch-x86_64.h +2 -2
@@ -199,14 +199,14 @@ void __attribute__((weak,noreturn,optimize("omit-frame-pointer"))) __no_stack_pr"pop %rdi\n" /* argc (first arg, %rdi) */ "mov %rsp, %rsi\n" /* argv[] (second arg, %rsi) */ "lea 8(%rsi,%rdi,8),%rdx\n" /* then a NULL then envp (third arg, %rdx) */ -"mov %rdx, environ\n" /* save environ */ +"mov %rdx, environ(%rip)\n" /* save environ */ "xor %ebp, %ebp\n" /* zero the stack frame */ "mov %rdx, %rax\n" /* search for auxv (follows NULL after last env) */ "0:\n" "add $8, %rax\n" /* search for auxv using rax, it follows the */ "cmp -8(%rax), %rbp\n" /* ... NULL after last env (rbp is zero here) */ "jnz 0b\n" -"mov %rax, _auxv\n" /* save it into _auxv */ +"mov %rax, _auxv(%rip)\n" /* save it into _auxv */ "and $-16, %rsp\n" /* x86 ABI : esp must be 16-byte aligned before call */ "call main\n" /* main() returns the status code, we'll exit with it. */ "mov %eax, %edi\n" /* retrieve exit code (32 bit) */
Signature · 1 line
2.33.8
Hi Vitaly,
Quoted 43 lines · Vitaly Chikunov
Use RIP-relative addressing when setting
environand_auxvin startup code.Some toolchains have
-pieenabled by default. On them or when -pie is specified manually gcc produces error like this:ld:
/tmp/cci0uPcR.o: relocationR_X86_64_32Sagainst symbol `environ' can not be used when making a PIE object; recompile with -fPIE
ld: failed to set dynamic section sizes: bad valueThis is because
asm()startup code accesses there pointers with absolute addressing.This may inspire others to fix the problem for other architectures too.
Signed-off-by Vitaly Chikunov <[email protected]>--- tools/include/nolibc/arch-x86_64.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)tools/include/nolibc/arch-x86_64.h +2
-2@@ -199,14 +199,14 @@ void __attribute__((weak,noreturn,optimize("omit-frame-pointer"))) __no_stack_pr"pop %rdi\n" /* argc (first arg, %rdi) */ "mov %rsp, %rsi\n" /* argv[] (second arg, %rsi) */ "lea 8(%rsi,%rdi,8),%rdx\n" /* then a NULL then envp (third arg, %rdx) */ -"mov %rdx, environ\n" /* save environ */ +"mov %rdx, environ(%rip)\n" /* save environ */ "xor %ebp, %ebp\n" /* zero the stack frame */ "mov %rdx, %rax\n" /* search for auxv (follows NULL after last env) */ "0:\n" "add $8, %rax\n" /* search for auxv using rax, it follows the */ "cmp -8(%rax), %rbp\n" /* ... NULL after last env (rbp is zero here) */ "jnz 0b\n" -"mov %rax, _auxv\n" /* save it into _auxv */ +"mov %rax, _auxv(%rip)\n" /* save it into _auxv */ "and $-16, %rsp\n" /* x86 ABI : esp must be 16-byte aligned before call */ "call main\n" /* main() returns the status code, we'll exit with it. */ "mov %eax, %edi\n" /* retrieve exit code (32 bit) */ Signature · 1 line
2.33.8
nolibc recently switched to startup code that is mostly implemented in C instead of assembly.
See the current linux-next tree.
That should make this change unnecessary I guess.
Thomas
Thomas,
Quoted 49 lines · Thomas Weißschuh
Quoted 43 lines · Vitaly Chikunov
Use RIP-relative addressing when setting
environand_auxvin startup code.Some toolchains have
-pieenabled by default. On them or when -pie is specified manually gcc produces error like this:ld:
/tmp/cci0uPcR.o: relocationR_X86_64_32Sagainst symbol `environ' can not be used when making a PIE object; recompile with -fPIE
ld: failed to set dynamic section sizes: bad valueThis is because
asm()startup code accesses there pointers with absolute addressing.This may inspire others to fix the problem for other architectures too.
Signed-off-by Vitaly Chikunov <[email protected]>--- tools/include/nolibc/arch-x86_64.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)tools/include/nolibc/arch-x86_64.h +2
-2@@ -199,14 +199,14 @@ void __attribute__((weak,noreturn,optimize("omit-frame-pointer"))) __no_stack_pr"pop %rdi\n" /* argc (first arg, %rdi) */ "mov %rsp, %rsi\n" /* argv[] (second arg, %rsi) */ "lea 8(%rsi,%rdi,8),%rdx\n" /* then a NULL then envp (third arg, %rdx) */ -"mov %rdx, environ\n" /* save environ */ +"mov %rdx, environ(%rip)\n" /* save environ */ "xor %ebp, %ebp\n" /* zero the stack frame */ "mov %rdx, %rax\n" /* search for auxv (follows NULL after last env) */ "0:\n" "add $8, %rax\n" /* search for auxv using rax, it follows the */ "cmp -8(%rax), %rbp\n" /* ... NULL after last env (rbp is zero here) */ "jnz 0b\n" -"mov %rax, _auxv\n" /* save it into _auxv */ +"mov %rax, _auxv(%rip)\n" /* save it into _auxv */ "and $-16, %rsp\n" /* x86 ABI : esp must be 16-byte aligned before call */ "call main\n" /* main() returns the status code, we'll exit with it. */ "mov %eax, %edi\n" /* retrieve exit code (32 bit) */ Signature · 1 line
2.33.8nolibc recently switched to startup code that is mostly implemented in C instead of assembly.
See the current linux-next tree.
Quoted 1 line
That should make this change unnecessary I guess.
Yes seems so! Zhangjin Wu done a fine job.
Thanks,
Quoted 3 lines
Thomas