Add debugfs pm_status for qat driver
Subsystems (20)
cover Add debugfs pm_status for qat driver
Add debugfs pm_status.
Expose power management info by providing the "pm_status" file under debugfs.
Patch #1 has been added to this pathcset in order to add ARRAY_SIZE_OF_FIELD() (Patch #2) without expanding kernel.h
---
Alejandro Colomar (1):
linux/array_size.h: Move ARRAY_SIZE(arr) to a separate header
Lucas Segarra Fernandez (3):
linux/array_size.h: Add ARRAY_SIZE_OF_FIELD()
crypto: qat - refactor included headers
crypto: qat - add pm_status debugfs file
Documentation/ABI/testing/debugfs-driver-qat | 9 + drivers/crypto/intel/qat/qat_common/Makefile | 1 + .../intel/qat/qat_common/adf_accel_devices.h | 13 + .../crypto/intel/qat/qat_common/adf_admin.c | 25 ++ .../intel/qat/qat_common/adf_common_drv.h | 1 + .../crypto/intel/qat/qat_common/adf_dbgfs.c | 3 + .../crypto/intel/qat/qat_common/adf_gen4_pm.c | 265 ++++++++++++++++++ .../crypto/intel/qat/qat_common/adf_gen4_pm.h | 38 ++- .../intel/qat/qat_common/adf_pm_dbgfs.c | 47 ++++ .../intel/qat/qat_common/adf_pm_dbgfs.h | 12 + .../qat/qat_common/icp_qat_fw_init_admin.h | 33 +++ include/linux/array_size.h | 21 ++ include/linux/clk-provider.h | 1 + include/linux/counter.h | 1 + include/linux/genl_magic_func.h | 1 + include/linux/hashtable.h | 1 + include/linux/kernel.h | 7 +- include/linux/kfifo.h | 1 + include/linux/kvm_host.h | 1 + include/linux/moduleparam.h | 2 + include/linux/mtd/rawnand.h | 1 + include/linux/netfilter.h | 1 + include/linux/pagemap.h | 1 + include/linux/phy.h | 1 + include/linux/pinctrl/machine.h | 2 +- include/linux/property.h | 1 + include/linux/rcupdate_wait.h | 1 + include/linux/regmap.h | 1 + include/linux/skmsg.h | 1 + include/linux/string.h | 1 + include/linux/surface_aggregator/controller.h | 1 + 31 files changed, 487 insertions(+), 8 deletions(-) create mode 100644 drivers/crypto/intel/qat/qat_common/adf_pm_dbgfs.c create mode 100644 drivers/crypto/intel/qat/qat_common/adf_pm_dbgfs.h create mode 100644 include/linux/array_size.h
Signature · 1 line
2.41.0
PATCH 1/4 linux/array_size.h: Move ARRAY_SIZE(arr) to a separate header
From: Alejandro Colomar <[email protected]>
Touching files so used for the kernel,
forces 'make' to recompile most of the kernel.
Having those definitions in more granular files
helps avoid recompiling so much of the kernel.
--- include/linux/array_size.h | 13 +++++++++++++ include/linux/clk-provider.h | 1 + include/linux/counter.h | 1 + include/linux/genl_magic_func.h | 1 + include/linux/hashtable.h | 1 + include/linux/kernel.h | 7 +------ include/linux/kfifo.h | 1 + include/linux/kvm_host.h | 1 + include/linux/moduleparam.h | 2 ++ include/linux/mtd/rawnand.h | 1 + include/linux/netfilter.h | 1 + include/linux/pagemap.h | 1 + include/linux/phy.h | 1 + include/linux/pinctrl/machine.h | 2 +- include/linux/property.h | 1 + include/linux/rcupdate_wait.h | 1 + include/linux/regmap.h | 1 + include/linux/skmsg.h | 1 + include/linux/string.h | 1 + include/linux/surface_aggregator/controller.h | 1 + 20 files changed, 33 insertions(+), 7 deletions(-) create mode 100644 include/linux/array_size.h
include/linux/array_size.h new file +13 -0
@@ -0,0 +1,13 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef _LINUX_ARRAY_SIZE_H +#define _LINUX_ARRAY_SIZE_H + +#include <linux/compiler.h> + +/** +* ARRAY_SIZE - get the number of elements in array @arr +* @arr: array to be sized +*/ +#define ARRAY_SIZE (arr) (sizeof(arr) / sizeof((arr)[0]) + __must_be_array(arr)) + +#endif /* _LINUX_ARRAY_SIZE_H */
include/linux/clk-provider.h +1 -0
@@ -6,6 +6,7 @@#ifndef __LINUX_CLK_PROVIDER_H#define __LINUX_CLK_PROVIDER_H +#include <linux/array_size.h> #include <linux/of.h> #include <linux/of_clk.h>
include/linux/counter.h +1 -0
@@ -6,6 +6,7 @@#ifndef _COUNTER_H_#define _COUNTER_H_ +#include <linux/array_size.h> #include <linux/cdev.h> #include <linux/device.h> #include <linux/kernel.h>
include/linux/genl_magic_func.h +1 -0
@@ -2,6 +2,7 @@#ifndef GENL_MAGIC_FUNC_H #define GENL_MAGIC_FUNC_H +#include <linux/array_size.h> #include <linux/build_bug.h> #include <linux/genl_magic_struct.h>
include/linux/hashtable.h +1 -0
@@ -7,6 +7,7 @@#ifndef _LINUX_HASHTABLE_H#define _LINUX_HASHTABLE_H +#include <linux/array_size.h> #include <linux/list.h> #include <linux/types.h> #include <linux/kernel.h>
include/linux/kernel.h +1 -6
@@ -11,6 +11,7 @@#ifndef _LINUX_KERNEL_H#define _LINUX_KERNEL_H +#include <linux/array_size.h> #include <linux/stdarg.h> #include <linux/align.h> #include <linux/limits.h>
@@ -49,12 +50,6 @@#define READ 0#define WRITE 1 -/** -* ARRAY_SIZE - get the number of elements in array @arr -* @arr: array to be sized -*/ -#define ARRAY_SIZE (arr) (sizeof(arr) / sizeof((arr)[0]) + __must_be_array(arr)) -#define PTR_IF (cond, ptr) ((cond) ? (ptr) : NULL)#define u64_to_user_ptr (x) ( \
include/linux/kfifo.h +1 -0
@@ -36,6 +36,7 @@* to lock the reader. */ +#include <linux/array_size.h> #include <linux/kernel.h> #include <linux/spinlock.h> #include <linux/stddef.h>
include/linux/kvm_host.h +1 -0
@@ -3,6 +3,7 @@#define __KVM_HOST_H +#include <linux/array_size.h> #include <linux/types.h> #include <linux/hardirq.h> #include <linux/list.h>
include/linux/moduleparam.h +2 -0
@@ -2,6 +2,8 @@#ifndef _LINUX_MODULE_PARAMS_H#define _LINUX_MODULE_PARAMS_H/* (C) Copyright 2001, 2002 Rusty Russell IBM Corporation */ + +#include <linux/array_size.h> #include <linux/init.h> #include <linux/stringify.h> #include <linux/kernel.h>
include/linux/mtd/rawnand.h +1 -0
@@ -13,6 +13,7 @@#ifndef __LINUX_MTD_RAWNAND_H#define __LINUX_MTD_RAWNAND_H +#include <linux/array_size.h> #include <linux/mtd/mtd.h> #include <linux/mtd/nand.h> #include <linux/mtd/flashchip.h>
include/linux/netfilter.h +1 -0
@@ -2,6 +2,7 @@#ifndef __LINUX_NETFILTER_H#define __LINUX_NETFILTER_H +#include <linux/array_size.h> #include <linux/init.h> #include <linux/skbuff.h> #include <linux/net.h>
include/linux/pagemap.h +1 -0
@@ -5,6 +5,7 @@/* * Copyright 1995 Linus Torvalds */ +#include <linux/array_size.h> #include <linux/mm.h> #include <linux/fs.h> #include <linux/list.h>
include/linux/phy.h +1 -0
@@ -11,6 +11,7 @@#ifndef __PHY_H#define __PHY_H +#include <linux/array_size.h> #include <linux/compiler.h> #include <linux/spinlock.h> #include <linux/ethtool.h>
include/linux/pinctrl/machine.h +1 -1
@@ -11,7 +11,7 @@#ifndef __LINUX_PINCTRL_MACHINE_H#define __LINUX_PINCTRL_MACHINE_H -#include <linux/kernel.h> /* ARRAY_SIZE() */ +#include <linux/array_size.h> #include <linux/pinctrl/pinctrl-state.h>
include/linux/property.h +1 -0
@@ -10,6 +10,7 @@#ifndef _LINUX_PROPERTY_H_#define _LINUX_PROPERTY_H_ +#include <linux/array_size.h> #include <linux/bits.h> #include <linux/fwnode.h> #include <linux/stddef.h>
include/linux/rcupdate_wait.h +1 -0
@@ -6,6 +6,7 @@* RCU synchronization types and methods: */ +#include <linux/array_size.h> #include <linux/rcupdate.h> #include <linux/completion.h>
include/linux/regmap.h +1 -0
@@ -10,6 +10,7 @@* Author: Mark Brown <[email protected]> */ +#include <linux/array_size.h> #include <linux/list.h> #include <linux/rbtree.h> #include <linux/ktime.h>
include/linux/skmsg.h +1 -0
@@ -4,6 +4,7 @@#ifndef _LINUX_SKMSG_H#define _LINUX_SKMSG_H +#include <linux/array_size.h> #include <linux/bpf.h> #include <linux/filter.h> #include <linux/scatterlist.h>
include/linux/string.h +1 -0
@@ -2,6 +2,7 @@#ifndef _LINUX_STRING_H_#define _LINUX_STRING_H_ +#include <linux/array_size.h> #include <linux/compiler.h> /* for inline */ #include <linux/types.h> /* for size_t */ #include <linux/stddef.h> /* for NULL */
include/linux/surface_aggregator/controller.h +1 -0
@@ -12,6 +12,7 @@#ifndef _LINUX_SURFACE_AGGREGATOR_CONTROLLER_H#define _LINUX_SURFACE_AGGREGATOR_CONTROLLER_H +#include <linux/array_size.h> #include <linux/completion.h> #include <linux/device.h> #include <linux/types.h>
Signature · 1 line
2.41.0
Re: [PATCH 1/4] linux/array_size.h: Move ARRAY_SIZE(arr) to a separate header
Hi Lucas,
Quoted 11 lines · Lucas Segarra Fernandez
From: Alejandro Colomar <[email protected]>
Touching files so used for the kernel,
forces 'make' to recompile most of the kernel.Having those definitions in more granular files
helps avoid recompiling so much of the kernel.Signed-off-by Alejandro Colomar <[email protected]>Reviewed-by Giovanni Cabiddu <[email protected]>Reviewed-by Andy Shevchenko <[email protected]>
Heh! This is really really old, isn't it? :p
Would you mind updating my email to use the kernel.org address?
From: Alejandro Colomar <[email protected]>
Thanks for taking care of this patch!
Cheers,
Alex
Quoted 286 lines
--- include/linux/array_size.h | 13 +++++++++++++ include/linux/clk-provider.h | 1 + include/linux/counter.h | 1 + include/linux/genl_magic_func.h | 1 + include/linux/hashtable.h | 1 + include/linux/kernel.h | 7 +------ include/linux/kfifo.h | 1 + include/linux/kvm_host.h | 1 + include/linux/moduleparam.h | 2 ++ include/linux/mtd/rawnand.h | 1 + include/linux/netfilter.h | 1 + include/linux/pagemap.h | 1 + include/linux/phy.h | 1 + include/linux/pinctrl/machine.h | 2 +- include/linux/property.h | 1 + include/linux/rcupdate_wait.h | 1 + include/linux/regmap.h | 1 + include/linux/skmsg.h | 1 + include/linux/string.h | 1 + include/linux/surface_aggregator/controller.h | 1 + 20 files changed, 33 insertions(+), 7 deletions(-) create mode 100644 include/linux/array_size.hinclude/linux/array_size.h new file +13
-0@@ -0,0 +1,13 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef _LINUX_ARRAY_SIZE_H +#define _LINUX_ARRAY_SIZE_H + +#include <linux/compiler.h> + +/** +* ARRAY_SIZE - get the number of elements in array @arr +* @arr: array to be sized +*/ +#define ARRAY_SIZE (arr) (sizeof(arr) / sizeof((arr)[0]) + __must_be_array(arr)) + +#endif /* _LINUX_ARRAY_SIZE_H */ include/linux/clk-provider.h +1
-0@@ -6,6 +6,7 @@#ifndef __LINUX_CLK_PROVIDER_H#define __LINUX_CLK_PROVIDER_H +#include <linux/array_size.h> #include <linux/of.h> #include <linux/of_clk.h> include/linux/counter.h +1
-0@@ -6,6 +6,7 @@#ifndef _COUNTER_H_#define _COUNTER_H_ +#include <linux/array_size.h> #include <linux/cdev.h> #include <linux/device.h> #include <linux/kernel.h> include/linux/genl_magic_func.h +1
-0@@ -2,6 +2,7 @@#ifndef GENL_MAGIC_FUNC_H #define GENL_MAGIC_FUNC_H +#include <linux/array_size.h> #include <linux/build_bug.h> #include <linux/genl_magic_struct.h> include/linux/hashtable.h +1
-0@@ -7,6 +7,7 @@#ifndef _LINUX_HASHTABLE_H#define _LINUX_HASHTABLE_H +#include <linux/array_size.h> #include <linux/list.h> #include <linux/types.h> #include <linux/kernel.h> include/linux/kernel.h +1
-6@@ -11,6 +11,7 @@#ifndef _LINUX_KERNEL_H#define _LINUX_KERNEL_H +#include <linux/array_size.h> #include <linux/stdarg.h> #include <linux/align.h> #include <linux/limits.h> @@ -49,12 +50,6 @@#define READ 0#define WRITE 1 -/** -* ARRAY_SIZE - get the number of elements in array @arr -* @arr: array to be sized -*/ -#define ARRAY_SIZE (arr) (sizeof(arr) / sizeof((arr)[0]) + __must_be_array(arr)) -#define PTR_IF (cond, ptr) ((cond) ? (ptr) : NULL)#define u64_to_user_ptr (x) ( \include/linux/kfifo.h +1
-0@@ -36,6 +36,7 @@* to lock the reader. */ +#include <linux/array_size.h> #include <linux/kernel.h> #include <linux/spinlock.h> #include <linux/stddef.h> include/linux/kvm_host.h +1
-0@@ -3,6 +3,7 @@#define __KVM_HOST_H +#include <linux/array_size.h> #include <linux/types.h> #include <linux/hardirq.h> #include <linux/list.h> include/linux/moduleparam.h +2
-0@@ -2,6 +2,8 @@#ifndef _LINUX_MODULE_PARAMS_H#define _LINUX_MODULE_PARAMS_H/* (C) Copyright 2001, 2002 Rusty Russell IBM Corporation */ + +#include <linux/array_size.h> #include <linux/init.h> #include <linux/stringify.h> #include <linux/kernel.h> include/linux/mtd/rawnand.h +1
-0@@ -13,6 +13,7 @@#ifndef __LINUX_MTD_RAWNAND_H#define __LINUX_MTD_RAWNAND_H +#include <linux/array_size.h> #include <linux/mtd/mtd.h> #include <linux/mtd/nand.h> #include <linux/mtd/flashchip.h> include/linux/netfilter.h +1
-0@@ -2,6 +2,7 @@#ifndef __LINUX_NETFILTER_H#define __LINUX_NETFILTER_H +#include <linux/array_size.h> #include <linux/init.h> #include <linux/skbuff.h> #include <linux/net.h> include/linux/pagemap.h +1
-0@@ -5,6 +5,7 @@/* * Copyright 1995 Linus Torvalds */ +#include <linux/array_size.h> #include <linux/mm.h> #include <linux/fs.h> #include <linux/list.h> include/linux/phy.h +1
-0@@ -11,6 +11,7 @@#ifndef __PHY_H#define __PHY_H +#include <linux/array_size.h> #include <linux/compiler.h> #include <linux/spinlock.h> #include <linux/ethtool.h> include/linux/pinctrl/machine.h +1
-1@@ -11,7 +11,7 @@#ifndef __LINUX_PINCTRL_MACHINE_H#define __LINUX_PINCTRL_MACHINE_H -#include <linux/kernel.h> /* ARRAY_SIZE() */ +#include <linux/array_size.h> #include <linux/pinctrl/pinctrl-state.h> include/linux/property.h +1
-0@@ -10,6 +10,7 @@#ifndef _LINUX_PROPERTY_H_#define _LINUX_PROPERTY_H_ +#include <linux/array_size.h> #include <linux/bits.h> #include <linux/fwnode.h> #include <linux/stddef.h> include/linux/rcupdate_wait.h +1
-0@@ -6,6 +6,7 @@* RCU synchronization types and methods: */ +#include <linux/array_size.h> #include <linux/rcupdate.h> #include <linux/completion.h> include/linux/regmap.h +1
-0@@ -10,6 +10,7 @@* Author: Mark Brown <[email protected]> */ +#include <linux/array_size.h> #include <linux/list.h> #include <linux/rbtree.h> #include <linux/ktime.h> include/linux/skmsg.h +1
-0@@ -4,6 +4,7 @@#ifndef _LINUX_SKMSG_H#define _LINUX_SKMSG_H +#include <linux/array_size.h> #include <linux/bpf.h> #include <linux/filter.h> #include <linux/scatterlist.h> include/linux/string.h +1
-0@@ -2,6 +2,7 @@#ifndef _LINUX_STRING_H_#define _LINUX_STRING_H_ +#include <linux/array_size.h> #include <linux/compiler.h> /* for inline */ #include <linux/types.h> /* for size_t */ #include <linux/stddef.h> /* for NULL */ include/linux/surface_aggregator/controller.h +1
-0@@ -12,6 +12,7 @@#ifndef _LINUX_SURFACE_AGGREGATOR_CONTROLLER_H#define _LINUX_SURFACE_AGGREGATOR_CONTROLLER_H +#include <linux/array_size.h> #include <linux/completion.h> #include <linux/device.h> #include <linux/types.h>
Signature · 2 lines
<http://www.alejandro-colomar.es/> GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5
PATCH 2/4 linux/array_size.h: Add ARRAY_SIZE_OF_FIELD()
In reply to Lucas Segarra FernandezIntroduce ARRAY_SIZE_OF_FIELD() in order to get the number of elements of an array struct field.
--- include/linux/array_size.h | 8 ++++++++ 1 file changed, 8 insertions(+)
include/linux/array_size.h +8 -0
@@ -10,4 +10,12 @@*/ #define ARRAY_SIZE (arr) (sizeof(arr) / sizeof((arr)[0]) + __must_be_array(arr)) +/* +* ARRAY_SIZE_OF_FIELD - get the number of elements of an array struct field +* +* @TYPE: The structure containing the field of interest +* @MEMBER: The array field to be sized +*/ +#define ARRAY_SIZE_OF_FIELD (TYPE ,MEMBER ) ARRAY_SIZE((((TYPE *)0)->MEMBER)) +#endif /* _LINUX_ARRAY_SIZE_H */
Signature · 1 line
2.41.0
Re: [PATCH 2/4] linux/array_size.h: Add ARRAY_SIZE_OF_FIELD()
Hi Lucas,
Quoted 15 lines · Lucas Segarra Fernandez
Introduce
ARRAY_SIZE_OF_FIELD()in order to get the number of elements of an array struct field.Signed-off-by Lucas Segarra Fernandez <[email protected]>Reviewed-by Giovanni Cabiddu <[email protected]>Reviewed-by Andy Shevchenko <[email protected]>--- include/linux/array_size.h | 8 ++++++++ 1 file changed, 8 insertions(+)include/linux/array_size.h +0
-0
include/linux/array_size.h line 19
Quoted 10 lines
include/linux/array_size.h +7
-0@@ -10,4 +10,12 @@*/ #define ARRAY_SIZE (arr) (sizeof(arr) / sizeof((arr)[0]) + __must_be_array(arr)) +/* +* ARRAY_SIZE_OF_FIELD - get the number of elements of an array struct field +* +* @TYPE: The structure containing the field of interest +* @MEMBER: The array field to be sized +*/ +#define ARRAY_SIZE_OF_FIELD (TYPE ,MEMBER ) ARRAY_SIZE((((TYPE *)0)->MEMBER))
Some comment about the name:
ARRAY_SIZE() is rather ambiguous, as there's array_size()[1], which means the number of bytes needed to represent the array. I suggest a name based on
- _Lengthof() It has been proposed to ISO C to get the number of elements of an array:
<https://www.open-std.org/jtc1/sc22/wg14/www/docs/n2529.pdf>.
- sizeof_field() The kernel macro for the size of a struct member
So, how about lengthof_field()?
Cheers,
Alex
[1]: The definition of array_size() is here:
$ grep -rnB10 define.array_size include/linux/overflow.h 238-/** 239- * array_size() - Calculate size of 2-dimensional array. 240- * @a: dimension one 241- * @b: dimension two 242- * 243- * Calculates size of 2-dimensional array: @a * @b. 244- * 245- * Returns: number of bytes needed to represent the array or SIZE_MAX on 246- * overflow. 247- */ 248:#define array_size(a, b) size_mul(a, b)
Quoted 2 lines
include/linux/array_size.h +1
-0+#endif /* _LINUX_ARRAY_SIZE_H */
Signature · 2 lines
<http://www.alejandro-colomar.es/> GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5
Re: [PATCH 2/4] linux/array_size.h: Add ARRAY_SIZE_OF_FIELD()
Quoted 1 line · Alejandro Colomar
On 2023-08-17 16:33, Lucas Segarra Fernandez wrote:
...
Quoted 11 lines
Some comment about the name:
ARRAY_SIZE()is rather ambiguous, as there's array_size()[1], which means the number of bytes needed to represent the array. I suggest a name based on(quoted diff) +0
-2- _Lengthof() It has been proposed to ISO C to get the number of elements of an array: <https://www.open-std.org/jtc1/sc22/wg14/www/docs/n2529.pdf>. - sizeof_field() The kernel macro for the size of a struct member
Quoted 1 line
So, how about
lengthof_field()?
TBH I do not understand the motivation of making this kind of confusion and inconsistency. Are you suggesting renaming ARRAY_SIZE() to begin with? If so, it's definitely out of the scope of this series.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Re: [PATCH 2/4] linux/array_size.h: Add ARRAY_SIZE_OF_FIELD()
Hello Andy,
Quoted 16 lines · Andy Shevchenko
Quoted 1 line · Alejandro Colomar
On 2023-08-17 16:33, Lucas Segarra Fernandez wrote:
...
Quoted 11 lines
Some comment about the name:
ARRAY_SIZE()is rather ambiguous, as there's array_size()[1], which means the number of bytes needed to represent the array. I suggest a name based on(quoted diff) +0
-2- _Lengthof() It has been proposed to ISO C to get the number of elements of an array: <https://www.open-std.org/jtc1/sc22/wg14/www/docs/n2529.pdf>. - sizeof_field() The kernel macro for the size of a struct member
Quoted 8 lines
Quoted 1 line
So, how about
lengthof_field()?TBH I do not understand the motivation of making this kind of confusion and inconsistency.
Are you suggesting renaming
ARRAY_SIZE()
to begin with?
No. ARRAY_SIZE is a very old and known API. It is array_size() that is to be blamed, due to having a confusing name.
What I suggest is not reusing the root of the name of ARRAY_SIZE(), which since the addition of array_size() may be less unambiguous (IMHO).
So, instead of ARRAY_SIZE_*(), which is derived from ARRAY_SIZE(), maybe it would be more unambiguous to use the _Lengthof() name as a root, since nobody has messed with it so far.
My suggestion is to keep ARRAY_SIZE() with its old name, but use lengthof_field() for this struct variant of it. It's also a shorter name, which will make for shorter lines.
b19d57d0f3cc ("overflow.h: Add flex_array_size() helper")
- (Mon Jun 8 20:22:33 2020 -0500)610b15c50e86 ("overflow.h: Add allocation size calculation helpers")
- (Mon May 7 16:47:02 2018 -0700)
Nevertheless, it was just a minor suggestion, and if array_size() was seen as a good enough name, it wouldn't be as confusing as it seems to me. If you find them to be fine, go ahead.
Cheers,
Alex
Quoted 2 lines
If so, it's definitely out of the scope of this series.
Signature · 2 lines
<http://www.alejandro-colomar.es/> GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5
PATCH 3/4 crypto: qat - refactor included headers
In reply to Lucas Segarra FernandezInclude missing headeers for GENMASK(), kstrtobool and types.
Add forward declaration for struct adf_accel_dev. Remove unneeded include.
This change doesn't introduce any function change.
--- drivers/crypto/intel/qat/qat_common/adf_gen4_pm.c | 3 +++ drivers/crypto/intel/qat/qat_common/adf_gen4_pm.h | 4 +++- 2 files changed, 6 insertions(+), 1 deletion(-)
drivers/crypto/intel/qat/qat_common/adf_gen4_pm.c +3 -0
@@ -2,6 +2,9 @@/* Copyright(c) 2022 Intel Corporation */ #include <linux/bitfield.h> #include <linux/iopoll.h> +#include <linux/kstrtox.h> +#include <linux/types.h> +#include "adf_accel_devices.h" #include "adf_common_drv.h" #include "adf_gen4_pm.h"
drivers/crypto/intel/qat/qat_common/adf_gen4_pm.h +3 -1
@@ -3,7 +3,9 @@#ifndef ADF_GEN4_PM_H #define ADF_GEN4_PM_H -#include "adf_accel_devices.h" +#include <linux/bits.h> + +struct adf_accel_dev ;/* Power management registers */ #define ADF_GEN4_PM_HOST_MSG (0x50A01C)
Signature · 1 line
2.41.0
PATCH 4/4 crypto: qat - add pm_status debugfs file
In reply to Lucas Segarra FernandezQAT devices implement a mechanism that allows them to go autonomously to a low power state depending on the load.
Expose power management info by providing the "pm_status" file under debugfs. This includes PM state, PM event log, PM event counters, PM HW CSRs, per-resource type constrain counters and per-domain power gating status specific to the QAT device.
This information is retrieved from (1) the FW by means of ICP_QAT_FW_PM_INFO command, (2) CSRs and (3) counters collected by the device driver.
In addition, add logic to keep track and report power management event interrupts and acks/nacks sent to FW to allow/prevent state transitions.
--- Documentation/ABI/testing/debugfs-driver-qat | 9 + drivers/crypto/intel/qat/qat_common/Makefile | 1 + .../intel/qat/qat_common/adf_accel_devices.h | 13 + .../crypto/intel/qat/qat_common/adf_admin.c | 25 ++ .../intel/qat/qat_common/adf_common_drv.h | 1 + .../crypto/intel/qat/qat_common/adf_dbgfs.c | 3 + .../crypto/intel/qat/qat_common/adf_gen4_pm.c | 262 ++++++++++++++++++ .../crypto/intel/qat/qat_common/adf_gen4_pm.h | 34 +++ .../intel/qat/qat_common/adf_pm_dbgfs.c | 47 ++++ .../intel/qat/qat_common/adf_pm_dbgfs.h | 12 + .../qat/qat_common/icp_qat_fw_init_admin.h | 33 +++ 11 files changed, 440 insertions(+) create mode 100644 drivers/crypto/intel/qat/qat_common/adf_pm_dbgfs.c create mode 100644 drivers/crypto/intel/qat/qat_common/adf_pm_dbgfs.h
Documentation/ABI/testing/debugfs-driver-qat +9 -0
@@ -59,3 +59,12 @@ Description: (RO) Read returns the device health status. The driver does not monitor for Heartbeat. It is left for a user to poll the status periodically. + +What: /sys/kernel/debug/qat_<device>_<BDF>/pm_status +Date: November 2023 +KernelVersion: 6.6 +Contact: [email protected] +Description: (RO) Read returns power management information specific to the + QAT device. + + This attribute is only available for qat_4xxx devices.
drivers/crypto/intel/qat/qat_common/Makefile +1 -0
@@ -33,6 +33,7 @@ intel_qat-$(CONFIG_DEBUG_FS) += adf_transport_debug.o \ adf_fw_counters.o \ adf_heartbeat.o \ adf_heartbeat_dbgfs.o \ + adf_pm_dbgfs.o \ adf_dbgfs.o intel_qat-$(CONFIG_PCI_IOV) += adf_sriov.o adf_vf_isr.o adf_pfvf_utils.o \
drivers/crypto/intel/qat/qat_common/adf_accel_devices.h +13 -0
@@ -291,6 +291,18 @@ struct adf_dc_data {dma_addr_t ovf_buff_p; }; +struct adf_pm { +struct dentry *debugfs_pm_status; +bool present; +int idle_irq_counters; +int throttle_irq_counters; +int fw_irq_counters; +int host_ack_counter; +int host_nack_counter; +ssize_t (*print_pm_status)(struct adf_accel_dev *accel_dev,char __user *buf,size_t count, +loff_t *pos); +}; +struct adf_accel_dev {struct adf_etr_data *transport;struct adf_hw_device_data *hw_device;
@@ -298,6 +310,7 @@ struct adf_accel_dev {struct adf_fw_loader_data *fw_loader;struct adf_admin_comms *admin;struct adf_dc_data *dc_data; +struct adf_pm power_management;struct list_head crypto_list;struct list_head compression_list;unsigned long status;
drivers/crypto/intel/qat/qat_common/adf_admin.c +25 -0
@@ -348,6 +348,31 @@ int adf_init_admin_pm(struct adf_accel_dev *accel_dev, u32 idle_delay)return adf_send_admin (accel_dev, &req, &resp, ae_mask); } +int adf_get_pm_info (struct adf_accel_dev *accel_dev,dma_addr_t p_state_addr,size_t buff_size) +{ +struct adf_hw_device_data *hw_data = accel_dev->hw_device; +struct icp_qat_fw_init_admin_req req = { }; +struct icp_qat_fw_init_admin_resp resp; +u32 ae_mask = hw_data->admin_ae_mask; +int ret; + +/* Query pm info via init/admin cmd */ +if (!accel_dev->admin) { +dev_err (&GET_DEV (accel_dev),"adf_admin is not available\n" ); +return -EFAULT ; + } + + req.cmd_id =ICP_QAT_FW_PM_INFO ; + req.init_cfg_sz = buff_size; + req.init_cfg_ptr = p_state_addr; + + ret =adf_send_admin (accel_dev, &req, &resp, ae_mask); +if (ret) +dev_err (&GET_DEV (accel_dev),"Failed to query power-management info\n" ); + +return ret; +} +int adf_init_admin_comms (struct adf_accel_dev *accel_dev) {struct adf_admin_comms *admin;
drivers/crypto/intel/qat/qat_common/adf_common_drv.h +1 -0
@@ -93,6 +93,7 @@ int adf_init_admin_pm(struct adf_accel_dev *accel_dev, u32 idle_delay);int adf_send_admin_tim_sync (struct adf_accel_dev *accel_dev,u32 cnt);int adf_send_admin_hb_timer (struct adf_accel_dev *accel_dev,uint32_t ticks);int adf_get_fw_timestamp (struct adf_accel_dev *accel_dev,u64 *timestamp); +int adf_get_pm_info (struct adf_accel_dev *accel_dev,dma_addr_t p_state_addr,size_t buff_size);int adf_init_arb (struct adf_accel_dev *accel_dev);void adf_exit_arb (struct adf_accel_dev *accel_dev);void adf_update_ring_arb (struct adf_etr_ring_data *ring);
drivers/crypto/intel/qat/qat_common/adf_dbgfs.c +3 -0
@@ -8,6 +8,7 @@#include "adf_dbgfs.h" #include "adf_fw_counters.h" #include "adf_heartbeat_dbgfs.h" +#include "adf_pm_dbgfs.h" /** * adf_dbgfs_init() - add persistent debugfs entries
@@ -62,6 +63,7 @@ void adf_dbgfs_add(struct adf_accel_dev *accel_dev)if (!accel_dev->is_vf) {adf_fw_counters_dbgfs_add (accel_dev);adf_heartbeat_dbgfs_add (accel_dev); +adf_pm_dbgfs_add (accel_dev); } }
@@ -75,6 +77,7 @@ void adf_dbgfs_rm(struct adf_accel_dev *accel_dev)return ;if (!accel_dev->is_vf) { +adf_pm_dbgfs_rm (accel_dev);adf_heartbeat_dbgfs_rm (accel_dev);adf_fw_counters_dbgfs_rm (accel_dev); }
drivers/crypto/intel/qat/qat_common/adf_gen4_pm.c +262 -0
308 lines not on this page · raw message
drivers/crypto/intel/qat/qat_common/adf_gen4_pm.h +34 -0
@@ -41,7 +41,41 @@ struct adf_accel_dev;#define ADF_GEN4_PM_MAX_IDLE_FILTER (0x7)#define ADF_GEN4_PM_DEFAULT_IDLE_SUPPORT (0x1) +/* PM CSRs fields masks */ +#define ADF_GEN4_PM_DOMAIN_POWER_GATED_MASK GENMASK(15, 0) +#define ADF_GEN4_PM_SSM_PM_ENABLE_MASK GENMASK(15, 0) +#define ADF_GEN4_PM_IDLE_FILTER_MASK GENMASK(5, 3) +#define ADF_GEN4_PM_IDLE_ENABLE_MASK BIT(2) +#define ADF_GEN4_PM_ENABLE_PM_MASK BIT(21) +#define ADF_GEN4_PM_ENABLE_PM_IDLE_MASK BIT(22) +#define ADF_GEN4_PM_ENABLE_DEEP_PM_IDLE_MASK BIT(23) +#define ADF_GEN4_PM_CURRENT_WP_MASK GENMASK(19, 11) +#define ADF_GEN4_PM_CPM_PM_STATE_MASK GENMASK(22, 20) +#define ADF_GEN4_PM_PENDING_WP_MASK GENMASK(31, 23) +#define ADF_GEN4_PM_THR_VALUE_MASK GENMASK(6, 4) +#define ADF_GEN4_PM_MIN_PWR_ACK_MASK BIT(7) +#define ADF_GEN4_PM_MIN_PWR_ACK_PENDING_MASK BIT(17) +#define ADF_GEN4_PM_CPR_ACTIVE_COUNT_MASK BIT(0) +#define ADF_GEN4_PM_CPR_MANAGED_COUNT_MASK BIT(0) +#define ADF_GEN4_PM_XLT_ACTIVE_COUNT_MASK BIT(1) +#define ADF_GEN4_PM_XLT_MANAGED_COUNT_MASK BIT(1) +#define ADF_GEN4_PM_DCPR_ACTIVE_COUNT_MASK GENMASK(3, 2) +#define ADF_GEN4_PM_DCPR_MANAGED_COUNT_MASK GENMASK(3, 2) +#define ADF_GEN4_PM_PKE_ACTIVE_COUNT_MASK GENMASK(8, 4) +#define ADF_GEN4_PM_PKE_MANAGED_COUNT_MASK GENMASK(8, 4) +#define ADF_GEN4_PM_WAT_ACTIVE_COUNT_MASK GENMASK(13, 9) +#define ADF_GEN4_PM_WAT_MANAGED_COUNT_MASK GENMASK(13, 9) +#define ADF_GEN4_PM_WCP_ACTIVE_COUNT_MASK GENMASK(18, 14) +#define ADF_GEN4_PM_WCP_MANAGED_COUNT_MASK GENMASK(18, 14) +#define ADF_GEN4_PM_UCS_ACTIVE_COUNT_MASK GENMASK(20, 19) +#define ADF_GEN4_PM_UCS_MANAGED_COUNT_MASK GENMASK(20, 19) +#define ADF_GEN4_PM_CPH_ACTIVE_COUNT_MASK GENMASK(24, 21) +#define ADF_GEN4_PM_CPH_MANAGED_COUNT_MASK GENMASK(24, 21) +#define ADF_GEN4_PM_ATH_ACTIVE_COUNT_MASK GENMASK(28, 25) +#define ADF_GEN4_PM_ATH_MANAGED_COUNT_MASK GENMASK(28, 25) +int adf_gen4_enable_pm (struct adf_accel_dev *accel_dev);bool adf_gen4_handle_pm_interrupt (struct adf_accel_dev *accel_dev); +void adf_gen4_init_dev_pm_data (struct adf_accel_dev *accel_dev);#endif
drivers/crypto/intel/qat/qat_common/adf_pm_dbgfs.c new file +47 -0
47 lines not on this page · raw message
drivers/crypto/intel/qat/qat_common/adf_pm_dbgfs.h new file +12 -0
@@ -0,0 +1,12 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* Copyright(c) 2023 Intel Corporation */ + +#ifndef ADF_PM_DBGFS_H_ +#define ADF_PM_DBGFS_H_ + +struct adf_accel_dev ; + +void adf_pm_dbgfs_rm (struct adf_accel_dev *accel_dev); +void adf_pm_dbgfs_add (struct adf_accel_dev *accel_dev); + +#endif /* ADF_PM_DBGFS_H_ */
drivers/crypto/intel/qat/qat_common/icp_qat_fw_init_admin.h +33 -0
@@ -19,6 +19,7 @@ enum icp_qat_fw_init_admin_cmd_id {ICP_QAT_FW_HEARTBEAT_TIMER_SET =13 ,ICP_QAT_FW_TIMER_GET =19 ,ICP_QAT_FW_PM_STATE_CONFIG =128 , + ICP_QAT_FW_PM_INFO = 129, }; enum icp_qat_fw_init_admin_resp_status {
@@ -107,4 +108,36 @@ struct icp_qat_fw_init_admin_resp {#define ICP_QAT_FW_SYNC ICP_QAT_FW_HEARTBEAT_SYNC +struct icp_qat_fw_init_admin_pm_info { +__u16 max_pwrreq; +__u16 min_pwrreq; +__u16 resvrd1; +__u8 pwr_state; +__u8 resvrd2; +__u32 fusectl0; + struct_group(event_counters, + __u32 sys_pm; +__u32 host_msg; +__u32 unknown; +__u32 local_ssm; +__u32 timer; + ); +__u32 event_log[8 ]; + struct_group(pm, + __u32 fw_init; +__u32 pwrreq; +__u32 status; +__u32 main; +__u32 thread; + ); + struct_group(ssm, + __u32 pm_enable; +__u32 pm_active_status; +__u32 pm_managed_status; +__u32 pm_domain_status; +__u32 active_constraint; + ); +__u32 resvrd3[6 ]; +}; +#endif
Signature · 1 line
2.41.0
Herbert Xu
maintainerRe: [PATCH 4/4] crypto: qat - add pm_status debugfs file
Quoted 4 lines · Lucas Segarra Fernandez
drivers/crypto/intel/qat/qat_common/adf_gen4_pm.c +3
-0+static struct pm_status_row pm_event_rows[] = { +PM_INFO_REGSET_ENTRY32 (event_log[0 ],EVENT0 ), +PM_INFO_REGSET_ENTRY32 (event_log[1 ],EVENT1 ),
drivers/crypto/intel/qat/qat_common/adf_gen4_pm.c int adf_gen4_enable_pm(struct adf_accel_dev *accel_dev) · line 272
Quoted 10 lines
drivers/crypto/intel/qat/qat_common/adf_gen4_pm.c +10
-0+PM_INFO_REGSET_ENTRY32 (event_log[2 ],EVENT2 ), +PM_INFO_REGSET_ENTRY32 (event_log[3 ],EVENT3 ), +PM_INFO_REGSET_ENTRY32 (event_log[4 ],EVENT4 ), +PM_INFO_REGSET_ENTRY32 (event_log[5 ],EVENT5 ), +PM_INFO_REGSET_ENTRY32 (event_log[6 ],EVENT6 ), + PM_INFO_REGSET_ENTRY32(event_log[7], EVENT7), +}; + +static_assert(ARRAY_SIZE_OF_FIELD(struct icp_qat_fw_init_admin_pm_info, event_log) == +ARRAY_SIZE (pm_event_rows));
Was all of that churn just for this one line?
How about simply declaring a macro
#define QAT_NUMBER_OF_PM_EVENTS 8
and then use it for the two arrays:
static struct pm_status_row pm_event_rows[QAT_NUMBER_OF_PM_EVENTS] = {
__u32 event_log[QAT_NUMBER_OF_PM_EVENTS];What am I missing?
Cheers,
Signature · 3 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Re: [PATCH 4/4] crypto: qat - add pm_status debugfs file
Quoted 22 lines · Herbert Xu
Quoted 4 lines · Lucas Segarra Fernandez
drivers/crypto/intel/qat/qat_common/adf_gen4_pm.c +3
-0+static struct pm_status_row pm_event_rows[] = { +PM_INFO_REGSET_ENTRY32 (event_log[0 ],EVENT0 ), +PM_INFO_REGSET_ENTRY32 (event_log[1 ],EVENT1 ),drivers/crypto/intel/qat/qat_common/adf_gen4_pm.c int adf_gen4_enable_pm(struct adf_accel_dev *accel_dev) · line 272
Quoted 10 lines
drivers/crypto/intel/qat/qat_common/adf_gen4_pm.c +10
-0+PM_INFO_REGSET_ENTRY32 (event_log[2 ],EVENT2 ), +PM_INFO_REGSET_ENTRY32 (event_log[3 ],EVENT3 ), +PM_INFO_REGSET_ENTRY32 (event_log[4 ],EVENT4 ), +PM_INFO_REGSET_ENTRY32 (event_log[5 ],EVENT5 ), +PM_INFO_REGSET_ENTRY32 (event_log[6 ],EVENT6 ), + PM_INFO_REGSET_ENTRY32(event_log[7], EVENT7), +}; + +static_assert(ARRAY_SIZE_OF_FIELD(struct icp_qat_fw_init_admin_pm_info, event_log) == +ARRAY_SIZE (pm_event_rows));Was all of that churn just for this one line?
How about simply declaring a macro
#define QAT_NUMBER_OF_PM_EVENTS 8
Quoted 7 lines
and then use it for the two arrays:
static struct pm_status_row pm_event_rows[QAT_NUMBER_OF_PM_EVENTS] = { __u32 event_log[QAT_NUMBER_OF_PM_EVENTS];What am I missing?
Splitting ARRAY_SIZE() is very beneficial on its own.
The static assert is slightly more robust for the big code then defining something that at some point can be missed or miscalculated. Yet we can survive with a macro if you thinks it's better.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Herbert Xu
maintainerRe: [PATCH 4/4] crypto: qat - add pm_status debugfs file
Quoted 5 lines · Andy Shevchenko
Splitting
ARRAY_SIZE()is very beneficial on its own.
The static assert is slightly more robust for the big code then defining something that at some point can be missed or miscalculated. Yet we can survive with a macro if you thinks it's better.
Yes please go ahead with just a macro.
If the ARRYA_SIZE thing turns out to be useful for other people I'm sure it'll be added. But I don't see much value in this particular use.
Thanks,
Signature · 3 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
PATCH 1/1 linux/container_of.h: Add memberof()
In reply to Andy ShevchenkoFrom: Alejandro Colomar <[email protected]>
Hi!
Quoted 16 lines · Andy Shevchenko
Quoted 15 lines · Herbert Xu
Quoted 4 lines · Lucas Segarra Fernandez
(quoted diff) +3
-0+static struct pm_status_row pm_event_rows[] = { + PM_INFO_REGSET_ENTRY32(event_log[0], EVENT0), + PM_INFO_REGSET_ENTRY32(event_log[1], EVENT1),Review
Quoted 10 lines
(quoted diff) +10
-0+ PM_INFO_REGSET_ENTRY32(event_log[2], EVENT2), + PM_INFO_REGSET_ENTRY32(event_log[3], EVENT3), + PM_INFO_REGSET_ENTRY32(event_log[4], EVENT4), + PM_INFO_REGSET_ENTRY32(event_log[5], EVENT5), + PM_INFO_REGSET_ENTRY32(event_log[6], EVENT6), + PM_INFO_REGSET_ENTRY32(event_log[7], EVENT7), +}; + +static_assert(ARRAY_SIZE_OF_FIELD(struct icp_qat_fw_init_admin_pm_info, event_log) == + ARRAY_SIZE(pm_event_rows));
How about the following?
static_assert(ARRAY_SIZE(pm_event_rows) ==
ARRAY_SIZE(memberof(struct icp_qat_fw_init_admin_pm_info, event_log)));
It would only need one macro addition, without significant churn. It's even less typing. Below is a scissor patch with the addition of memberof().
I tried building the kernel, and didn't see any warnings form the patch below.
Cheers,
Alex
Quoted 11 lines
Quoted 11 lines
Was all of that churn just for this one line?
How about simply declaring a macro
#define QAT_NUMBER_OF_PM_EVENTS 8and then use it for the two arrays:
static struct pm_status_row pm_event_rows[QAT_NUMBER_OF_PM_EVENTS] = {
Quoted 9 lines
Quoted 3 lines
__u32 event_log[QAT_NUMBER_OF_PM_EVENTS];What am I missing?
Splitting
ARRAY_SIZE()is very beneficial on its own.
The static assert is slightly more robust for the big code then defining something that at some point can be missed or miscalculated. Yet we can survive with a macro if you thinks it's better.
-----8<------------
Many xxxof_{member,field}() macros make use of the same construction to refer to a member of a struct without needing a variable of the structure type.
memberof(T, m) simplifies all of those, avoids possible mistakes in repetition, adds a meaningful name to the construction, and improves readability by avoiding too many parentheses together.
It uses a compound literal, which should optimized out by the compiler. It's a bit simpler to read than the dereference of a casted null pointer, due to having less parentheses in the implementation.
--- include/linux/container_of.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
include/linux/container_of.h +3 -1
@@ -5,7 +5,9 @@#include <linux/build_bug.h> #include <linux/stddef.h> -#define typeof_member (T , m) typeof(((T*)0)->m) + +#define memberof (T , member) ((T){}.member) +#define typeof_member (T , m) typeof(memberof(T, m))/** * container_of - cast a member of a structure out to the containing structure
Signature · 1 line
2.40.1
Andy Shevchenko
reviewerRe: [PATCH] linux/container_of.h: Add memberof()
Quoted 3 lines · Alejandro Colomar
Quoted 2 lines · Andy Shevchenko
Quoted 1 line · Herbert Xu
On Thu, Aug 17, 2023 at 04:33:17PM +0200, Lucas Segarra Fernandez wrote:
...
Quoted 26 lines
Many xxxof_{member,field}() macros make use of the same construction to refer to a member of a struct without needing a variable of the structure type.
memberof(T, m)simplifies all of those, avoids possible mistakes in repetition, adds a meaningful name to the construction, and improves readability by avoiding too many parentheses together.It uses a compound literal, which should optimized out by the compiler. It's a bit simpler to read than the dereference of a casted null pointer, due to having less parentheses in the implementation.
Cc Andy Shevchenko <[email protected]>Cc Herbert Xu <[email protected]>Cc Lucas Segarra Fernandez <[email protected]>Cc Giovanni Cabiddu <[email protected]>Signed-off-by Alejandro Colomar <[email protected]>--- include/linux/container_of.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)include/linux/container_of.h +0
-0
include/linux/container_of.h line 9
Quoted 6 lines
include/linux/container_of.h +2
-1@@ -5,7 +5,9 @@#include <linux/build_bug.h> #include <linux/stddef.h> -#define typeof_member (T , m) typeof(((T*)0)->m) + +#define memberof (T , member) ((T){}.member)
I'm not sure. This seems to me utilization of compound literal, while above uses direct struct member pointer calculations.
Quoted 1 line
include/linux/container_of.h +1
-0+#define typeof_member (T , m) typeof(memberof(T, m))
Signature · 2 lines
With Best Regards, Andy Shevchenko
Re: [PATCH] linux/container_of.h: Add memberof()
Hi Andy,
Quoted 8 lines · Andy Shevchenko
include/linux/container_of.h line 9
Quoted 4 lines · Alejandro Colomar
include/linux/container_of.h +2
-1-#define typeof_member (T , m) typeof(((T*)0)->m) + +#define memberof (T , member) ((T){}.member)I'm not sure. This seems to me utilization of compound literal, while above uses direct struct member pointer calculations.
Both can be used in most cases. The only exception is offsetof(3), where you need the pointer calculation. The good thing about the compound literal is that it's farther away from causing UB, but if that's not a concern --using sizeof() or typeof() will usually make things safe from UB, as there's really no dereference, but just to be a little paranoic--, I could change the definition of memberof() to use the pointer thing.
Should I send a v2 with the pointer thing?
[I'll take some time, as I need to restore my USB with keys, which just died yesterday. I didn't sign this email due to that.]
Cheers,
Alex
Quoted 3 lines
Quoted 2 lines
+#define
typeof_member(T, m)typeof(memberof(T, m))
Signature · 2 lines
<http://www.alejandro-colomar.es/> GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5