Skip to contentSkip to conversation

pinctrl: cherryview: use ACPI_HANDLE() to pass handle

PATCH In review Raag Jadav 2 participants 2 messages Aug 21, 2023

Subsystems (3)
lore
Share & tools
lore

Raag Jadav

author
#0 lore raw

PATCH 1/1 pinctrl: cherryview: use ACPI_HANDLE() to pass handle

Use ACPI_HANDLE() to pass handle to acpi_*_address_space_handler() APIs.

Fixes a0b028597d59 ("pinctrl: cherryview: Add support for GMMR GPIO opregion")
---
 drivers/pinctrl/intel/pinctrl-cherryview.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/pinctrl/intel/pinctrl-cherryview.c +2 -3
index 2c619fcf93ca..5a50bee48873 100644
@@ -1650,7 +1650,6 @@ static int chv_pinctrl_probe(struct platform_device *pdev)
 	struct intel_community_context *cctx;
 	struct intel_community *community;
 	struct device *dev = &pdev->dev;
-	struct acpi_device *adev = ACPI_COMPANION(dev);
 	struct intel_pinctrl *pctrl;
 	acpi_status status;
 	unsigned int i;
@@ -1718,7 +1717,7 @@ static int chv_pinctrl_probe(struct platform_device *pdev)
 	if (ret)
 		return ret;
 
-	status = acpi_install_address_space_handler(adev->handle,
+	status = acpi_install_address_space_handler(ACPI_HANDLE(dev),
 					community->acpi_space_id,
 					chv_pinctrl_mmio_access_handler,
 					NULL, pctrl);
@@ -1735,7 +1734,7 @@ static int chv_pinctrl_remove(struct platform_device *pdev)
 	struct intel_pinctrl *pctrl = platform_get_drvdata(pdev);
 	const struct intel_community *community = &pctrl->communities[0];
 
-	acpi_remove_address_space_handler(ACPI_COMPANION(&pdev->dev),
+	acpi_remove_address_space_handler(ACPI_HANDLE(&pdev->dev),
 					  community->acpi_space_id,
 					  chv_pinctrl_mmio_access_handler);
 
Signature · 1 line
2.17.1
maintainer
#1 lore raw
Quoted 1 line · Raag Jadav

Use ACPI_HANDLE() to pass handle to acpi_*_address_space_handler() APIs.

Please explain here that this actually fixes a bug on the remove path where we pass an incorrect pointer. Please adjust the $subject accordingly.

Quoted 1 line
Fixes a0b028597d59 ("pinctrl: cherryview: Add support for GMMR GPIO opregion")

Add also Cc: [email protected]