mm-always-lock-new-vma-before-inserting-into-vma-tree.patch removed from -mm tree
The quilt patch titled
Subject: mm: always lock new vma before inserting into vma tree
has been removed from the -mm tree. Its filename was
mm-always-lock-new-vma-before-inserting-into-vma-tree.patch
This patch was dropped because it was merged into the mm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
------------------------------------------------------
From: Suren Baghdasaryan <[email protected]>
Subject: mm: always lock new vma before inserting into vma tree
Date: Fri, 4 Aug 2023 08:27:23 -0700
While it's not strictly necessary to lock a newly created vma before adding it into the vma tree (as long as no further changes are performed to it), it seems like a good policy to lock it and prevent accidental changes after it becomes visible to the page faults. Lock the vma before adding it into the vma tree.
---
mm/mmap.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
mm/mmap.c renamed from mm/mmap.c~mm-always-lock-new-vma-before-inserting-into-vma-tree +5 -2
@@ -401,6 +401,8 @@ static int vma_link(struct mm_struct *mmif (vma_iter_prealloc (&vmi, vma))return -ENOMEM ; +vma_start_write (vma); +vma_iter_store (&vmi, vma);if (vma->vm_file) {
@@ -463,7 +465,8 @@ static inline void vma_prepare(struct vmvma_start_write (vp->vma);if (vp->adj_next)vma_start_write (vp->adj_next); -/* vp->insert is always a newly created VMA, no need for locking */ +if (vp->insert) +vma_start_write (vp->insert);if (vp->remove)vma_start_write (vp->remove);if (vp->remove2)
@@ -3093,6 +3096,7 @@ static int do_brk_flags(struct vma_itera vma->vm_pgoff = addr >>PAGE_SHIFT ;vm_flags_init (vma, flags); vma->vm_page_prot =vm_get_page_prot (flags); +vma_start_write (vma);if (vma_iter_store_gfp (vmi, vma,GFP_KERNEL )) goto mas_store_fail;
@@ -3341,7 +3345,6 @@ struct vm_area_struct *copy_vma(struct vget_file (new_vma->vm_file);if (new_vma->vm_ops && new_vma->vm_ops->open) new_vma->vm_ops->open (new_vma); -vma_start_write (new_vma);if (vma_link (mm, new_vma)) goto out_vma_link; *need_rmap_locks = false;
_
Patches currently in -mm which might be from [email protected] are
swap-remove-remnants-of-polling-from-read_swap_cache_async.patch mm-add-missing-vm_fault_result_trace-name-for-vm_fault_completed.patch mm-drop-per-vma-lock-when-returning-vm_fault_retry-or-vm_fault_completed.patch mm-change-folio_lock_or_retry-to-use-vm_fault-directly.patch mm-handle-swap-page-faults-under-per-vma-lock.patch mm-handle-userfaults-under-vma-lock.patch mm-handle-userfaults-under-vma-lock-fix.patch