KVM: x86: Allow exposure of VMware backdoor Pseudo-PMCs when !enable_pmu
PATCH 1/1 KVM: x86: Allow exposure of VMware backdoor Pseudo-PMCs when !enable_pmu
From: Like Xu <[email protected]>
Fix kvm_pmu_rdpmc() logic to allow exposure of VMware backdoor Pseudo-PMCs if pmu is globally disabled.
In this usage scenario, once vmware_backdoor is enabled, the VMs can fully utilize all of the vmware_backdoor-related resources, not just part of it, i.e., vcpu should always be able to access the VMware backdoor Pseudo-PMCs via RDPMC. Since the enable_pmu is more concerned with the visibility of hardware pmu resources on the host, fix it to decouple the two knobs.
The test case vmware_backdoors from KUT is used for validation.
--- arch/x86/kvm/pmu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
arch/x86/kvm/pmu.c +3 -3
@@ -526,12 +526,12 @@ int kvm_pmu_rdpmc(struct kvm_vcpu *vcpu, unsigned idx, u64 *data)struct kvm_pmc *pmc;u64 mask = fast_mode ? ~0u : ~0ull ; -if (!pmu->version) -return 1 ; -if (is_vmware_backdoor_pmc (idx))return kvm_pmu_rdpmc_vmware (vcpu, idx, data); +if (!pmu->version) +return 1 ; + pmc =static_call (kvm_x86_pmu_rdpmc_ecx_to_pmc)(vcpu, idx, &mask);if (!pmc)return 1 ;
base-commit: fff2e47e6c3b8050ca26656693caa857e3a8b740
Signature · 1 line
2.41.0
Sean Christopherson
maintainerQuoted 5 lines · Like Xu
From: Like Xu <[email protected]>
Fix
kvm_pmu_rdpmc()logic to allow exposure of VMware backdoor Pseudo-PMCs if pmu is globally disabled.
Quoted 7 lines
In this usage scenario, once
vmware_backdooris enabled, the VMs can fully utilize all of the vmware_backdoor-related resources, not just part of it, i.e., vcpu should always be able to access the VMware backdoor Pseudo-PMCs via RDPMC. Since theenable_pmuis more concerned with the visibility of hardware pmu resources on the host, fix it to decouple the two knobs.The test case
vmware_backdoorsfrom KUT is used for validation.
Is there a real world need for this? Per commit 672ff6cff80c ("KVM: x86: Raise #GP when guest vCPU do not support PMU"), KVM's behavior is intentional. If there is a real world need, then (a) that justification needs to be provided, (b) this needs a Fixes:, and (c) this probably needs to be tagged for stable.
Quoted 3 lines
Cc Arbel Moshe <[email protected]>Cc Liran Alon <[email protected]>Cc Nikita Leshenko <[email protected]>
The expectation is that a Cc: in the changelog means the patch email is Cc'd to that person, i.e. one of the purposes of Cc: here is to record that people who might care about the patch have been made aware of its existence. stable@ is pretty much the only exception to that rule, as "Cc: [email protected]" is really just a metadata tag for scripts.
FWIW, I believe Liran no longer works for Oracle, no idea about the others.
Quoted 30 lines
Signed-off-by Like Xu <[email protected]>--- arch/x86/kvm/pmu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)arch/x86/kvm/pmu.c +3
-3@@ -526,12 +526,12 @@ int kvm_pmu_rdpmc(struct kvm_vcpu *vcpu, unsigned idx, u64 *data)struct kvm_pmc *pmc;u64 mask = fast_mode ? ~0u : ~0ull ; -if (!pmu->version) -return 1 ; -if (is_vmware_backdoor_pmc (idx))return kvm_pmu_rdpmc_vmware (vcpu, idx, data); +if (!pmu->version) +return 1 ; + pmc =static_call (kvm_x86_pmu_rdpmc_ecx_to_pmc)(vcpu, idx, &mask);if (!pmc)return 1 ;base-commit:
fff2e47e6c3b8050ca26656693caa857e3a8b740Signature · 1 line
2.41.0
Hi folks,
Please help confirm if VMware backdoor Pseudo-PMCs [*] are still available when the KVM module parameter eneble_pmu=0.
- VMWARE_BACKDOOR_PMC_HOST_TSC;
- VMWARE_BACKDOOR_PMC_REAL_TIME;
- VMWARE_BACKDOOR_PMC_APPARENT_TIME;
I'd like to say yes, but safely you have the official right to define it. Thanks.
[*] https://www.vmware.com/files/pdf/techpaper/Timekeeping-In-VirtualMachines.pdf
Quoted 61 lines · Sean Christopherson
Quoted 5 lines · Like Xu
From: Like Xu <[email protected]>
Fix
kvm_pmu_rdpmc()logic to allow exposure of VMware backdoor Pseudo-PMCs if pmu is globally disabled.Quoted 7 lines
In this usage scenario, once
vmware_backdooris enabled, the VMs can fully utilize all of the vmware_backdoor-related resources, not just part of it, i.e., vcpu should always be able to access the VMware backdoor Pseudo-PMCs via RDPMC. Since theenable_pmuis more concerned with the visibility of hardware pmu resources on the host, fix it to decouple the two knobs.The test case
vmware_backdoorsfrom KUT is used for validation.Is there a real world need for this? Per commit
672ff6cff80c("KVM: x86: Raise #GP when guest vCPU do not support PMU"), KVM's behavior is intentional. If there is a real world need, then (a) that justification needs to be provided, (b) this needs a Fixes:, and (c) this probably needs to be tagged for stable.Quoted 3 lines
Cc Arbel Moshe <[email protected]>Cc Liran Alon <[email protected]>Cc Nikita Leshenko <[email protected]>The expectation is that a Cc: in the changelog means the patch email is Cc'd to that person, i.e. one of the purposes of Cc: here is to record that people who might care about the patch have been made aware of its existence. stable@ is pretty much the only exception to that rule, as "Cc: [email protected]" is really just a metadata tag for scripts.
FWIW, I believe Liran no longer works for Oracle, no idea about the others.
Quoted 30 lines
Signed-off-by Like Xu <[email protected]>--- arch/x86/kvm/pmu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)arch/x86/kvm/pmu.c +3
-3@@ -526,12 +526,12 @@ int kvm_pmu_rdpmc(struct kvm_vcpu *vcpu, unsigned idx, u64 *data)struct kvm_pmc *pmc;u64 mask = fast_mode ? ~0u : ~0ull ; -if (!pmu->version) -return 1 ; -if (is_vmware_backdoor_pmc (idx))return kvm_pmu_rdpmc_vmware (vcpu, idx, data); +if (!pmu->version) +return 1 ; + pmc =static_call (kvm_x86_pmu_rdpmc_ecx_to_pmc)(vcpu, idx, &mask);if (!pmc)return 1 ;base-commit:
fff2e47e6c3b8050ca26656693caa857e3a8b740Signature · 1 line
2.41.0